Received: by 2002:a05:7412:2a8c:b0:e2:908c:2ebd with SMTP id u12csp2103760rdh; Tue, 26 Sep 2023 12:31:16 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFxOcL5JVE6oVMmkabkw5s22w8TttDnvEYHDtWmvYnh7Ig9rRRdfpNbNIxV+y9nxFkne905 X-Received: by 2002:a05:6a20:978c:b0:155:bff3:ea1a with SMTP id hx12-20020a056a20978c00b00155bff3ea1amr10105099pzc.33.1695756676158; Tue, 26 Sep 2023 12:31:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695756676; cv=none; d=google.com; s=arc-20160816; b=agnQ5rR2F2T3JDmJfGeJ7eafxWPo3eSyft9UtM8pWqIePis2lmd13I/TUg9lJDMoEM mYQg7L1cAY0vNWRMU3Ai/183Vj9w5o/HqSQlrxmj38bMCM8Y8NdjnGwWSqyh2lxT4REX oU8PzenX3bWDyZrc0Mo7ZSgzUwhD5umqjFhHe8+GH8sDdjc7VahCS1Z2WS4N034pJ/mF oBS6iYDYfC46XruS/WFUztLgl9ZjCEd996ufbMWbA1Ui5aXA/aSWhAjje14aKcZbECnr eP5IVW80QedRw67JXstJym2KKpbwWEpyDKa7W5xN+LZqc1sw94bpI8FJAqiuvutU8Ctl Y4zg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=Hmvi5r0uoIOfgf9Tuw7hGOKzWO5Nc0N/qKV4SUrHuFs=; fh=jVz72fgPCwjTqAuMIDRURAn0DoKQ/lsrPxu39NMBAJ4=; b=gu3Ev3FkJVqtlqrvOwnolj20GShPVjUf2cyJAg97n2ypBfC0vNf9vA2G5ctE2edIgp N8K7FfOPLgs4TTKyxbFtiVNB5A2VOOyWUdQRtGhXD9nu8QcxVxE6azJeRWreGZS8rxfL hL8tLoFgB9MPNR+dArNSfGxmHrjwmyca28lk6Htf2HVMMBihTNpFwg5H0OfweKJ+cIBG q0dwRBijl9m0rKkd7shyfKQwhe4Fa8c9gGtiC3qj6HhNM8UjrnMhou3g3nYHjyHB+jma aektsdqoEnxWnkpLqqy4Uep4+SxUzMlpQQ5i9yatrqePMfEf8vy6NHgXjsF92sA6E/EW 0ypA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=BGd0YDQe; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from howler.vger.email (howler.vger.email. [2620:137:e000::3:4]) by mx.google.com with ESMTPS id j9-20020a056a00234900b00690fe3ec830si14233087pfj.55.2023.09.26.12.31.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Sep 2023 12:31:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=BGd0YDQe; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 5E4B08031F2F; Tue, 26 Sep 2023 09:06:48 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235176AbjIZQGr (ORCPT + 56 others); Tue, 26 Sep 2023 12:06:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50738 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235111AbjIZQGq (ORCPT ); Tue, 26 Sep 2023 12:06:46 -0400 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CAB6411D for ; Tue, 26 Sep 2023 09:06:39 -0700 (PDT) Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 38QD4kUb019616; Tue, 26 Sep 2023 16:06:35 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=Hmvi5r0uoIOfgf9Tuw7hGOKzWO5Nc0N/qKV4SUrHuFs=; b=BGd0YDQeCLiqVXLvPCFd2kz/g6Uw/CXwrbOAUFjQjbaeYpv55W7JWQCmutO0LPhIZ9M0 Z5n5wcLli+xmo6pyaSAX8a2I/zqizxeX06eeNuquOr/Dw5+soXvu+fyv3h7kqKH7lfAp lJGcs6xcNZt8U0SLSU1v7MebpPub+9gMe7l1Ls2vgXPIrkFnVhMwrSLpzKD7jFN3PWAV Lx+Nfo+2hOyVvjqyyQ/AVgwxT+axOiXQDUtPgM50x1EXZZBddMKBVya5RGEE5thFT7dQ ENawB9ubZSDAkuLfD4L01vKV1TrMrTtIUMb4/9nnTU+uukdJ6sigSaoH//t7isTwNdye vg== Received: from nalasppmta02.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3tbw9bgxtb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 26 Sep 2023 16:06:34 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA02.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 38QG6YsM022120 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 26 Sep 2023 16:06:34 GMT Received: from [10.48.244.213] (10.49.16.6) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.36; Tue, 26 Sep 2023 09:06:33 -0700 Message-ID: <9bf5f334-2e4c-492f-8b8c-65b3ae08b0b9@quicinc.com> Date: Tue, 26 Sep 2023 09:06:33 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] [v2] wifi: ath11k: fix ath11k_mac_op_remain_on_channel() stack usage Content-Language: en-US To: Dmitry Antipov CC: Tom Rix , Kalle Valo , References: <30dfbf07-9ec9-4ac9-8199-9f08dbe03739@quicinc.com> <20230926042906.13725-1-dmantipov@yandex.ru> From: Jeff Johnson In-Reply-To: <20230926042906.13725-1-dmantipov@yandex.ru> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.49.16.6] X-ClientProxiedBy: nalasex01c.na.qualcomm.com (10.47.97.35) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: X_gr59pGPrY44WuxdyXKlGqEomfLdeuz X-Proofpoint-ORIG-GUID: X_gr59pGPrY44WuxdyXKlGqEomfLdeuz X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-09-26_13,2023-09-26_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 priorityscore=1501 lowpriorityscore=0 suspectscore=0 adultscore=0 malwarescore=0 mlxscore=0 bulkscore=0 clxscore=1015 spamscore=0 mlxlogscore=999 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2309180000 definitions=main-2309260141 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Tue, 26 Sep 2023 09:06:48 -0700 (PDT) On 9/25/2023 9:29 PM, Dmitry Antipov wrote: > When compiling with clang 16.0.6, I've noticed the following: > > drivers/net/wireless/ath/ath11k/mac.c:8903:12: warning: stack frame > size (1032) exceeds limit (1024) in 'ath11k_mac_op_remain_on_channel' > [-Wframe-larger-than] > static int ath11k_mac_op_remain_on_channel(struct ieee80211_hw *hw, > ^ > 68/1032 (6.59%) spills, 964/1032 (93.41%) variables > > So switch to kzalloc()'ed instance of 'struct scan_req_params' like > it's done in 'ath11k_mac_op_hw_scan()'. Compile tested only. > > Signed-off-by: Dmitry Antipov Acked-by: Jeff Johnson