Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Message-ID: <9ddcbc2f-5e40-48cd-bdbd-943bd86acb61@quicinc.com>
Date:   Tue, 26 Sep 2023 13:35:37 -0700
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] wifi: nl80211: remove set_fils_aad support
Content-Language: en-US
To:     Johannes Berg <johannes@sipsolutions.net>,
        <linux-wireless@vger.kernel.org>
CC:     Johannes Berg <johannes.berg@intel.com>
References: <20230926160950.d698c25528e3.If118a835a25c59de20e1728ab71949fdb4172fb2@changeid>
From:   Jeff Johnson <quic_jjohnson@quicinc.com>
In-Reply-To: <20230926160950.d698c25528e3.If118a835a25c59de20e1728ab71949fdb4172fb2@changeid>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 9/26/2023 7:09 AM, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@intel.com>
> 
> There's no user for this, so remove the support.
> 
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>

if you are going to remove it, why not just revert e306784a8de0 
("cfg80211: AP mode driver offload for FILS association crypto") to make 
sure you get all of the artifacts? for example, I believe your patch 
will leave behind an unused struct cfg80211_fils_aad and unused 
FILS_AAD_ASSIGN() trace helper macro.

the caveat to reverting is that it should only be a partial revert; the 
UAPI definitions would need to be retained (and should be documented as 
obsolete).

however, let me check to make sure there is no plan to actually utilize 
this interface upstream. as i've indicated earlier, we are in the 
process of trying to transition to an "upstream first" mentality, but 
this is not going to happen overnight, but instead will take years. that 
said, i'd hate to rip out an interface now just to need to add it back 
in the future.

/jeff