Received: by 2002:a05:7412:2a8c:b0:e2:908c:2ebd with SMTP id u12csp2393685rdh; Wed, 27 Sep 2023 00:49:00 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF2Fuadi49QeR99c+Dz/WsBbbVXsqvgorhvFExUioz7xMleJvFgfMmRdYHRxL4t2diC1J+K X-Received: by 2002:a17:903:248:b0:1b8:8b72:fa28 with SMTP id j8-20020a170903024800b001b88b72fa28mr864198plh.58.1695800939882; Wed, 27 Sep 2023 00:48:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695800939; cv=none; d=google.com; s=arc-20160816; b=SkimU0B89q6t+R3VQYnyCwFyn94YMzlhZzCXxlS3T1PlMnV+axSWiPwmsSV2+pB0Cj DRSaayEL8a+dRL9LnxsYcL7+HFE6v+8ZV2d9vGDFtDpFG/jA2N5XwJ28slqHnbsgmIgA 7HFkye4NF8D6FvfcC9MC2UEluZKfNDSWYJzISBEI3fENi+ZkQJCElGnqiJk2FhfPVjGB pAwisV7vJG2QkzBNfYbpGkLBbjAT0dla0Iemcq8qh+ABcKin2VuA5Wq8O5Iqb87umBjd DItF0wOaEn55/RUQzRswYIclCCsI2HEc9RHQiPeiapowIT6vvuLCRlzry0KZoCOaDyxi n3GQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent :content-transfer-encoding:references:in-reply-to:date:cc:to:from :subject:message-id:dkim-signature; bh=COVzJlCjkIJzEAzNkBevFRzBhs8gP5wTdIzIYOr5xsM=; fh=bw6avefgSegYlwFXr64kEWRwtk1wWqyjry+z2hs7lZY=; b=FJKPFs5S3u+n7lk3IzCAF48Qr83Z4lv8X/tk32PELn6v3BbqAg8eob8yr+zFd1mIwv hGU6SVHVnQ+RVuqBTiFvW2qugOgFKdmMB8rdaaKC9yAxzxNxpJ3M4FF69Cj+LAslzoyP IVWIS6anZUX8hi8tXbtOW+xzs+cmrjitrB6T5nxYjzZAsK0kJcOhaOSWOsgJTW5yo+m+ i+CxNih71YSfAlEc4HcAAEfOofsZj1RS/kfCRtHXt4EaYm/0FVuJJklc/OOWHRRwcwrE kWK48fa+WP2K8rJz77uTbi4Nzvefdo/hQ5C/0AWv804OYV4nylSJTS5EMfpZqsKO730w bpPA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sipsolutions.net header.s=mail header.b=RzbzzZBE; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=sipsolutions.net Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [2620:137:e000::3:3]) by mx.google.com with ESMTPS id kf12-20020a17090305cc00b001b89bd6fd59si9528523plb.215.2023.09.27.00.48.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Sep 2023 00:48:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3; Authentication-Results: mx.google.com; dkim=pass header.i=@sipsolutions.net header.s=mail header.b=RzbzzZBE; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=sipsolutions.net Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 52CC481CDE19; Tue, 26 Sep 2023 09:44:09 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235312AbjIZQoN (ORCPT + 56 others); Tue, 26 Sep 2023 12:44:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42166 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231300AbjIZQoL (ORCPT ); Tue, 26 Sep 2023 12:44:11 -0400 Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:242:246e::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A56D7B3 for ; Tue, 26 Sep 2023 09:44:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=MIME-Version:Content-Transfer-Encoding: Content-Type:References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=COVzJlCjkIJzEAzNkBevFRzBhs8gP5wTdIzIYOr5xsM=; t=1695746644; x=1696956244; b=RzbzzZBE3tlOB/pnJHZJlJpIVcEjwxSAf/QBgUm/HMzDe20 pZ/XdKru3ZkTaEC4UVzVhMA9HyVXbwxP397Z9vq/KUvgTagvbOnhI+M+TC1k2arRMjPwqQuE7xZVl Abbh5sG+OUs6j9Yd+mKvHmlDrdyt4kuoWj/ltOonOqTMUtFsx+QnXPyfnmIbpkOVtFX80xtNzsPqT mJFv7huk83OP4L5H2X8NCWzwHBnDtpM8e9InWmyLzBOJQcC554J/gr0DjdtSesbHjqYC1mdRhZNW9 PTwuqCBloOMLCNwv9dQvhs8Xknm2QagLx+b7+ASUZ4qysq+Lx9sbLv1t9+SxszRQ==; Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.96) (envelope-from ) id 1qlBAD-005qwV-1s; Tue, 26 Sep 2023 18:43:57 +0200 Message-ID: <49b5de54ca00f5521ceaa8210f587f2af48d6835.camel@sipsolutions.net> Subject: Re: [PATCH v2] wifi: ath11k: mac: fix struct ieee80211_sband_iftype_data handling From: Johannes Berg To: Kalle Valo , ath11k@lists.infradead.org Cc: linux-wireless@vger.kernel.org Date: Tue, 26 Sep 2023 18:43:56 +0200 In-Reply-To: <20230926163350.2641064-1-kvalo@kernel.org> References: <20230926163350.2641064-1-kvalo@kernel.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) MIME-Version: 1.0 X-malware-bazaar: not-scanned X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Tue, 26 Sep 2023 09:44:09 -0700 (PDT) On Tue, 2023-09-26 at 19:33 +0300, Kalle Valo wrote: >=20 > - he_mcs_map =3D le16_to_cpu(ath11k_mac_get_tx_mcs_map(&sband->iftype_dat= a->he_cap)); > + he_cap =3D ieee80211_get_he_iftype_cap_vif(sband, arvif->vif); > + he_mcs_map =3D le16_to_cpu(ath11k_mac_get_tx_mcs_map(he_cap)); Technically, ieee80211_get_he_iftype_cap_vif() could return NULL if you didn't actually configure/enable HE for this iftype, the static checkers might complain here. johannes