Received: by 2002:a05:7412:2a8c:b0:e2:908c:2ebd with SMTP id u12csp3300361rdh; Thu, 28 Sep 2023 08:01:45 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH9HWvzcbj4S3dcwZCRvMSATnZUVd37tK6OUhyg3+/cLRHpJ0v/5aP3kWffwhro+/+Kgkqp X-Received: by 2002:a17:902:efd6:b0:1c5:e1b7:1c13 with SMTP id ja22-20020a170902efd600b001c5e1b71c13mr1217052plb.3.1695913305302; Thu, 28 Sep 2023 08:01:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695913305; cv=none; d=google.com; s=arc-20160816; b=lzDOkAQfAgiiU4nhePMxvVjTJ1CkwDdlN6RYfKlt5uJfcBGgfJ4/s/Jc7Vgp8PyoKq aycZL3VCPKtEQvHam9/ABXkspBi+IDyqQPsMqC60oPb3FJ7xHaliOLlL8GcagEgm//tS 6yMPwaA9x27gV7AfwwCpVck7NjZXc5CopUY2bKIoL/TMt/XgKPzrBmiXt1IQ/C0iZbDn pq+rRk2tPi3WEXqeP7+qjSaZAL1duwcyBRBfpcWq4/gvgTRMUN2kE7CgOE2DAQoBRJ8m 18uI5xJVupkYbx6sTYjfDyxWupHyDmH3JX5IY5S990Fehoe+xPvnKJJkYwJ4Q6VvJHIL mHSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dkim-signature; bh=ySCb6VEXOC4NLiYFTXTDQBsWqqZbxlgAW5bRV5TNivE=; fh=pFUMRLcs2CxJLfynOFPNNsxKPxj2wYRvMQW6PkoiSbA=; b=rfKYXIO1QLl3gVKRXxgai2uGJDmhGhv3eYlPdFnfQlXfl2P9zpuUIZiXA2WNuUX+Tc iOAn8zHmNFKbOxUudXud9+UN+rTb82Z9Sm9osFTXazKygyKqYNATZ1pl85fhPHKPsuLQ lpq7cCqL7auD+1S/L2JZX1n1Z2+0t4qv+YdEcnbxtI2wlOPXeVKJ8xUPg9Sy9jqYWeab CcOmnh1ZqoOMSL9O9eqEeOjKlf/CvKERFof9/gICbFcgosFWGRSLZH9tCulFabqYhjvj GyRtQDdh9wHmG+UT6DLb0DmJZBH55dHiPH0GikjdxYb+qHCEg6xLiWXCn5JjmftwZ3To Ixrw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ePHKEK7k; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id ot18-20020a17090b3b5200b00276571c0d34si15740388pjb.6.2023.09.28.08.01.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Sep 2023 08:01:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ePHKEK7k; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id EDC1080ECAEA; Thu, 28 Sep 2023 08:01:31 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231384AbjI1PB0 (ORCPT + 54 others); Thu, 28 Sep 2023 11:01:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35540 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231262AbjI1PBY (ORCPT ); Thu, 28 Sep 2023 11:01:24 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 49B70194 for ; Thu, 28 Sep 2023 08:01:21 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F2CF6C433C8; Thu, 28 Sep 2023 15:01:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695913280; bh=Sv4ZYwTJOdt8iL9WrmtNcE/NncscTaorBT+D7H4XgLk=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=ePHKEK7kdeARJnGXIHDaatuXWLffil8m9TDDOfhKeuFmylbKUDrqWvSxsT0PkdCtI JdmfiCoYEPO0dhVDJi19IyjFzifjOSg9BStv/gfyhWpHDW7JWWsaUPGdFcYF7mZh7W NzxLERpHbGU7XCO72xwAIIX7UPcDWIlf5ConemRsch7k8OQ0QW90IkQp1XM8vC4iUV JZLMbnMm5p+zgMKBUuY+OYA6w2BJoHk3zzITfgLoo1AuK/HxNA1AVEvdADrZCQvDWL XwjPgGL5EqB1qQu+78IGQ1bk0YQskETFvLFu3lFoQ4IrQf8orVJ+Y2qixQjUBi+1kh IzRjuGxOEeDqg== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] wifi: ath12k: fix recovery fail while firmware crash when doing channel switch From: Kalle Valo In-Reply-To: <20230905105229.10090-1-quic_wgong@quicinc.com> References: <20230905105229.10090-1-quic_wgong@quicinc.com> To: Wen Gong Cc: , , User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.11.2 Message-ID: <169591327779.3019228.18229314827081753794.kvalo@kernel.org> Date: Thu, 28 Sep 2023 15:01:19 +0000 (UTC) X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Thu, 28 Sep 2023 08:01:32 -0700 (PDT) Wen Gong wrote: > When firmware crashed while channel switch running, recovery starts in > ath12k. Then ieee80211_sta_connection_lost() will be called by function > ieee80211_restart_work() in mac80211. And then many WMI command timeout > because firmware is crashed. Each WMI command cost 3 seconds, then the > total time will be large and leads recovery fail. > > Hence change to set value ATH12K_FLAG_CRASH_FLUSH early and then > ath12k_wmi_cmd_send() will not wait 3 seconds, then recovery will be > started quickly and success. > > Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0-03427-QCAHMTSWPL_V1.0_V2.0_SILICONZ-1.15378.4 > > Signed-off-by: Wen Gong > Acked-by: Jeff Johnson > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. ecbb987b0a96 wifi: ath12k: fix recovery fail while firmware crash when doing channel switch -- https://patchwork.kernel.org/project/linux-wireless/patch/20230905105229.10090-1-quic_wgong@quicinc.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches