Received: by 2002:a05:7412:2a8c:b0:e2:908c:2ebd with SMTP id u12csp3314697rdh; Thu, 28 Sep 2023 08:19:10 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHoESYQMxm+aSitPNIWG99ciLz/e7IMa5R2bOaGJ8nd+eb5/iRKV+JRy7FgovROMsWsZOGQ X-Received: by 2002:a05:6a20:9687:b0:15a:836:7239 with SMTP id hp7-20020a056a20968700b0015a08367239mr1217389pzc.11.1695914349960; Thu, 28 Sep 2023 08:19:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695914349; cv=none; d=google.com; s=arc-20160816; b=E/nl4jZwTl+zHVAwXXfHVWpQrE3HrFKsMvnIsrD5sOkoseL30HY0mtji5cGDGcYAvz EqcVOhz/PTJEV2MqKOAU3PEA4yrHYQF86lN0mDfMjzX0cISYnqjIdIU+UaFS/3rygjOn Ik5REk1wEW5ugUBPnuK4pko9IIszCe8cMh7IsnEhZHXB7WhO8EcfZOckz3sfQiiRmvKa GsHwhfrqfGUbCgx4nNur8nIXED2fuhR+6yxVkic0Dq5Wa8xQr0oV6n50Ln7XkHlQXnpq mHrCsApFpzO5Jqe8TsHdf+keRWmfVqF9qjQxutuEIi6acCFQ7xrC8Y/JxRjYwwiNYrlm sBJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dkim-signature; bh=MCC/BHQJrbrPFZFDe6VTKMy4YRNi2NSCO+PMJ3ALBM0=; fh=2jH5kaCCk1fklNHXaydhvOqX+LXNFKjxhc5NUzzpGmE=; b=uPpKNMkSfp6bEAX+MaXJMNSLde2lE/6wlr2VhmEjNFJhYPtyLR7yZ0uQBKKDwkKdS4 eFEkA1Y50ALjNzhWxZeOUb+bsEpOBL7YjevorNyNBNqSQkAdE486Pi9tDZkJPFeMGMYk LLJJgb7nmyvcqOHSUJDysX5bT7Fm9SWVB398ivvvvhptcFVVpRAe/qdzdnKx4+++c/rg KKrfTAWkxGhC3Dl232eODkf3nkWii/PFlcVSTvx5n+cSwH7DPLWWdCq44rUq7cl5jT2K w61nL7jeQD0hj3X6GrI/+jXuC0JasCz31hQdtP3IQkQDcKUE0HoZiF9FwUF1TqkjunXI UWwA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ni2G6718; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from morse.vger.email (morse.vger.email. [2620:137:e000::3:1]) by mx.google.com with ESMTPS id n7-20020a170902d2c700b001c6249a387esi10911920plc.531.2023.09.28.08.19.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Sep 2023 08:19:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ni2G6718; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 2402C8077911; Thu, 28 Sep 2023 08:15:24 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231444AbjI1PPS (ORCPT + 54 others); Thu, 28 Sep 2023 11:15:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52684 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231206AbjI1PPR (ORCPT ); Thu, 28 Sep 2023 11:15:17 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 51E1A19E for ; Thu, 28 Sep 2023 08:15:14 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AD954C433C7; Thu, 28 Sep 2023 15:15:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695914113; bh=kAJs4PHDj7FghUS9FI5ZgzxtTJ3kn3Onea5WYgB1/dY=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=ni2G6718aymVVuc6bnNUv6im/Be4Y0xPBDHOROtbwS/TIkwOxiPhSyaEZ7mlmylgB 1dyeN/tzAAlIVKSD/RiJ249JLKLh3wgj9GUEBlT8zPJRMMDjxzRFlBDNX3z6XsUmaV h7qRxInzCQKdXfwEp/EoQfLjgqP7fg9eaUV801Ix8sM1wkMaOEcjYU0SGq4cpXEfl8 pEpb1s+wIFVKEkadQCZrxpNzGY7y+EEXSFyLYodmlXgnZAu40SQ2wNfeUJ/k35CqEp DPe2YRKGNtQEqYzjHItNuKLKibsek+GqGwYEaP/Y4lOCvCdFKeqVUzcYz15PjldNaG GJkg8/BQx6cpQ== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] [v2] wifi: ath11k: fix ath11k_mac_op_remain_on_channel() stack usage From: Kalle Valo In-Reply-To: <20230926042906.13725-1-dmantipov@yandex.ru> References: <20230926042906.13725-1-dmantipov@yandex.ru> To: Dmitry Antipov Cc: Jeff Johnson , Tom Rix , linux-wireless@vger.kernel.org, Dmitry Antipov User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.11.2 Message-ID: <169591411089.3019228.2557633056821001389.kvalo@kernel.org> Date: Thu, 28 Sep 2023 15:15:12 +0000 (UTC) X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Thu, 28 Sep 2023 08:15:24 -0700 (PDT) Dmitry Antipov wrote: > When compiling with clang 16.0.6, I've noticed the following: > > drivers/net/wireless/ath/ath11k/mac.c:8903:12: warning: stack frame > size (1032) exceeds limit (1024) in 'ath11k_mac_op_remain_on_channel' > [-Wframe-larger-than] > static int ath11k_mac_op_remain_on_channel(struct ieee80211_hw *hw, > ^ > 68/1032 (6.59%) spills, 964/1032 (93.41%) variables > > So switch to kzalloc()'ed instance of 'struct scan_req_params' like > it's done in 'ath11k_mac_op_hw_scan()'. Compile tested only. > > Signed-off-by: Dmitry Antipov > Acked-by: Jeff Johnson > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 4fd15bb705d3 wifi: ath11k: fix ath11k_mac_op_remain_on_channel() stack usage -- https://patchwork.kernel.org/project/linux-wireless/patch/20230926042906.13725-1-dmantipov@yandex.ru/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches