Received: by 2002:a05:7412:2a8c:b0:e2:908c:2ebd with SMTP id u12csp3370179rdh; Thu, 28 Sep 2023 09:37:39 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF5PBjANipxhZqEAr0yEEbRkN45exY7ebMfpVoChuOaGBZtcfbuW7CD1SGkooqW8H3jLrTs X-Received: by 2002:a05:6a21:3e07:b0:15f:16f5:8595 with SMTP id bk7-20020a056a213e0700b0015f16f58595mr1463897pzc.52.1695919059267; Thu, 28 Sep 2023 09:37:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695919059; cv=none; d=google.com; s=arc-20160816; b=lTuD0G6aOvudf974sm30y6ArceWun3/s0cyOTvS5MoShoHV6YxyZNZFNpm+b9El3+q kMhT9w4HAbX0o0ADfWguBM6vOcYYhTXRbYuIajIUG0E5nq3rbLKZZ9ZyIYNr33WDsmtG 0VoVmELzUt/J0JprYt81LgZfTulf+5COFToDoniKEmv6y02cvefSbJcVWKYIQ8BKR15V kMEvkgmbhOayv0oUIMSY2V2N3xoKVRwvwC6N2n32ZButTzs4bgJXVjSBB8fHOTEjOmDC PsE4txJdIng4zxJe3kKHOAEAP6kqk8ZAS+YCXgBXkiUTtMVl5nAgkv1MXO4Btfb4mCHP dihQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=7HSO6QTDfCCbHI6bgb/kbDlJjJKfrnaH3hOHiHO0L+4=; fh=/GEb7gVUqTR6q5QKTfw0XUP5VVlqVBkkw8R/kfrGqdo=; b=zNCZG1u686u0r57lT3GGeTv3IC5ek113LpRIJNl4FCX1VG65pr/NplRj+4bYSc4P8Z IAu/zKfkjeg8VlmOasGFohkBxyZeVAeokrFxvqg1vi7wQ+oLEO8+3PyuCU5AOcBkzj+j OUW7v3uANJboll9RkZLkSBj2ACFTjPd6iyYx+pd0705bWto44+ILqSKv5zY6CCaCPUGd dqS/UxmIaSU648LufCoUzObdC4nkUTCGOJtoGyxyItwoDdfy0uc72iuqhLbLrwPs8N+x Z5dPnsrtuzLvGYMFNqaIwgo9Re5hpR8FTni6bKn4eIC68d3y/VBzk7wKZZpZv2kDdZ6r Dqmw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=NTB6B1Lm; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id u3-20020a170902e80300b001c72476ca30si6097793plg.281.2023.09.28.09.37.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Sep 2023 09:37:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=NTB6B1Lm; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 5BD998319234; Thu, 28 Sep 2023 07:36:26 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231262AbjI1OgW (ORCPT + 55 others); Thu, 28 Sep 2023 10:36:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49866 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231376AbjI1OgU (ORCPT ); Thu, 28 Sep 2023 10:36:20 -0400 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 195CF1B5 for ; Thu, 28 Sep 2023 07:36:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1695911778; x=1727447778; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=r/Wm2fcf7fkqOtMbcDefTZF7auoktizwsoIsZ1gy1fc=; b=NTB6B1Lm1iYnlFvql+xSSrxbThRY8YH5yKC//3LLtOy/eFv9ut+bIh/F 5wHcZKbP6x9yMpvTqpXj35h/Iucyfjx/B3sk3nkU5uodJS0dBczHLApKn zFiHrzCSE98KSboEKY6Y9EHuG+2yHlER6h+qskgLSXNWwsfFmwiWUaYu1 tSiBXfzcfIlsrvoujDdhz5wJ87niL7qREvFgyxgEk40ZOg45oZ4VMUI79 LlymqgX50F4hegqjy0NWAQGN+v5R0Ewkky0wmCrlVRwyez7zgmdmyEfBG onXp7GgGuE9t1P0TlV7LzTLpaYN1n2fPOzoXHho7XF2sStpmpo6zemYco w==; X-IronPort-AV: E=McAfee;i="6600,9927,10847"; a="688461" X-IronPort-AV: E=Sophos;i="6.03,184,1694761200"; d="scan'208";a="688461" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Sep 2023 07:36:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10847"; a="996590458" X-IronPort-AV: E=Sophos;i="6.03,184,1694761200"; d="scan'208";a="996590458" Received: from smoriles-mobl1.ger.corp.intel.com (HELO ggreenma-mobl2.intel.com) ([10.249.92.89]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Sep 2023 07:36:15 -0700 From: gregory.greenman@intel.com To: johannes@sipsolutions.net Cc: linux-wireless@vger.kernel.org, Ilan Peer , Gregory Greenman Subject: [PATCH 10/18] wifi: mac80211: Fix setting vif links Date: Thu, 28 Sep 2023 17:35:31 +0300 Message-Id: <20230928172905.0357b6306587.I7dbfec347949b629fea680d246a650d6207ff217@changeid> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20230928143539.1037500-1-gregory.greenman@intel.com> References: <20230928143539.1037500-1-gregory.greenman@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 28 Sep 2023 07:36:26 -0700 (PDT) From: Ilan Peer When setting the interface links, ignore the change iff both the valid links and the dormant links did not change. This is needed to support cases where the valid links didn't change but the dormant links did. Fixes: 6d543b34dbcf ("wifi: mac80211: Support disabled links during association") Signed-off-by: Ilan Peer Signed-off-by: Gregory Greenman --- net/mac80211/link.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/mac80211/link.c b/net/mac80211/link.c index 76c61a132569..bf7bd880d062 100644 --- a/net/mac80211/link.c +++ b/net/mac80211/link.c @@ -195,7 +195,7 @@ static int ieee80211_vif_update_links(struct ieee80211_sub_if_data *sdata, memset(to_free, 0, sizeof(links)); - if (old_links == new_links) + if (old_links == new_links && dormant_links == sdata->vif.dormant_links) return 0; /* if there were no old links, need to clear the pointers to deflink */ -- 2.38.1