Received: by 2002:a05:7412:2a8c:b0:e2:908c:2ebd with SMTP id u12csp3370332rdh; Thu, 28 Sep 2023 09:37:56 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF2lF23ML+E/IZCKCOSM20zqkPmP3/nbZQ5tgKwHobnNKPs0B9uXwMfq2Yj3ckMypCajv/B X-Received: by 2002:a05:6a21:3388:b0:14c:3218:c1bd with SMTP id yy8-20020a056a21338800b0014c3218c1bdmr2094995pzb.11.1695919075693; Thu, 28 Sep 2023 09:37:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695919075; cv=none; d=google.com; s=arc-20160816; b=GH6Bk/wP+m3jnAQKLAFe4UsYnE+rKLLkkjJP3tOaUzbezNo5VJnG21nlbgN2TZM3jA DQChicjcizuPMnQrq2pS0kbWen4MEi/E2YmUOBE2rRLfCCRHhrCrux8nDKK17R1+Cmjx fLb9HoPdMuALURdTJN5jpAx+gUKnuIE0PffWOjDOsOcIXcibjcqrcwPO+mbF3AShgA14 z+LMoiaFoYJ4u26sVXl47XBRSmHsWEoFo+hqJmGvsK33QMzpSil1Vb8Nun2kBc6boWVF mhbvvGqXtpFeZgibPtk6GJVDujLX5LmUfvoqRXNzeJwh/RLYKVXVieCVIrq6zyeLVsZ8 rjCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dkim-signature; bh=frI5+nzfc1Gn/XTte48itOS3XOpb54dLAfHop7Y+P3w=; fh=FAy2F1K3/spg1mVQFnqr40xE0jFFODVaILxncligcQs=; b=YdMMHwWwGP/6wVWYlZfN+GjzQQ8GjzF4SbOqeQAywEpKNVjcdDXTG0l6VPAsFymot5 lSqfY+RSrn0LIfRYCxRsm4dUaQW+A4rrLMAmKwpCNzppFeMTGhiCmDSr2AVzC5pCRUEC j/9oUpKz9w0j3LOKQit4Y3rGurVEbvU09BxqIigPEK6EgyvAsIFmGc/2m1PHu7Wv8/IJ UIAFNICdJQ7RQCWvHFpSxnnT0U1TZA1EGCQ2Oq4mSOx9fcjlykWa8PglczPtG0jNN7FS plHzowsNLEXJY2aXeaT2wsUGykW63FSKtbyG+okXn2+6Uapb2LwRYj14OjK1vXN1ZMYW psrA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=BKcDfpYN; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id w20-20020a056a0014d400b0069342eade87si4258011pfu.18.2023.09.28.09.37.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Sep 2023 09:37:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=BKcDfpYN; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id BF7A9810450E; Thu, 28 Sep 2023 09:24:48 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230331AbjI1QYr (ORCPT + 54 others); Thu, 28 Sep 2023 12:24:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52128 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230212AbjI1QYr (ORCPT ); Thu, 28 Sep 2023 12:24:47 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7423C139; Thu, 28 Sep 2023 09:24:44 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9C3BFC433C8; Thu, 28 Sep 2023 16:24:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695918284; bh=Yb73gD0w71DZLWWTyXpDtkeRLLlRucCxREX/JemEB8I=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=BKcDfpYNChVFNEtxTBXfELZtQVEthED8lpdnWdWEE8cBEI6x+7gCWHud+T+Eo/LYp r8jb7nxiqf72drCkZcRMc+smSTLeZWKFxSo33taiUk1zs8/iEoX8/v/vlRU0ZoTRTp a4OUdYOFT571q3z2kbTzYbvvZQEOladuJPAUtBN3LGoppTmdIoiFZwhcBmuBBmchTe wShV/JzqhD8WbzG/cB3dx8pIZ1FSNsvWuTIj0x2Ym7f/MRv/7hZg1Et4n+kmrg5Pux b0id+Rj65bBH+m0J5KEd6954DqcXwNp8WHu9oNNgJQ61bzClV2m87UpS5mQozSEPu9 11MInDvR5q1dQ== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH][next] wifi: rt2x00: remove redundant check if u8 array element is less than zero From: Kalle Valo In-Reply-To: <20230920121240.120455-1-colin.i.king@gmail.com> References: <20230920121240.120455-1-colin.i.king@gmail.com> To: Colin Ian King Cc: Stanislaw Gruszka , Helmut Schaa , linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.11.2 Message-ID: <169591828085.3187104.685774865780206664.kvalo@kernel.org> Date: Thu, 28 Sep 2023 16:24:42 +0000 (UTC) X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 28 Sep 2023 09:24:48 -0700 (PDT) Colin Ian King wrote: > The check on vga_gain[ch_idx] being less than zero is always false since > vga_gain is a u8 array. Clean up the code by removing the check and the > following assignment. Cleans up clang scan build warning: > > drivers/net/wireless/ralink/rt2x00/rt2800lib.c:9704:26: warning: > result of comparison of unsigned expression < 0 is always > false [-Wtautological-unsigned-zero-compare] > > Signed-off-by: Colin Ian King Patch applied to wireless-next.git, thanks. b2172a9330b5 wifi: rt2x00: remove redundant check if u8 array element is less than zero -- https://patchwork.kernel.org/project/linux-wireless/patch/20230920121240.120455-1-colin.i.king@gmail.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches