Received: by 2002:a05:7412:2a8c:b0:e2:908c:2ebd with SMTP id u12csp3373075rdh; Thu, 28 Sep 2023 09:42:40 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFFd9CpersbGy2O5FGNkpDF3QSL0jL3iVb+qZRvgPOngzsU5d8UdUQLnxJiZsysZ6zJwUyh X-Received: by 2002:a05:6358:8a2:b0:143:9763:e6 with SMTP id m34-20020a05635808a200b00143976300e6mr1749258rwj.0.1695919360646; Thu, 28 Sep 2023 09:42:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695919360; cv=none; d=google.com; s=arc-20160816; b=e0pj+41AocnVBbqqsR4O7aJP/RSYcWgtYt3AejHFpcpjHm3nls25CI0LwIxB72QOfk +cK50/KuI5UoCf1n5tkIwBnmyTxuQaYnC0GMrFuCUqiPJbjo9jGrDrvoZqBTmjtuAiLj q7iv3iRqGVZ+f16adoovJv8TBVl/JFAJ8kZelJKwh70ofbmEtsmVuY6w7jUL4ZHKvR+F NfYpS7F0VWV4TxpXzcJUsPNWisCi2j7Qasj4xXQLPFNiXl8DZkTOXpE+wb4hwm/xQRny 8P5iLK6YQR91wkZenLABecoNCdvKtTg1B8NvJCa297M09eTZYSFb0JDd7a6RDNGGWX9M YqYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dkim-signature; bh=MKlvQ+n8p4q6Mor8ilcIjoMqOqS+jqHvQ2HPrJrBqhk=; fh=jsIpssjyT8bfCaNlWYR6++6VOlBc635mV05LlUs8SzQ=; b=SCEY9lvvzMubDR/u9EGJZEigTAt8PxZLGbWZcpCyVt04VWbel78d9xWI1iBI7O8KKZ 32JdNKXoOlqt2cwKW8XcSAh0dumeF8B+t35nzb3fqhVNZ9aBdLIZnlry4iAW4R7HnuDp QswvKJPYRRTbkuxS9zqtDOf1/NMLDdKKBd5lah2TU63L0DMrdoCgtduwgptMh3krJUiK tTcf7R05K8Q7WzUA/sVUV/BxsanV82JUru19vMCo35FQwCXZ+MFEgzi0NZVb4MNg7KoM fTeq3tLQN6V3QUH2Unniro1AXoNYBSApcYlBWo0i8jFZlxy6AqU+UFH+KuFdi8xOWLBz fbEA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ZmuDRBff; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [2620:137:e000::3:3]) by mx.google.com with ESMTPS id k64-20020a638443000000b00573fc1f288csi18847457pgd.569.2023.09.28.09.42.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Sep 2023 09:42:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ZmuDRBff; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 91B0880CBF24; Thu, 28 Sep 2023 09:25:52 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231263AbjI1QZv (ORCPT + 54 others); Thu, 28 Sep 2023 12:25:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35132 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231392AbjI1QZs (ORCPT ); Thu, 28 Sep 2023 12:25:48 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 434E1EB for ; Thu, 28 Sep 2023 09:25:46 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C053FC433C8; Thu, 28 Sep 2023 16:25:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695918345; bh=i/EPi8i8KnOn6iK+Rx0MHVFSN8pIvaaYv1KRyWqxEaY=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=ZmuDRBffDDRcpZXFJ9kVa5saeyRATz3bQunFcp7o5Sgr+9xM6iZfbXBkh73a6yLdN ezLOkVGkft7Pe3f7jzkGTprZ4p7gR696h5Erx2CGkqZHTD88g6LOhmZ5NYGdlUSLxE MDEd4GVEG0X0rbQxDgedCqMQD5Z9tsuT0N3Exgfbz18kfP2r57fycZ0rOHtTQ9pTCo OtlAyq3sAXwHRmCHMxNKfjKd9R9k6t46AyJlrSp/2rmtyfUfW7sx61rSqRIxwuyiLm FAlNdroJJY2vy7bcxtVVSoStr2vTfyqANqvC04djSB+RqTE0q0xTcFtViz3BkJfDtB Cuyo598xabmLg== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] wifi: rtlwifi: cleanup few rtlxxxx_set_hw_reg() routines From: Kalle Valo In-Reply-To: <20230925090452.25633-1-dmantipov@yandex.ru> References: <20230925090452.25633-1-dmantipov@yandex.ru> To: Dmitry Antipov Cc: Ping-Ke Shih , linux-wireless@vger.kernel.org, lvc-project@linuxtesting.org, Dmitry Antipov User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.11.2 Message-ID: <169591834305.3187104.8658235364226283925.kvalo@kernel.org> Date: Thu, 28 Sep 2023 16:25:44 +0000 (UTC) X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Thu, 28 Sep 2023 09:25:52 -0700 (PDT) Dmitry Antipov wrote: > Since 'u8' comparison against zero is always false, drop the > corresponding branches of AMPDU_MIN_SPACE adjustment within > 'rtlxxxx_set_hw_reg()' for rtl8188ee, rtl8192ce, rtl8192de, > rtl8723ae, rtl8723be, and rtl8821ae. Compile tested only. > > Found by Linux Verification Center (linuxtesting.org) with SVACE. > > Signed-off-by: Dmitry Antipov > Acked-by: Ping-Ke Shih Patch applied to wireless-next.git, thanks. 6016f0cb02f4 wifi: rtlwifi: cleanup few rtlxxxx_set_hw_reg() routines -- https://patchwork.kernel.org/project/linux-wireless/patch/20230925090452.25633-1-dmantipov@yandex.ru/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches