Received: by 2002:a05:7412:2a8c:b0:e2:908c:2ebd with SMTP id u12csp3971044rdh; Fri, 29 Sep 2023 07:40:28 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHj9buUYct0xMthlz/xnGAWcPvBY0U1K0rtCLMEpmjvB3wJDVxXF1ixdKenHteTZQkR6yzv X-Received: by 2002:a05:6a20:9381:b0:14d:9938:735f with SMTP id x1-20020a056a20938100b0014d9938735fmr5039573pzh.17.1695998428083; Fri, 29 Sep 2023 07:40:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695998428; cv=none; d=google.com; s=arc-20160816; b=LJxmPo461/XuZIBxh32U3rZrVnbo6+T5u5efob4HbaN372Lk4mbQADM1tkDGRgueKb YHJDvb2I8+XEnQO/CS0zwDxcbC33+yJEF8zNwda7q1daoKET4qqaqde6S3P0jrSqrODO XQrj9m/j0g/RyphtNxJTgZDfVva410XQl1xAwjyuWN6TcJfSwexT4FLJdp+q8W02h5TJ M2z3UwSFsSuE1La3BjGZqFKEY0SxH5C/vLyw8Yaw+IdtTid+CN86BwQJFqoqa+QImkwX V53dHMYQqyOnyjoPwf2vML2ZDkabKXMuKwGLuLjFJ3uj7G0u+UesNZgNewECzGLPE+LN vNmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:message-id:in-reply-to :date:references:subject:cc:to:from:dkim-signature; bh=6+Kz2B9rZJtp2lXeyKuAGwnudTYwfbfr49kVQXFtZvE=; fh=UanOD8uSqtj7lv3Ii1MValkGHtqdXz9Igx6xxxNIKOY=; b=eblMVRhZiaxL5ZE8Nppy4hmgtBdg37eAFztjw2MQs4+Wzu33IB+K4rkVZWUv84V87p Hqzfy+/EOm08eGkbu+prr8pLZBvaTOhQPIOZ7Jw3fMMNDnJ+h/nAO34aOj2UJkazwMSb HFNcyp16FfnvGdaOayjiq9mQemDZSgyVgOWVRllrsDqfkSpV/haz0kODwNiWa0XKb7+B IK8uOwNwriVUvP2fRrqySy9o9+cGQYJTzkM6Oaocjtf23dZiXz7zMc4UuZjRckEsDhgs Ga1EQw8jCiT8a7WvbuuTJJ/uB2jHqwrSdjqO+B+zQp7hERpXCZ22hLXw1cxIxEFM8OeZ cS+w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=mjt+hJKe; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from pete.vger.email (pete.vger.email. [23.128.96.36]) by mx.google.com with ESMTPS id f10-20020a056a0022ca00b00693462e2553si6081247pfj.156.2023.09.29.07.40.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Sep 2023 07:40:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=mjt+hJKe; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 141C8836075A; Fri, 29 Sep 2023 07:35:05 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233756AbjI2Oel (ORCPT + 54 others); Fri, 29 Sep 2023 10:34:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58992 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233660AbjI2Oe3 (ORCPT ); Fri, 29 Sep 2023 10:34:29 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1011D2726 for ; Fri, 29 Sep 2023 07:33:24 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B9129C433C7; Fri, 29 Sep 2023 14:33:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695998004; bh=gJM000iU/qxw+nMqCXY3TCqRWK5JPoW6L+5coAokIkE=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=mjt+hJKebUnCYT8C9jf5xidUCWbhhbyVfmJyv3qV1jc7SxOMf/s0LoumF3EtUdcH1 FiyZnw5yYZ7REX2f2q8hbbPIoukRhoG2hBIBoSNMbVrD1jOMO0IBGeeVssNLJRt5R+ se/fDcx+G7U88lnkLkhrlfwuigVAFi09wPW1XhfFZP9uEsWzNVSicZKJ1t9fokknXg hKi/wlQ+Hn/L8jtxWiemO2lZbZolI3lAgc++6L+fSHBBNWLbao7+k5Jzl5RnVss2d5 bjfReClrECYExzVI2rVvqgBS1hpUBCne3Gs1ynAzk0Zp4DepyP497LKS+5VpjOtQH8 ZY6VFBT93j6fw== From: Kalle Valo To: Johannes Berg Cc: linux-wireless@vger.kernel.org, Johannes Berg Subject: Re: [PATCH] wifi: mac80211: fix ieee80211_drop_unencrypted_mgmt return type/value References: <20230929162059.205c236c9f3f.I9ed4c65ab6514aa9e3c8877ec79092a302b2089d@changeid> Date: Fri, 29 Sep 2023 17:33:21 +0300 In-Reply-To: <20230929162059.205c236c9f3f.I9ed4c65ab6514aa9e3c8877ec79092a302b2089d@changeid> (Johannes Berg's message of "Fri, 29 Sep 2023 16:21:00 +0200") Message-ID: <87fs2x6ocu.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Fri, 29 Sep 2023 07:35:05 -0700 (PDT) Johannes Berg writes: > From: Johannes Berg > > Somehow, I managed to botch this and pretty much completely break > wifi. My original patch did contain these changes, but I seem to > have lost them before sending to the list. Fix it now. > > Reported-by: Kalle Valo > Fixes: 6c02fab72429 ("wifi: mac80211: split ieee80211_drop_unencrypted_mgmt() return value") > Signed-off-by: Johannes Berg Thank you for fixing this so quickly! Tested-by: Kalle Valo I assume you don't mind if I apply this to wireless-next still today? -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches