Received: by 2002:a05:7412:3784:b0:e2:908c:2ebd with SMTP id jk4csp1460283rdb; Mon, 2 Oct 2023 10:05:37 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFKjAqaJmMKjzBDdHh4h8/Py78/s97DmcfohbBTzoXQ1RK0qGXFA2KiBM6zzW3Cf4AoNFNQ X-Received: by 2002:a17:903:1252:b0:1bd:da96:dc70 with SMTP id u18-20020a170903125200b001bdda96dc70mr15145008plh.49.1696266336828; Mon, 02 Oct 2023 10:05:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696266336; cv=none; d=google.com; s=arc-20160816; b=FVjkGKK/QHXitWp3GndXTjZYmeGOpSCscy8wgt3bUuozx1cc6Vmsasaxl6vCtXp6Ng cvNW2dcnQU3E9nWE8pUpjbVNeZkXjj6TNpRqyupjO8sALAnmiVz2Bd9+nFe8vJq4vsJO WutAXZ9V3msBcGobXRRkf0K8mTc/anVHvsOfi3hGu2MVuflfIVet/9G4bTTBqMJbne+4 QzrTyDTmlwKjvWU2MEj6REqf2WhFvxDNNRUkgw+BYy9XKPcwuz55ILBz1hn9T/HFSGB0 D2lNQ62/9yWEKMlWGEBu5OFZ8/y44ijMt7RaJ9nOyuzm/MGvP3x1mjkfzB2Ffqy96e2G VmDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dkim-signature; bh=qrvRXwb0qdjdac6QBEwFBMDPILidv0C033cug81SnqI=; fh=7bB3Kpz8RZMwdMYAugDYGfRZyXLQXfYgJRADtxru19M=; b=lkx6jRregM6L7ZyW2fuUUTJJZWrkEeR32Pv1nTp4GAglLMOFlE8lQJ1tSw5fvF0msE nzV5RwyTTHO2IWWx02PlRfotPim/NWX3Vic6JvInEKYsaQjsM7D+TAX9SPvmE0+bM5NX L3TXPwsXwhhz+jc02kIdI/iARwl7NnhdKaq2fW2/Q3V0EWfT5vJKcMa41kpsflMvzrPN 989hCSF57gyE+P6gXFCmdEKBOIsYx/nQwNSfsZ6elN78Q8wHOSI+cgXHIdQrLHTHK0k3 HQzaK2WsN0t+mXM7/N/whh9k1EaWBYWKw9xNL8pSjaiDBe4fSIoKWpQtvf17c2Lulm2c UCVA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=gxDJzpMe; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from groat.vger.email (groat.vger.email. [2620:137:e000::3:5]) by mx.google.com with ESMTPS id d8-20020a170903230800b001b7f4696a2csi29854078plh.347.2023.10.02.10.05.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Oct 2023 10:05:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=gxDJzpMe; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id A03B880D6A17; Mon, 2 Oct 2023 09:58:53 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238549AbjJBQ6v (ORCPT + 53 others); Mon, 2 Oct 2023 12:58:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50752 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238397AbjJBQ6u (ORCPT ); Mon, 2 Oct 2023 12:58:50 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B5C35BD; Mon, 2 Oct 2023 09:58:47 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 95D89C433C9; Mon, 2 Oct 2023 16:58:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1696265926; bh=Z54mipjqUI9KFG6Xrua2pg2Iij4JSR9fBBR7ccXfGPY=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=gxDJzpMedBCagEC9jPJnMQ0wgxrDXzM2ERf6nX49QjacHwjCCdjhPVTq4gBg6JyGn BcIMCAyCkydCbOLTzLkU0pZ3SYJKufKFK40LMh9d0nBNINPmiKwRAPpF4s8X8TsxSf O4ozlSRUyQj7z+WvmubDS+ayY5P6J8vUgdiSAucqeJfJudNtTfkkXTOjNrqdsil5Wa TS7Yx0uN2+E/sXxped4oX6pAuuA4Ec+3ncarq7JKgf8FJ7c70bQ7qWv6o0atVskXGU a7+emtmxGHYDwxJpyZz962ePwzk3oM2f+37OavAkr3IeLIpJtEY4JS+29Qx0ngov61 uQIGEXQuAeBlg== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH wireless 1/2] ath: dfs_pattern_detector: Fix a memory initialization issue From: Kalle Valo In-Reply-To: References: To: Christophe JAILLET Cc: Christophe JAILLET , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Kalle Valo , linux-wireless@vger.kernel.org User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.11.2 Message-ID: <169626592372.3936351.4590251912605769395.kvalo@kernel.org> Date: Mon, 2 Oct 2023 16:58:45 +0000 (UTC) X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Mon, 02 Oct 2023 09:58:53 -0700 (PDT) Christophe JAILLET wrote: > If an error occurs and channel_detector_exit() is called, it relies on > entries of the 'detectors' array to be NULL. > Otherwise, it may access to un-initialized memory. > > Fix it and initialize the memory, as what was done before the commit in > Fixes. > > Fixes: a063b650ce5d ("ath: dfs_pattern_detector: Avoid open coded arithmetic in memory allocation") > Signed-off-by: Christophe JAILLET > Reviewed-by: Jeff Johnson > Signed-off-by: Kalle Valo 2 patches applied to ath-next branch of ath.git, thanks. 79bd60ee87e1 wifi: ath: dfs_pattern_detector: Fix a memory initialization issue 27e154abf694 wifi: ath: dfs_pattern_detector: Use flex array to simplify code -- https://patchwork.kernel.org/project/linux-wireless/patch/ad8c55b97ee4b330cb053ce2c448123c309cc91c.1695538105.git.christophe.jaillet@wanadoo.fr/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches