Received: by 2002:a05:7412:3784:b0:e2:908c:2ebd with SMTP id jk4csp1654917rdb; Mon, 2 Oct 2023 17:27:15 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHiFYhBelkwiI2tS1lNlALGYHvNi433bS4vl6gUv4UfZQShHEdZDC10G4PImNpSnlHKMbKB X-Received: by 2002:a05:6a00:a02:b0:68c:44ed:fb6 with SMTP id p2-20020a056a000a0200b0068c44ed0fb6mr1854577pfh.16.1696292834952; Mon, 02 Oct 2023 17:27:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696292834; cv=none; d=google.com; s=arc-20160816; b=U8W/fe53YrnHUddRhNxWLve789/AMAAm94L1EpbCRJydWXKkfbYRsUbYFbBTbM86yB rNwzLkw9qCUVwNi5PPuqd6op98NcQOuqoNuWAJXFFOs9liGbHiVfsVYK1Aq5iuCJB0SQ 5E4bT4zfNb4e7JFadV8mICzrEmsH/41pJ27TT2fZh/o7Ot1qrpzVqvH5Hki4omqlkNWO oTxXvLMiPoub0rODVut0OIVwcXLGwvI9cTrElBPmvkEoJKPflTzXmJHdsd3d3d9e8fuf dq51gG99QuZDCvHvDTkJlv99uYnl8JzvNgod4WkCyIG1rnc3B/UcUh5QFjFZViX9/SB6 bm+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :content-language:accept-language:in-reply-to:references:message-id :date:thread-index:thread-topic:subject:cc:to:from; bh=HwYjlkjqe+RQkKkAVKF3raX6qgV4qPk8RWyBiqSXRTI=; fh=pZpLv3JBu7ewThcXtBU3x3uGUeTqUHmHtpmV6AvLzGM=; b=gE5s/FsQ3438flAU7uvcoZuEK2UfF7coGgqlHGUkT2+gmcZEgNXJRKi8JYKLwR8JAk dUSvzYj9ReE6KRENo7ByB4bIaSpDZx7f4DGwDeuMNkbsrJ0fUdgytwj+ZK8E31he+otx ttNQ7+qPx8/+pLf6J0VnxdZw4XKOj55U/UEZY+P79TeT/p13ISFen42sSIQ6CobgCj8d o/4FArxwDB/KViIryjv5N1+e/8n5E72+YSm0vSi7PEK1bb1VqfY0RVPSooQiHRmF1KJZ 3OK3qSId3R/DZpYCH+/TvsVtK2yVuTAYVc5t8ziMpQtFZ/7p+73xDcu4LGMkXB5HpD3q kTCQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from howler.vger.email (howler.vger.email. [23.128.96.34]) by mx.google.com with ESMTPS id u191-20020a6385c8000000b00573fd1b31f8si148433pgd.704.2023.10.02.17.27.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Oct 2023 17:27:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 1CE308243BE7; Mon, 2 Oct 2023 17:27:14 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238397AbjJCA1L convert rfc822-to-8bit (ORCPT + 53 others); Mon, 2 Oct 2023 20:27:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39346 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229789AbjJCA1K (ORCPT ); Mon, 2 Oct 2023 20:27:10 -0400 Received: from rtits2.realtek.com.tw (rtits2.realtek.com [211.75.126.72]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0DE3A93 for ; Mon, 2 Oct 2023 17:27:06 -0700 (PDT) X-SpamFilter-By: ArmorX SpamTrap 5.78 with qID 3930QvvN61232036, This message is accepted by code: ctloc85258 Received: from mail.realtek.com (rtexh36505.realtek.com.tw[172.21.6.25]) by rtits2.realtek.com.tw (8.15.2/2.92/5.92) with ESMTPS id 3930QvvN61232036 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 3 Oct 2023 08:26:57 +0800 Received: from RTEXMBS01.realtek.com.tw (172.21.6.94) by RTEXH36505.realtek.com.tw (172.21.6.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.32; Tue, 3 Oct 2023 08:26:58 +0800 Received: from RTEXMBS04.realtek.com.tw (172.21.6.97) by RTEXMBS01.realtek.com.tw (172.21.6.94) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.7; Tue, 3 Oct 2023 08:26:57 +0800 Received: from RTEXMBS04.realtek.com.tw ([fe80::40c2:6c24:2df4:e6c7]) by RTEXMBS04.realtek.com.tw ([fe80::40c2:6c24:2df4:e6c7%5]) with mapi id 15.01.2375.007; Tue, 3 Oct 2023 08:26:57 +0800 From: Ping-Ke Shih To: Dmitry Antipov CC: Kalle Valo , "linux-wireless@vger.kernel.org" Subject: RE: [PATCH] wifi: rtlwifi: use unsigned long for rtl_bssid_entry timestamp Thread-Topic: [PATCH] wifi: rtlwifi: use unsigned long for rtl_bssid_entry timestamp Thread-Index: AQHZ8uwWyOE1al08SkyT8OIXaSWRnLA3Oq5g Date: Tue, 3 Oct 2023 00:26:57 +0000 Message-ID: References: <20230929154524.222498-1-dmantipov@yandex.ru> In-Reply-To: <20230929154524.222498-1-dmantipov@yandex.ru> Accept-Language: en-US, zh-TW Content-Language: zh-TW x-originating-ip: [172.21.69.25] x-kse-serverinfo: RTEXMBS01.realtek.com.tw, 9 x-kse-antispam-interceptor-info: fallback x-kse-antivirus-interceptor-info: fallback Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-KSE-AntiSpam-Interceptor-Info: fallback X-KSE-ServerInfo: RTEXH36505.realtek.com.tw, 9 X-KSE-AntiSpam-Interceptor-Info: fallback X-KSE-Antivirus-Interceptor-Info: fallback X-KSE-AntiSpam-Interceptor-Info: fallback X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Mon, 02 Oct 2023 17:27:14 -0700 (PDT) > -----Original Message----- > From: Dmitry Antipov > Sent: Friday, September 29, 2023 11:45 PM > To: Ping-Ke Shih > Cc: Kalle Valo ; linux-wireless@vger.kernel.org; Dmitry Antipov > Subject: [PATCH] wifi: rtlwifi: use unsigned long for rtl_bssid_entry timestamp > > Since 'age' of 'struct rtl_bssid_entry' is in jiffies, prefer 'unsigned > long' over 'u32' to avoid possible truncation in 'rtl_collect_scan_list()' > and thus weird result in 'rtl_scan_list_expire()'. Compile tested only. > > Signed-off-by: Dmitry Antipov Acked-by: Ping-Ke Shih > --- > drivers/net/wireless/realtek/rtlwifi/wifi.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/realtek/rtlwifi/wifi.h b/drivers/net/wireless/realtek/rtlwifi/wifi.h > index 2e7e04f91279..0f99e3446796 100644 > --- a/drivers/net/wireless/realtek/rtlwifi/wifi.h > +++ b/drivers/net/wireless/realtek/rtlwifi/wifi.h > @@ -2708,7 +2708,7 @@ struct rtl_c2hcmd { > struct rtl_bssid_entry { > struct list_head list; > u8 bssid[ETH_ALEN]; > - u32 age; > + unsigned long age; > }; > > struct rtl_scan_list { > -- > 2.41.0