Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [PATCH] wifi: ath10k: convert msecs to jiffies where needed
From:   Kalle Valo <kvalo@kernel.org>
In-Reply-To: <20230626151636.314868-1-dmantipov@yandex.ru>
References: <20230626151636.314868-1-dmantipov@yandex.ru>
To:     Dmitry Antipov <dmantipov@yandex.ru>
Cc:     linux-wireless@vger.kernel.org,
        Dmitry Antipov <dmantipov@yandex.ru>
User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.11.2
Message-ID: <169634261139.61956.15037887677169461852.kvalo@kernel.org>
Date:   Tue,  3 Oct 2023 14:16:53 +0000 (UTC)
Precedence: bulk

Dmitry Antipov <dmantipov@yandex.ru> wrote:

> Since 'mod_timer()' assumes expire time in jiffies and not milliseconds,
> 'msecs_to_jiffies()' should be used in 'ath10k_pci_rx_post_pipe()' and
> 'ath10k_snoc_rx_post_pipe()'.
> 
> This patch also introduces a minor refactoring and fixes number of loop
> iterations in 'ath10k_pci_rx_post_pipe()' (I assume that the number of
> calls of '__ath10k_pci_rx_post_buf()' should be equal to number of buffers
> returned by '__ath10k_ce_rx_num_free_bufs()' and not plus one).
> 
> Fixes: a6e149a9ff03 ("ath10k: add hif start/stop methods for wcn3990 snoc layer")
> Fixes: 728f95eef523 ("ath10k: rework posting pci rx buffers")
> 
> Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>

This is too intrusive patch to take without any testing.

Patch set to Rejected.

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20230626151636.314868-1-dmantipov@yandex.ru/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches