Received: by 2002:a05:7412:3784:b0:e2:908c:2ebd with SMTP id jk4csp1992984rdb; Tue, 3 Oct 2023 07:19:40 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEf77n0biJdL0MVx/wyYoVIIoOT86a6orD/MdFjQDJqwJtCTUkrzuGepzQOK8pbLP0KRl9W X-Received: by 2002:a17:903:2282:b0:1c3:bc2a:f6b4 with SMTP id b2-20020a170903228200b001c3bc2af6b4mr15177108plh.42.1696342780160; Tue, 03 Oct 2023 07:19:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696342780; cv=none; d=google.com; s=arc-20160816; b=J61jdbDWrY/G82SJpc1PsD3InpxkvAise+FoWw65hgrCea9ZcKq1fTW3v3C7H714+y TzTgdW2CUJIKrUrU5yMGar8qpUkj6OFhzWQlxqSXP5gA2MjiMPYf+X03wIDCx0ks/XGN BOXlhKrbrHqS3YC1cwAYwl8tnyTSdZrA4pjxqC42bRPWq0B5vVsLjMBRBpMlwwCT0/eQ gjhtYF8hXfO44VjM0TsUgsZDLckyyFep86idOiSzC0JlruMgPAdx+WkcBp7w0UCwU0Xk esUVY/xOM2FIGI2G4xA/gu8I57lJBTGBQosbzhA+wUFWN9m54o3RsBpVjZlNI4HkMpLW 5yLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dkim-signature; bh=ZF2qNqG8J1oO3JfbPE/whvgA2Sa6tk3+tFFHe5s9S/U=; fh=29G5WRMHaY6xAeYYwf92bfZtz7lxmiru8Fd8MwpnhH0=; b=p508Dgfe7sQFIhCFC2eebIeaDOO7yo07IfxK38eERLpLCaylhr8rwDdM5dH3DNO050 HLdIIX+6/HXN23ZtF1XaqmbY9bi31Ae76idEv6PC++Y4Nc5/cgzJvdbamaos+b6sipO3 Fu6VHshmfTDEM9/hh4veaL/FokuEjYFdgEGHumr1vbaEOzaqcnLZs+ruoED0Kn6xTO78 Kh/yk9C/BCFL5k1g1eqeYN5Wqf6Ios/Q+8/RWGKYcsFIJSg88l9ircGJ3VeC4wpk3pnJ 98Mwfu0bUWvLm1EC8a9QS2QBJ3ZAl0gyphru1s+SoLYfscnxJh7raHstdNeSrOV9+QCU Y9pQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=lDO1elFe; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from pete.vger.email (pete.vger.email. [2620:137:e000::3:6]) by mx.google.com with ESMTPS id q3-20020a17090311c300b001c7361b71d7si1617804plh.7.2023.10.03.07.19.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Oct 2023 07:19:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=lDO1elFe; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id EE43780BCB9A; Tue, 3 Oct 2023 07:19:35 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238808AbjJCOTg (ORCPT + 53 others); Tue, 3 Oct 2023 10:19:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47100 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239048AbjJCOTg (ORCPT ); Tue, 3 Oct 2023 10:19:36 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 61443BB for ; Tue, 3 Oct 2023 07:19:33 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1EC50C433C7; Tue, 3 Oct 2023 14:19:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1696342773; bh=K3RoKVJclUVf3QIQB6MS24Zqp3gCNfi/X2ais8mZN4s=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=lDO1elFe7pUNBAb/AOog4tNvplshj1FAMSLnmj+ZfsZ+0jlJ7X7eeGE02r4UbDvC7 xhSf5pnWYjwBUCBOuuYvzFtzBRGoKN61P4X3SQ8lgBptCBD/R9kgZELt76xl7uktma d2zMvN4+H0HF18hOdkX84UWIh3v32fk+8es1Htbz2nOCQ6UdaLXL4eZB0lI+gkWoyB 8XeNWo2dW/UZQD4rU2WxnTVp1a7cMU9JE9lUTLASCU1AxjMTmNfdiK65XnBoiqZIwA mCHd39OKe8X3EFSByDYYTZqe2fZdUdinfx3JcDTafGWKOMTEJM5E2arkpNON0PWrqq HdXuUpWhhrnWw== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] wifi: ath10k: fix memory leak in WMI management From: Kalle Valo In-Reply-To: <20230707105243.22824-1-dmantipov@yandex.ru> References: <20230707105243.22824-1-dmantipov@yandex.ru> To: Dmitry Antipov Cc: Rakesh Pillai , linux-wireless@vger.kernel.org, Dmitry Antipov User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.11.2 Message-ID: <169634277042.61956.2280885704658772960.kvalo@kernel.org> Date: Tue, 3 Oct 2023 14:19:31 +0000 (UTC) X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Tue, 03 Oct 2023 07:19:36 -0700 (PDT) Dmitry Antipov wrote: > Since 'mgmt_pending_tx' of 'struct ath10k_wmi' contains pointers > to dynamically allocated 'struct ath10k_mgmt_tx_pkt_addr' objects, > these objects should be explicitly freed when removing from idr > or when the whole idr is destroyed. > > Fixes: dc405152bb64 ("ath10k: handle mgmt tx completion event") > Signed-off-by: Dmitry Antipov > Signed-off-by: Kalle Valo This needs testing on real hardware. Patch set to Changes Requested. -- https://patchwork.kernel.org/project/linux-wireless/patch/20230707105243.22824-1-dmantipov@yandex.ru/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches