Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [PATCH] wifi: ath12k: Encoding regdb.bin in board-2.bin
From:   Kalle Valo <kvalo@kernel.org>
In-Reply-To: <20230131123422.24985-1-quic_karm@quicinc.com>
References: <20230131123422.24985-1-quic_karm@quicinc.com>
To:     Karthik M <quic_karm@quicinc.com>
Cc:     <ath12k@lists.infradead.org>, <linux-wireless@vger.kernel.org>,
        Karthik M <quic_karm@quicinc.com>
User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.11.2
Message-ID: <169634497029.182212.8117239239886289035.kvalo@kernel.org>
Date:   Tue,  3 Oct 2023 14:56:12 +0000 (UTC)
Precedence: bulk

Karthik M <quic_karm@quicinc.com> wrote:

> Currently regulatory database information are in regdb.bin outside
> the board-2.bin.
> 
> In this implementation, Add support to encode the secured regdb.bin
> in board-2.bin along with the bdf files.
> 
> New api(ath12k_core_fetch_regdb) fetches the board specific regdb
> from board-2.bin. If it fails, it downloads the default regdb.
> 
> Firmware receives the binary over QMI and verifies the signing.
> If it is authentic, the binary will be used.
> 
> Renumbered the enum ATH12K_BD_IE_BOARD_EXT to '2' since it is
> not used in the code. ATH12K_BD_IE_REGDB enum will take the value '1'
> as per the ath11k upstream design.
> 
> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1
> 
> Signed-off-by: Karthik M <quic_karm@quicinc.com>

It's a long time since I tested this and this doesn't apply anymore so I
cannot give you any detailed report. But IIRC I noticed in my test that
having just board.bin didn't work anymore. Please double check that, rebase and
submit v2.

Patch set to Changes Requested.

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20230131123422.24985-1-quic_karm@quicinc.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches