Received: by 2002:a05:7412:3784:b0:e2:908c:2ebd with SMTP id jk4csp2238136rdb; Tue, 3 Oct 2023 14:58:50 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH2qFS8luXkGNPPftr8uxuj7THI8WVe8s2ot8iisiN/A6YRBn8qe4VRVXV9PGTGDkVknO2v X-Received: by 2002:aca:1a04:0:b0:3a7:af4c:2406 with SMTP id a4-20020aca1a04000000b003a7af4c2406mr740684oia.44.1696370330619; Tue, 03 Oct 2023 14:58:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696370330; cv=none; d=google.com; s=arc-20160816; b=NIOqhtmz8/JW5niJuqr0Veno80VD/v6Sd+nUc5loWNXRPoHoRojHdaT2+sc7hwRilk /0u7rLFqqc3DOYjVZ6A63OOqkNegIIDR/vbQmiT5rDaUBVIDFk43VKufKA3TndS2DFU+ c2eZxczkt25p3FZg4kXGRenwPm3cbiNxjPcR42Ti+dxjybyRRx9yFuxvRa0lI263cDTE sNhc0YPjvYBSX4dHmXixrhfPDaqMFhuFDK/SEwInnxn6yWXewED+Lu3NL3E+OAhHiE39 ZUnJ7Wlt4JRXDe51r4qq8PHvtw3WQyQNc3O2cWzmQ2pfP+Hjbm6c8gCdQyP3DvLoTnZo wcvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature:dkim-filter; bh=cH8+WVn2W6cUk+Y/cmig7erMH5X2x4RsGgZJjpMupJ0=; fh=JBH4xoAqU+QnblKa21BUCNwDoqYIhtDQiRUeFKc8nFo=; b=MWmkyhLnOJzrK3ggs0b7yERTlKZCuHIAxTmYa3Ar1vDKuibFAnimpcOvNnDA56u1Vs RMtekPRz1uHEUw4FbPZKj5gFtXO3ec8RuNGg/KK/ssriZ4jtEGf/mYN9GyPPh3fiYbf5 kIz9iM+UVZj8v8I7lw05M+Wng9g5Ek2NtoxMHw4xy2hmhGoZxKqxvxRioryIHLiT3i6C GIk3u9hq2REV/WsqxMcqVej2MVHcVsC4eEEBXYrufIf9PU1Gm/aiD1mhJOrS3pYBYYQv L/2tp+abNSzS8xB9CIqk9aUTkRRrADQh5qaV+uCNz2UT3znhSPDe4ZmSfLVSQ8E/bbof 1G+w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@candelatech.com header.s=default header.b=NB+Tm4Wc; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=candelatech.com Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [2620:137:e000::3:3]) by mx.google.com with ESMTPS id gb3-20020a17090b060300b0027995cf4342si136622pjb.55.2023.10.03.14.58.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Oct 2023 14:58:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3; Authentication-Results: mx.google.com; dkim=pass header.i=@candelatech.com header.s=default header.b=NB+Tm4Wc; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=candelatech.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id BBD6381B211A; Tue, 3 Oct 2023 14:58:45 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232460AbjJCV6r (ORCPT + 53 others); Tue, 3 Oct 2023 17:58:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42634 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232458AbjJCV6q (ORCPT ); Tue, 3 Oct 2023 17:58:46 -0400 Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.49]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2ACD1A6 for ; Tue, 3 Oct 2023 14:58:43 -0700 (PDT) X-Virus-Scanned: Proofpoint Essentials engine Received: from mail3.candelatech.com (mail2.candelatech.com [208.74.158.173]) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id 93B19A80071 for ; Tue, 3 Oct 2023 21:58:41 +0000 (UTC) Received: from ben-dt5.candelatech.com (50-251-239-81-static.hfc.comcastbusiness.net [50.251.239.81]) by mail3.candelatech.com (Postfix) with ESMTP id 1833913C2B0; Tue, 3 Oct 2023 14:58:41 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 mail3.candelatech.com 1833913C2B0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=candelatech.com; s=default; t=1696370321; bh=j+2iI5Ljhwh3oxtbEWOohd0yhLv4csUwh/m1ozxjmsE=; h=From:To:Cc:Subject:Date:From; b=NB+Tm4WcTVfAWO3KkbQpH1D6SvEXN7KrBaBR8dkzd87OW0id+HEPQxuuCys3Bpo/B 72cFxAHfSTv15o8hu1ETtaThslXCFVcUmgupzWgvFkgs1BZKNfYoAuwYL2ErOvSuu/ kiMViskWEQ2efPWJ0PJQA/MdCL9bjV4X/deyHLqM= From: greearb@candelatech.com To: linux-wireless@vger.kernel.org Cc: Ben Greear Subject: [PATCH] mac80211: ethtool: check link sta if deflink sta not found. Date: Tue, 3 Oct 2023 14:58:39 -0700 Message-Id: <20231003215839.981227-1-greearb@candelatech.com> X-Mailer: git-send-email 2.40.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-MDID: 1696370322-O5XpusY6R4Lx X-MDID-O: us5;ut7;1696370322;O5XpusY6R4Lx;;f7146c1849a4b08a52804beb1c1cdf45 X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Tue, 03 Oct 2023 14:58:45 -0700 (PDT) From: Ben Greear While testing with wifi-7 radio put into AX mode, link-0 is created. sdata->deflink.u.mgd.bssid was 00 in this case, so sta was not found. Use link-0 for sta if it is available to do a better job of reporting ethtool stats. Signed-off-by: Ben Greear --- net/mac80211/ethtool.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/net/mac80211/ethtool.c b/net/mac80211/ethtool.c index 6bd7fba8a867..1b58304fc68a 100644 --- a/net/mac80211/ethtool.c +++ b/net/mac80211/ethtool.c @@ -96,6 +96,7 @@ static void ieee80211_get_stats2(struct net_device *dev, struct ieee80211_local *local = sdata->local; struct station_info sinfo; struct survey_info survey; + struct ieee80211_link_data *link; int i, q; int z; #define STA_STATS_SURVEY_LEN 7 @@ -128,6 +129,12 @@ static void ieee80211_get_stats2(struct net_device *dev, if (sdata->vif.type == NL80211_IFTYPE_STATION) { sta = sta_info_get_bss(sdata, sdata->deflink.u.mgd.bssid); + if (!sta) { + link = sdata_dereference(sdata->link[0], sdata); + if (link) + sta = sta_info_get_bss(sdata, link->u.mgd.bssid); + } + if (!(sta && !WARN_ON(sta->sdata->dev != dev))) goto do_survey; -- 2.40.0