Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
From:   =?ISO-8859-1?Q?J=E9r=F4me?= Pouiller <jerome.pouiller@silabs.com>
To:     Kalle Valo <kvalo@kernel.org>
Cc:     linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/9] wifi: wfx: fix power_save setting when AP is stopped
Date:   Wed, 04 Oct 2023 12:37:02 +0200
Message-ID: <14139521.lVVuGzaMjS@pc-42>
Organization: Silicon Labs
In-Reply-To: <87ttr6heoz.fsf@kernel.org>
References: <20230927163257.568496-1-jerome.pouiller@silabs.com>
 <20230927163257.568496-2-jerome.pouiller@silabs.com>
 <87ttr6heoz.fsf@kernel.org>
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?SafGXu8c7Mioh01q34xdA0dXAFDiU6etZQd6/it3/iutz0elKsCTTcQhbB?=
 =?iso-8859-1?Q?ROJJSEu1WlUPujMfCDAsZUePvVGdI6y1XnlDJbhtQd9LSYxHWLCl8nWuow?=
 =?iso-8859-1?Q?gjKxpCU0vUYs+8P31ugvoNqPSQoQSJuziE9qNJNv9v2Q7xA9i6S2veEEBc?=
 =?iso-8859-1?Q?QSUAcVk+ZUF8qiNokORa4CfhczeqauT2AyBaF9+h0wP2+YSOPABrYLL+j5?=
 =?iso-8859-1?Q?K3efWSh1Fuy8366czvXnHkXDWBdYyBcQlO4lVLNhIye2gokz55RR3eX3Yv?=
 =?iso-8859-1?Q?yHB09dylIe5fkQNv/j1d1ITvi+7C9uwPslxJXjSvS7ITk3fR2CqKVk1a3U?=
 =?iso-8859-1?Q?OSP5doPA+uaR0sqwLsuwwAyLFmZrv6XHE4X7+eblTOpYDJTSbUqJMSFz4r?=
 =?iso-8859-1?Q?gEtY4BTIhRd3BLsVKBtDTqbnUwovZU1bTTWhnLRdWhntkrXGx0LOYpbXQM?=
 =?iso-8859-1?Q?26K9inkVhFbzNpHEAmUSZvFVswvQZO0WvB8/VSBkbrHzbSQuO5KfwG1n1D?=
 =?iso-8859-1?Q?JG5xuM0u3wkh6VuVCiR1AxA7IcJezRdI12uLT3u2m7JMIUrRSv9z7vuC83?=
 =?iso-8859-1?Q?XiozAHpFxe5+XS/HVJx2XsYyrZUHUml9lRSrzz53e6qy5pl88fIqQ10T/e?=
 =?iso-8859-1?Q?YKYLzuSRTjwp4KHXSAkGvNUbc231IIMH3Ds8/Ulyx0AHDqwfjkoWZ8Edgl?=
 =?iso-8859-1?Q?9RMTEsIgsEu1tdQ0VgomwJ/dy0St5DRVNwNc5Wqx8eSbeyCkj4OIo9VNHC?=
 =?iso-8859-1?Q?8MDl9Li4MyOf8c3Jn2wNgIYMk3kjiDWlkM5GdBaZ1NEyJvfMLgNrPq4n3d?=
 =?iso-8859-1?Q?TRVP+CjzLmwGbSuJsm2izIZBToUlpu3ZEfPC7Ak+aDTOZjiN1zmK1uO/UW?=
 =?iso-8859-1?Q?KkOffAX175lzZFP80V+ojtY72YfHAl2MKhB88ppWM5tZwZgPCANrfPrdAw?=
 =?iso-8859-1?Q?O4GTjCwYAe+XFrHvPi9rLr56hOzVapdhA/JKV4/baJ14wFhzS4b39Zer2D?=
 =?iso-8859-1?Q?bQWg6vMOsZeKlCG40IEVd+EQBl2xeaH7jltAn9C9A3WfQnpF08O7FN9+S/?=
 =?iso-8859-1?Q?yJ78wlVpSFpHUOMEPUdyiQaPldGyrxHfb0faRk1WCDlu5oQsuwrjZpDstA?=
 =?iso-8859-1?Q?aPdRNKlLwPiepmSdJ7ou3h5XbzOzHciEI0wtwDknEobp9h25AraW2OoJyj?=
 =?iso-8859-1?Q?j3yuaeWIO1bQsTv4RAuMXQHr82+FmfVjxAIlpIRxf1r3n4vVctBzowNnCZ?=
 =?iso-8859-1?Q?m3glWO191GaiGnh+ixIIp1pH5pFu+ci1XiPhy0B66on19uowCuElK8o3Qn?=
 =?iso-8859-1?Q?5ObGt6HvEel9bYf1NVWnU/yW1bBcuEogmHIaG6lVpSkq7s3P0jgu1vfy6F?=
 =?iso-8859-1?Q?wt/Zb88Vdrhca8+vf/9edt/1ZW0uIkSRSZ8QPKFeeoVtHfNqK/rDAP/9jk?=
 =?iso-8859-1?Q?LmH2jIME7njs3+wYwXQSFTDETV9/Eh2F+pfT82qwC4Uzm0VB6fHSbxWZh4?=
 =?iso-8859-1?Q?+zktyb9UdieWmLP2IZwo7sl5nKsDYKoBQrMLJMCKziRBlkaY/Ezi7stjVV?=
 =?iso-8859-1?Q?OFaceRdGW6I/HlQl/isHzlefHgYI6nuy2Xtl6GGeAqcKWe9PmE/nv/YjwB?=
 =?iso-8859-1?Q?S3eb0hXK1JEyaPHeapJAlhMR0C4z8y519pTSsAdW84ijilH/i6s2P+em4b?=
 =?iso-8859-1?Q?Kr93oP+EJksrKC58816rr3G7G+/hCFFbm0VzN4PK?=
X-OriginatorOrg: silabs.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7ad1c859-d5d4-422f-3357-08dbc4c5daee
X-MS-Exchange-CrossTenant-AuthSource: IA1PR11MB7773.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2023 10:37:06.4713
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 54dbd822-5231-4b20-944d-6f4abcd541fb
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WORnZsYf65GmcAAzKX19aWCaKheAq+g4gN/f2FA/jqeFVu5ij+B29LrR6l8BdeVilz4Dif1oaXPfW2Y2UTq4PA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB8248
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,
	SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Wed, 04 Oct 2023 03:37:12 -0700 (PDT)

Hi Kalle,

On Wednesday 4 October 2023 12:20:12 CEST Kalle Valo wrote:
>=20
> J=E9r=F4me Pouiller <jerome.pouiller@silabs.com> writes:
>=20
> > The WF200 allow to start two network interfaces (one AP, one station) o=
n
> > two different channels. Since magic does not exist, it only works if th=
e
> > station interface enables power save.
> >
> > Thus, the driver detects this case and enforce power save as necessary.
> >
> > This patch fixes the case where the AP interface is stopped and it is n=
o
> > more necessary to enforce power saving on the station interface.
> >
> > Signed-off-by: J=E9r=F4me Pouiller <jerome.pouiller@silabs.com>
> > ---
> >  drivers/net/wireless/silabs/wfx/sta.c | 5 +++++
> >  1 file changed, 5 insertions(+)
> >
> > diff --git a/drivers/net/wireless/silabs/wfx/sta.c b/drivers/net/wirele=
ss/silabs/wfx/sta.c
> > index 626dfb4b7a55d..9c0a11c277e97 100644
> > --- a/drivers/net/wireless/silabs/wfx/sta.c
> > +++ b/drivers/net/wireless/silabs/wfx/sta.c
> > @@ -402,7 +402,12 @@ void wfx_stop_ap(struct ieee80211_hw *hw, struct i=
eee80211_vif *vif,
> >                struct ieee80211_bss_conf *link_conf)
> >  {
> >       struct wfx_vif *wvif =3D (struct wfx_vif *)vif->drv_priv;
> > +     struct wfx_dev *wdev =3D wvif->wdev;
> >
> > +     wvif =3D  NULL;
> > +     while ((wvif =3D wvif_iterate(wdev, wvif)) !=3D NULL)
> > +             wfx_update_pm(wvif);
>=20
> Isn't the assignment of wvif to NULL unnecessary as in the next line we
> assign it to again?

wvif is also passed as argument to wvif_iterate(). wvif_iterate() uses this
parameter to know where the iteration has stopped on previous call.

However, the assignation during the declaration of wvif is useless.

--=20
J=E9r=F4me Pouiller