Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
From:   =?ISO-8859-1?Q?J=E9r=F4me?= Pouiller <jerome.pouiller@silabs.com>
To:     Kalle Valo <kvalo@kernel.org>
Cc:     linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
        Felix Fietkau <nbd@nbd.name>,
        Felipe Negrelli Wolter <felipe.negrelliwolter@silabs.com>,
        Olivier Souloumiac <olivier.souloumiac@silabs.com>,
        Alexandr Suslenko <suslenko.o@ajax.systems>
Subject: Re: [PATCH v2] wifi: wfx: fix case where rates are out of order
Date:   Wed, 04 Oct 2023 15:00:49 +0200
Message-ID: <2534699.vzjCzTo3RI@pc-42>
Organization: Silicon Labs
In-Reply-To: <8734yq7dg0.fsf@kernel.org>
References: <20231004123039.157112-1-jerome.pouiller@silabs.com>
 <8734yq7dg0.fsf@kernel.org>
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?Bpax8I+sDQivjvFQDycO+2zX3Ebxbea+zrMWGhYZJDg44RC1f6uxn7l3eH?=
 =?iso-8859-1?Q?ExOQaYah71gC+J/S6kYew/3cE6dadwqdMPQ0Nd+QDAA6dP5lRJXwRD3OtZ?=
 =?iso-8859-1?Q?fa8tOV0gDvk8ITEMpa5KhjDGx/btRJ2Cgx15EbVAoR5geeY8Ws1H8tU70w?=
 =?iso-8859-1?Q?GL4RHmX7JPxETIkYTc3IZ4Ui07q7E4ReBh3Lc5Zw706NiXLklyChnYLnAj?=
 =?iso-8859-1?Q?syrx0I0tl2o0tF8V10R0H+xq1lobfluMx59wBXyeWNe4hA/6nGi6NZbIpx?=
 =?iso-8859-1?Q?9sqlMxRiAvyQ13xTKeVDToY8eLifouR8VRrCyNLtwcHKGGgWUvFcMyuRFa?=
 =?iso-8859-1?Q?JA2gw6Pxm9mT5oB8r8BaFwS+Dsna9MpqPqnqjQGcBWDYl+KTeys2SUfs8O?=
 =?iso-8859-1?Q?zUp7uLBaN2Tsbalbh+v89eJATplJ6zY9Zs4IM0fHD5YxrLvwZIVvbeKGFT?=
 =?iso-8859-1?Q?yR3bqpIGVsxZXxD3FFwGNBlyNHUJWczqNZPmKpl8b8WV8yBo49FpNOvTUA?=
 =?iso-8859-1?Q?L1QASS9lt40/SzJBMDx2VGypteqa1E0PBYyvUyHv+DZVJKvYSsp7xjezPo?=
 =?iso-8859-1?Q?pdqTjuk8tcYqcjucDMicz9NGInCJV74masarTxs+LGpkSsJO8AxR+KOItQ?=
 =?iso-8859-1?Q?M6dWhcLvLJEB1a3RhIV7eThP3Wdl8riJVE5isD5ezCiB8XE9qwDl+G8Jw7?=
 =?iso-8859-1?Q?/ntSRq0iZfmKCyvxhHheHNiCfwXQ/MQprpaRxcQsM7yF5F1H0KOLYGXn3y?=
 =?iso-8859-1?Q?STRPeWMRJH7PVztjr6q5WgJGbOGIEbDLnyADVINET+O8sBXxG85sn7YhEu?=
 =?iso-8859-1?Q?mLdm+4ZURLMqygahGxsaAjDKm7A68psThhb/peqDfxpLNLrxm85M/5pH5f?=
 =?iso-8859-1?Q?W/Bvih8uhvcpMswB0I6DTNKsVpA7Am6oqCWXWRNJmhedrvSi4kx2LqYEX1?=
 =?iso-8859-1?Q?AzhBrXYm7EYSb/2vtk56CCD4hSH8NKqyt81BZsihA2r20WhWIyPtwlZp0A?=
 =?iso-8859-1?Q?EZQOC8ILFplMtFF5248LYI4meQjX2IBO1ucAQTZYxmRqKTku6221w1kGue?=
 =?iso-8859-1?Q?5kCHGRXHRLfl/5dY+SByi9XRVMfIGXd5JFY3m06h2zDfkZbZFb83/W4KGK?=
 =?iso-8859-1?Q?YmVcgRzfEgrRGnxcNsM0pGuDOFZyrekoC0dH0MLu7UF2ZnTmm3VzK7aVLw?=
 =?iso-8859-1?Q?YNHbcPFeuYPARAt2ijeZ0+7KkRJMEvVvF+JGAADPaoauUkITepZ8Am3SAE?=
 =?iso-8859-1?Q?fCgo72XCxmclhWSw/WIYjwG4IHiNPY9YOe7Mc5RDsyCoSIKYcu4b9PAG4V?=
 =?iso-8859-1?Q?Kpd/Q4b4sIn1YOdeTeanBOHv4C5mbBnLzMBlKHiMAoFVkMCNQtwZnqnziI?=
 =?iso-8859-1?Q?mhuyiDQYpHKCykCWUJZghOEWaM/nqv1ZNH07pZJ8/WF5/qY71JsLjTAYHc?=
 =?iso-8859-1?Q?rxBy/ohUGnEhejvc9xEP5wj60LUYq2tmxaAk32p3BM5M2UTMe1sBGw0dM3?=
 =?iso-8859-1?Q?AEtKvwziT7OD/Rxc/o2743jcy1ZSl2mjv+bYAvfbCDs21OLyMaqopbTGP0?=
 =?iso-8859-1?Q?qBZ+7eIaFbPKbBE//USMwjtcA8z+U5PfSNbYseN59XwsUJY/oawffU9IIo?=
 =?iso-8859-1?Q?GZt0CtOgvUj5uyqf1tKCCcZ5RhVVBkqLDM2/gGODa6HiX38kNZxCn+wJ9w?=
 =?iso-8859-1?Q?9rsnnXtuf50GHIXtIbTLrauab41UbKGUnyYk33Ua?=
X-OriginatorOrg: silabs.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 56a3ec1c-a458-43e5-0db1-08dbc4d9f17e
X-MS-Exchange-CrossTenant-AuthSource: IA1PR11MB7773.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2023 13:00:54.2835
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 54dbd822-5231-4b20-944d-6f4abcd541fb
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 53mVJJewFTIZkwA0FvqZCd6m7dz0iuMQZtTwXyvGH8A3Gq8fG02hIrrM1LxRmeMTAZXlF6xX7437BGMr/6/5RQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6547
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,
	SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Wed, 04 Oct 2023 06:01:07 -0700 (PDT)

On Wednesday 4 October 2023 14:57:19 CEST Kalle Valo wrote:
> J=E9r=F4me Pouiller <jerome.pouiller@silabs.com> writes:
>=20
> > From: Felipe Negrelli Wolter <felipe.negrelliwolter@silabs.com>
> >
> > When frames are sent over the air, the device always applies the data
> > rates in descending order. The driver assumed Minstrel also provided
> > rate in descending order.
> >
> > However, in some cases, Minstrel can a choose a fallback rate greater
> > than the primary rate. In this case, the two rates was inverted, the
> > device try highest rate first and we get many retries.
> >
> > Since the device always applies rates in descending order, the
> > workaround is to drop the rate when it higher than its predecessor in
> > the rate list. Thus [ 4, 5, 3 ] becomes [ 4, 3 ].
> >
> > This patch has been tested in isolated room with a series of
> > attenuators. Here are the Minstrel statistics with 80dBm of attenuation=
:
> >
> >   Without the fix:
> >
> >                   best    ____________rate__________    ____statistics_=
__    _____last____    ______sum-of________
> >     mode guard #  rate   [name   idx airtime  max_tp]  [avg(tp) avg(pro=
b)]  [retry|suc|att]  [#success | #attempts]
> >     HT20  LGI  1       S  MCS0     0    1477     5.6       5.2      82.=
7       3     0 0             3   4
> >     HT20  LGI  1          MCS1     1     738    10.6       0.0       0.=
0       0     0 0             0   1
> >     HT20  LGI  1     D    MCS2     2     492    14.9      13.5      81.=
5       5     0 0             5   9
> >     HT20  LGI  1    C     MCS3     3     369    18.8      17.6      84.=
3       5     0 0            76   96
> >     HT20  LGI  1  A   P   MCS4     4     246    25.4      22.4      79.=
5       5     0 0         11268   14026
> >     HT20  LGI  1   B   S  MCS5     5     185    30.7      19.7      57.=
7       5     8 9          3918   9793
> >     HT20  LGI  1          MCS6     6     164    33.0       0.0       0.=
0       5     0 0             6   102
> >     HT20  LGI  1          MCS7     7     148    35.1       0.0       0.=
0       0     0 0             0   44
> >
> >   With the fix:
> >
> >                   best    ____________rate__________    ____statistics_=
__    _____last____    ______sum-of________
> >     mode guard #  rate   [name   idx airtime  max_tp]  [avg(tp) avg(pro=
b)]  [retry|suc|att]  [#success | #attempts]
> >     HT20  LGI  1       S  MCS0     0    1477     5.6       1.8      28.=
6       1     0 0             1   5
> >     HT20  LGI  1     DP   MCS1     1     738    10.6       9.7      82.=
6       4     0 0            14   34
> >     HT20  LGI  1          MCS2     2     492    14.9       9.2      55.=
4       5     0 0            52   77
> >     HT20  LGI  1   B   S  MCS3     3     369    18.8      15.6      74.=
9       5     1 1           417   554
> >     HT20  LGI  1  A       MCS4     4     246    25.4      16.7      59.=
2       5     1 1         13812   17951
> >     HT20  LGI  1    C  S  MCS5     5     185    30.7      14.0      41.=
0       5     1 5            57   640
> >     HT20  LGI  1          MCS6     6     164    33.0       0.0       0.=
0       0     0 1             0   48
> >     HT20  LGI  1       S  MCS7     7     148    35.1       0.0       0.=
0       0     0 0             0   36
> >
> > We can notice the device try now to send with lower rates (and high
> > success rates). At the end, we measured 20-25% better throughput with
> > this patch.
> >
> > Fixes: 9bca45f3d692 ("staging: wfx: allow to send 802.11 frames")
> > Tested-by: Olivier Souloumiac <olivier.souloumiac@silabs.com>
> > Tested-by: Alexandr Suslenko <suslenko.o@ajax.systems>
> > Reported-by: Alexandr Suslenko <suslenko.o@ajax.systems>
> > Co-developed-by: J=E9r=F4me Pouiller <jerome.pouiller@silabs.com>
> > Signed-off-by: J=E9r=F4me Pouiller <jerome.pouiller@silabs.com>
> > Signed-off-by: Felipe Negrelli Wolter <felipe.negrelliwolter@silabs.com=
>
> > ---
> > v2:
> >   - Fix malformed tags in commit body. (checkpatch still complains abou=
t
> >     missing Close tag, but the bug tracker is not public and I don't ha=
ve
> >     the exact URL)
>=20
> Just out of curiosity why does the checkpatch complain about a missing
> Close tag? I don't get it why there should be one.

I am on top of v6.6-rc3. I get:

    $ ./scripts/checkpatch.pl -g HEAD^..HEAD
    WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit =
description?)
    #26:
                      best    ____________rate__________    ____statistics_=
__    _____last____    ______sum-of________

    WARNING: Reported-by: should be immediately followed by Closes: with a =
URL to the report
    #57:
    Reported-by: Alexandr Suslenko <suslenko.o@ajax.systems>
    Co-developed-by: J=E9r=F4me Pouiller <jerome.pouiller@silabs.com>
    [...]

--=20
J=E9r=F4me Pouiller