Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
From:   Kalle Valo <kvalo@kernel.org>
To:     =?utf-8?B?SsOpcsO0bWU=?= Pouiller <jerome.pouiller@silabs.com>
Cc:     linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
        Felix Fietkau <nbd@nbd.name>,
        Felipe Negrelli Wolter <felipe.negrelliwolter@silabs.com>,
        Olivier Souloumiac <olivier.souloumiac@silabs.com>,
        Alexandr Suslenko <suslenko.o@ajax.systems>
Subject: Re: [PATCH v2] wifi: wfx: fix case where rates are out of order
References: <20231004123039.157112-1-jerome.pouiller@silabs.com>
        <8734yq7dg0.fsf@kernel.org> <2534699.vzjCzTo3RI@pc-42>
Date:   Wed, 04 Oct 2023 16:22:12 +0300
In-Reply-To: <2534699.vzjCzTo3RI@pc-42> (=?utf-8?B?IkrDqXLDtG1l?=
 Pouiller"'s message of "Wed,
        04 Oct 2023 15:00:49 +0200")
Message-ID: <87y1gi5xq3.fsf@kernel.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

J=C3=A9r=C3=B4me Pouiller <jerome.pouiller@silabs.com> writes:

>> > v2:
>> >   - Fix malformed tags in commit body. (checkpatch still complains abo=
ut
>> >     missing Close tag, but the bug tracker is not public and I don't h=
ave
>> >     the exact URL)
>>=20
>> Just out of curiosity why does the checkpatch complain about a missing
>> Close tag? I don't get it why there should be one.
>
> I am on top of v6.6-rc3. I get:
>
>     $ ./scripts/checkpatch.pl -g HEAD^..HEAD
>     WARNING: Prefer a maximum 75 chars per line (possible unwrapped commi=
t description?)
>     #26:
>                       best    ____________rate__________    ____statistic=
s___    _____last____    ______sum-of________
>
>     WARNING: Reported-by: should be immediately followed by Closes: with =
a URL to the report
>     #57:
>     Reported-by: Alexandr Suslenko <suslenko.o@ajax.systems>
>     Co-developed-by: J=C3=A9r=C3=B4me Pouiller <jerome.pouiller@silabs.co=
m>
>     [...]

Ah, thanks. Now I understand. But that rule doesn't make any sense to
me, for example I get reports privately as well and add a Reported-by
without a Closes tag. So always feel free to ignore that checkpatch
warning.

--=20
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatc=
hes