Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
From:   =?ISO-8859-1?Q?J=E9r=F4me?= Pouiller <jerome.pouiller@silabs.com>
To:     Kalle Valo <kvalo@kernel.org>
Cc:     linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/9] wifi: wfx: fix power_save setting when AP is stopped
Date:   Wed, 04 Oct 2023 19:26:03 +0200
Message-ID: <3984977.e99z0qppnp@pc-42>
Organization: Silicon Labs
In-Reply-To: <877co27hga.fsf@kernel.org>
References: <20230927163257.568496-1-jerome.pouiller@silabs.com>
 <14139521.lVVuGzaMjS@pc-42> <877co27hga.fsf@kernel.org>
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?wM5BRrOQ1QxpqLkB6NtCoKVWJHJNuAv1+gOpdJotAELJOvhwEO7Vxi1H5i?=
 =?iso-8859-1?Q?wdOKWmeUOp41s8CTb1ZUA8K/nOeGQu2tjA8dpvcqbN8trgZBnJy/8/ovx/?=
 =?iso-8859-1?Q?+aiAc07RRJtcBjbFwSMYjvLtfy9EPsiEXBIUtEqlDAiMe9ky16FI5EV9kv?=
 =?iso-8859-1?Q?7SjioGhtNtGLUYsFn0ocYYBJKaDqVuRyuqVJp4i9TaecfBwygTEHSRl6X+?=
 =?iso-8859-1?Q?NvUo25SRy+V7p5fXP9r5kOhXvkUpshMDYCI2zNHtMPCrvsW/tT2bT0YxjC?=
 =?iso-8859-1?Q?weRmJDfc/m1s3Zk2pBS1txgHSsibu0nWapNF7S9dVbUnUls+mqXXpZtOAv?=
 =?iso-8859-1?Q?QA6dm9iNZHWbQAGcd3KubM2fUortOr0+q+6IUu4Nk9Rf88mKd/1bPjXOHS?=
 =?iso-8859-1?Q?rfaFzlgZBaranXg7vEQKIkqOfy5KFFlzoDdlv689FKeGuxMELRZjsIM0Zc?=
 =?iso-8859-1?Q?I76e0tIh+KSsCExYLbHsHzxvmOvUtXNahmKbVWIuf6m5ON6v11gcyhGjji?=
 =?iso-8859-1?Q?NVcGfK+PmrYMfgqe5EbXzpJlRhH4+fwNMfSyf/qjs5qdBDbjCH/hb/KZtS?=
 =?iso-8859-1?Q?9QmvznhCsT+op+ZHQORd6YKBp/pehV3y1wXFqYIQfjCLyYaJJsHofDGpzM?=
 =?iso-8859-1?Q?tjs7ukAyWytOgyCaDZ47ARXjFSwWr+Uzqq6wjGXGRVu9mqxGJsChthx/4b?=
 =?iso-8859-1?Q?QZeLsuDDZmjM+ZZ/T/spdMqmVmrbI3+E6PkDN+YIS0FJp/ubm/raZHO1qS?=
 =?iso-8859-1?Q?apGvQCpgIQx5Ra5wv5wcRcIR7sNZrM1tDrA7vSyrVjfN9Uzvq061ryoP5S?=
 =?iso-8859-1?Q?WZ4/GyGwl6f41wOTkeZYa2w9Gmlf8amMGPixKxj6mPumW/dg1m9hOAMTzE?=
 =?iso-8859-1?Q?AyUK36J/9PajZ4bUbMLfiNb4EcM3cXTMjwmURC07t249u805xTCkajuHq7?=
 =?iso-8859-1?Q?AY7nceSrlp4JZowJjFSBgsESSV7KTniEyBecIeip0HY8yO0jhiRo6lqfCk?=
 =?iso-8859-1?Q?ZIqAUrl5SpQkxC8Nb1imnMy/ZPSzWw+FfNvl5vQSOV+b5CGVXAquiEjuuk?=
 =?iso-8859-1?Q?LPApDx2jiG4V6h3cNkE0rdCS0BmFBGZzCAUWYrbg+6ZHtJrzHt3n/HC614?=
 =?iso-8859-1?Q?kF0Bc/mSfcnRFvff94vELlw0LXAXc501KW8xXT4fE/wUJCNwnJhRbp+xA1?=
 =?iso-8859-1?Q?HyeIXIM6LxldeLRSf4Ikl7zcEGSHJvmQd+EHfQ+WBYYAHlbGwCPA+jd5DH?=
 =?iso-8859-1?Q?IPRBzwlh49+arnREjRb5kLw7g7J2Z2VjLlX3KtETvhq90BNdb15/5RXvyE?=
 =?iso-8859-1?Q?qO6ZekpMeR4OqTAXGTIqDGaecjaNr+B3nhoxskNxTgC6m+4gkhiIDUNlrv?=
 =?iso-8859-1?Q?T0MQT+32RkSnouygmsyq5BPL2s3tzxyFGMjqq5JsRN/MUcIJ/ERoWiGiq4?=
 =?iso-8859-1?Q?Umy2RLqHmN95YoibqT7TXF5eP7ugKoah89XHcGy5jmtEnodY3d8rf9gzo5?=
 =?iso-8859-1?Q?hXMXEnMa3VeqX2rmmeDLIUcHTa0q8AUlGUs3pblpKp/gCSQxwAz1O7jQG1?=
 =?iso-8859-1?Q?Szs/gceG2npZpSRIH4HfavrBnUZkXvuEcWVtJME7KCD7d8IEvp8Uqby8Yf?=
 =?iso-8859-1?Q?9Hc6+MfKi4dXx4FPpl+JbrzOdS8VZdDmsnE9To6VD/17r/34szvABDCzUy?=
 =?iso-8859-1?Q?jbWZxS34yqRPXbQ3/DzbS7qU//Dqm8gbF2Zy/l1r?=
X-OriginatorOrg: silabs.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7a1f077b-22a7-4006-67b2-08dbc4fefe24
X-MS-Exchange-CrossTenant-AuthSource: IA1PR11MB7773.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2023 17:26:06.9662
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 54dbd822-5231-4b20-944d-6f4abcd541fb
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: yq2e0HWbHMaen+2z5ROW5su4nsT61MKlkDGbz0gESDoC/8Ko8j45eLJTFkdM+N4MyMApOov+9XInKquDma9X/w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB8071
X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,FORGED_SPF_HELO,RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,
        SPF_HELO_PASS,SPF_NONE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Wed, 04 Oct 2023 10:26:19 -0700 (PDT)

On Wednesday 4 October 2023 13:30:45 CEST Kalle Valo wrote:
> CAUTION: This email originated from outside of the organization. Do not c=
lick links or open attachments unless you recognize the sender and know the=
 content is safe.
>=20
>=20
> J=E9r=F4me Pouiller <jerome.pouiller@silabs.com> writes:
>=20
> > Hi Kalle,
> >
> > On Wednesday 4 October 2023 12:20:12 CEST Kalle Valo wrote:
> >>
> >> J=E9r=F4me Pouiller <jerome.pouiller@silabs.com> writes:
> >>
> >> > The WF200 allow to start two network interfaces (one AP, one station=
) on
> >> > two different channels. Since magic does not exist, it only works if=
 the
> >> > station interface enables power save.
> >> >
> >> > Thus, the driver detects this case and enforce power save as necessa=
ry.
> >> >
> >> > This patch fixes the case where the AP interface is stopped and it i=
s no
> >> > more necessary to enforce power saving on the station interface.
> >> >
> >> > Signed-off-by: J=E9r=F4me Pouiller <jerome.pouiller@silabs.com>
> >> > ---
> >> >  drivers/net/wireless/silabs/wfx/sta.c | 5 +++++
> >> >  1 file changed, 5 insertions(+)
> >> >
> >> > diff --git a/drivers/net/wireless/silabs/wfx/sta.c b/drivers/net/wir=
eless/silabs/wfx/sta.c
> >> > index 626dfb4b7a55d..9c0a11c277e97 100644
> >> > --- a/drivers/net/wireless/silabs/wfx/sta.c
> >> > +++ b/drivers/net/wireless/silabs/wfx/sta.c
> >> > @@ -402,7 +402,12 @@ void wfx_stop_ap(struct ieee80211_hw *hw, struc=
t ieee80211_vif *vif,
> >> >                struct ieee80211_bss_conf *link_conf)
> >> >  {
> >> >       struct wfx_vif *wvif =3D (struct wfx_vif *)vif->drv_priv;
> >> > +     struct wfx_dev *wdev =3D wvif->wdev;
> >> >
> >> > +     wvif =3D  NULL;
> >> > +     while ((wvif =3D wvif_iterate(wdev, wvif)) !=3D NULL)
> >> > +             wfx_update_pm(wvif);
> >>
> >> Isn't the assignment of wvif to NULL unnecessary as in the next line w=
e
> >> assign it to again?
> >
> > wvif is also passed as argument to wvif_iterate(). wvif_iterate() uses =
this
> > parameter to know where the iteration has stopped on previous call.
>=20
> Ah, I missed that.
>=20
> > However, the assignation during the declaration of wvif is useless.
>=20
> Indeed, missed that as well.

In fact, this first assignation is used to fill wdev just below. So I am
keeping this code as-is.

--=20
J=E9r=F4me Pouiller