Received: by 2002:a05:7412:3784:b0:e2:908c:2ebd with SMTP id jk4csp2758619rdb; Wed, 4 Oct 2023 10:29:03 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEUjd/SegaPIn+sq7D0NambZO4SvMcwRJIAohhzHiqLLGyVAJ0t8QJUipHSIkMuwQYdTY4m X-Received: by 2002:a05:6a20:4418:b0:14d:16c:2d20 with SMTP id ce24-20020a056a20441800b0014d016c2d20mr3730378pzb.44.1696440542611; Wed, 04 Oct 2023 10:29:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696440542; cv=none; d=google.com; s=arc-20160816; b=Q7Hd8YeuPrcvjUVnHCLMuiR4Wocs3RKj/YxFNzo8zeUzSXcAlmDHG5cYqjGPieAuKa 8RhLy6FZhZlNbmIWIfEQA1q9HQ2SBhsOe6mlktQm/sPnAn4TKOCFnn1FFIPaM5p+lgqI RNnwuBfYCtMmi9SARTkTyJclcVtaPnjF2l1Db1q7OgMEKYdstgc31Y3X5Pa8zy5TqFSA 0KAT+9ifBBFNgPWO+nVEtONvOVELLCjDSiodC2TPYwD7zygvcZfcubXBxtJlF1fwvRrF ME7zbCpg4CoCRCtCVog9HwAGO1JC6CSouCNHVB3Il9YtcI2Nve6tkm+/JGvpVeL1td02 yjmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=FDkBTKBXRJaoRWC8Bk+aERVUwe9b+D5BySrJoFbV9IQ=; fh=q5/hMc5HKcHc6ixTzB0QV8Oys07wQ5qrs3jrUOk5KTI=; b=gZkgBXzf4Arl9H0+sMtlR1cS7KPf8Lp68oHyfhAgS0MBqkonA8ewXsmSt4w02KUOfo SDbt18fnHfQ99z6kAVt2NfLpZGA1Nhw/zXiabx6bctJ8cajh23mE2hx4jim/MAv1ejIe isIGI1XOZ7RQf/8b+HHN8xGuMx+KiXUWJmAstrJzJej8jVE2u64yzFcLuU8CtregAikl ToiT3Lea3rOEYMhglj9k7gIt9WQ7qNYG1fqTJvxVG8O1WMHW2vXSZsUQ5XAckcsy4vDt yTVEhHhJREy8VPhkJrkwshhGJbGvQuCzxUwpxqYdmSgjEo6CozPce6OqP/UQG+qVvvb5 EKSQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id z16-20020a656650000000b005859a7d38f9si4112788pgv.703.2023.10.04.10.29.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Oct 2023 10:29:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 8C3E881B5D2F; Wed, 4 Oct 2023 10:29:00 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243421AbjJDR2x (ORCPT + 53 others); Wed, 4 Oct 2023 13:28:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55054 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233422AbjJDR2x (ORCPT ); Wed, 4 Oct 2023 13:28:53 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CC544BD; Wed, 4 Oct 2023 10:28:49 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9C9E8C433C8; Wed, 4 Oct 2023 17:28:48 +0000 (UTC) Date: Wed, 4 Oct 2023 13:29:55 -0400 From: Steven Rostedt To: Jakub Kicinski Cc: Johannes Berg , linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org Subject: Re: [PATCH 0/4] tracing: improve symbolic printing Message-ID: <20231004132955.0fb3893d@gandalf.local.home> In-Reply-To: <20231004095431.1dd234e6@kernel.org> References: <20230921085129.261556-5-johannes@sipsolutions.net> <20231004092205.02c8eb0b@kernel.org> <20231004123524.27feeae7@gandalf.local.home> <20231004095431.1dd234e6@kernel.org> X-Mailer: Claws Mail 3.19.1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Wed, 04 Oct 2023 10:29:00 -0700 (PDT) On Wed, 4 Oct 2023 09:54:31 -0700 Jakub Kicinski wrote: > On Wed, 4 Oct 2023 12:35:24 -0400 Steven Rostedt wrote: > > > Potentially naive question - the trace point holds enum skb_drop_reason. > > > The user space can get the names from BTF. Can we not teach user space > > > to generically look up names of enums in BTF? > > > > That puts a hard requirement to include BTF in builds where it was not > > needed before. I really do not want to build with BTF just to get access to > > these symbols. And since this is used by the embedded world, and BTF is > > extremely bloated, the short answer is "No". > > Dunno. BTF is there most of the time. It could make the life of > majority of the users far more pleasant. BTF isn't there for a lot of developers working in embedded who use this code. Most my users that I deal with have minimal environments, so BTF is a showstopper. > > I hope we can at least agree that the current methods of generating > the string arrays at C level are... aesthetically displeasing. I don't know, I kinda like it ;-) -- Steve