Received: by 2002:a05:7412:3784:b0:e2:908c:2ebd with SMTP id jk4csp2826625rdb; Wed, 4 Oct 2023 12:38:39 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFEcyCnVjlIAZBiDswZ/ynQ9llqOndOIqw7SnOYpDQtG3/r/BM9vsHHhCXaiM796HMfbuFP X-Received: by 2002:a05:6a20:244f:b0:152:be08:b013 with SMTP id t15-20020a056a20244f00b00152be08b013mr3894107pzc.42.1696448319230; Wed, 04 Oct 2023 12:38:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696448319; cv=none; d=google.com; s=arc-20160816; b=Pxbr2hMri1CyCrRjlrA5qG5Ulx9/gePPb6yXWNBngblpIHHWVXOJ2DGXosUH4p0uwF 7Tn4ovB/DnMjQexnpe7EsotXap1vV5akB4FRT1M1Fu9AzBf1QR72uQoIYdv1CdLti/OY ah3EIEmQ0DsaAxxr/JxlWBXqPYyWi/NYhGpqmhMxwPxzj29KJ7MNTMYAjl8JiCou0vep hktWnwKG9Uhx3LJ3LBNverg7tANQzv+ApJlM3ivAXLY65PvZN4iTLS26yJFnErN07VqW 4Uv3qUKM80umi1fN09mZUQ0BYY2vcUO92LQLRJ4mh7lh9d1M0WLuwFgTKN7QsPYPnY4O e2bg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent :content-transfer-encoding:references:in-reply-to:date:to:from :subject:message-id:dkim-signature; bh=TkPv8Sbi3Zs7b8O8WyzzIUGcc2ER1uN3udrqf8p5nCs=; fh=7fg7tl4V75ikI9HbgSjaWG0L3NUqEorwYjMuQbGFyhU=; b=Cso5UmAZSGQB+qDA9Jjdqx33r8r8SvQj+v0KMdPJ1dZkjv+J3mDAmmQBCpnFNMLPEX PwKple9aAjfRuFBkzlp6TE9iIVfJSpFkKw3AFuMtD3jMpTGZ5mZV2ChMXoA2hLzVNGtA EbbqyI2evRRy/Z36h+Db3VH57Cq9wNjXF9/Vbmc5ghOo6WpGWB5O9JZWLKh8BH2Xj85t Dz7Yxu0UHiIvlmoU2QGRkY9IMMtx35rUscU/Cng6awNpZ+KEcU3J/D08TFSGRD7VBdhk oqxau08XD0Da7EvJBx5xPqyb4AYSWD0LcwMLvAbsrjs1bppPgclXzKsfzJ+QnmgGUBrf ILig== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sipsolutions.net header.s=mail header.b=EPMKscjZ; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=sipsolutions.net Return-Path: Received: from pete.vger.email (pete.vger.email. [23.128.96.36]) by mx.google.com with ESMTPS id c18-20020a630d12000000b00563dfffe7b9si4342318pgl.810.2023.10.04.12.38.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Oct 2023 12:38:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36; Authentication-Results: mx.google.com; dkim=pass header.i=@sipsolutions.net header.s=mail header.b=EPMKscjZ; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=sipsolutions.net Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 1EF7181F3473; Wed, 4 Oct 2023 12:38:37 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233525AbjJDTi1 (ORCPT + 53 others); Wed, 4 Oct 2023 15:38:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58702 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233651AbjJDTi1 (ORCPT ); Wed, 4 Oct 2023 15:38:27 -0400 Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:242:246e::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1DD59BD for ; Wed, 4 Oct 2023 12:38:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=MIME-Version:Content-Transfer-Encoding: Content-Type:References:In-Reply-To:Date:To:From:Subject:Message-ID:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=TkPv8Sbi3Zs7b8O8WyzzIUGcc2ER1uN3udrqf8p5nCs=; t=1696448304; x=1697657904; b=EPMKscjZu8ipY/qga2jXDSVAp5C372rMiJ6z0/RomUgiExv Fpe6BbbQ4EXXVUD1HYQqccVW0hhBJfonmZ2+aoHMeaYHgDRZg4+mZKzB2rgfODJeTfWku+sgvihwH yIpDg6LJSLjejsh05p1zE8cLpJMbYVRkBUfBi9otODrf01237KND5rIhnqczkLlUv1SbrCTeyCpxZ ucruIgVd1IhnVbO/VKi5kYNxXGFWcoyXapTSxcuvQMct49XV2kNbO/6/nvNsSo4lMqOq8upZeyCmW cEtEgN8zmwrBvu3VlyuarCHgs8FdaIiEFY2qKH9XrPxdLbmKMWrIWISAvRxJOVNg==; Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.97-RC0) (envelope-from ) id 1qo7hO-00000004UkN-0jeN; Wed, 04 Oct 2023 21:38:22 +0200 Message-ID: <4ae5a8dbe80e0eb0b96e9165892746fc3b3e9197.camel@sipsolutions.net> Subject: Re: [PATCH] mac80211: Allow STA to connect in AX mode to MLD AP. From: Johannes Berg To: greearb@candelatech.com, linux-wireless@vger.kernel.org Date: Wed, 04 Oct 2023 21:38:21 +0200 In-Reply-To: <20231003164326.857433-1-greearb@candelatech.com> References: <20231003164326.857433-1-greearb@candelatech.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) MIME-Version: 1.0 X-malware-bazaar: not-scanned X-Spam-Status: No, score=2.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Wed, 04 Oct 2023 12:38:37 -0700 (PDT) X-Spam-Level: ** On Tue, 2023-10-03 at 09:43 -0700, greearb@candelatech.com wrote: > From: Ben Greear >=20 > Check if user has configured STA to be AX mode, and if so, > skip the check for MLD elements (as they would not be needed > in AX mode). Eh, no, I think this is wrong. >=20 > if (ieee80211_vif_is_mld(&sdata->vif)) { If you get past this if, you've (locally) committed to doing EHT already, not just HE (n=C3=A9e 11ax), so should have an EHT connection? Though the change is hard to read - but why are you telling the supplicant to connect with MLO if you wanted to not use EHT? johannes