Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
Message-ID: <2f749ade-7821-00fa-ba34-e2d25cbad441@oracle.com>
Date:   Wed, 4 Oct 2023 22:35:07 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.0
Subject: Re: [PATCH 0/4] tracing: improve symbolic printing
Content-Language: en-GB
To:     Steven Rostedt <rostedt@goodmis.org>,
        Jakub Kicinski <kuba@kernel.org>
Cc:     Johannes Berg <johannes@sipsolutions.net>,
        linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
        netdev@vger.kernel.org, linux-wireless@vger.kernel.org
References: <20230921085129.261556-5-johannes@sipsolutions.net>
 <20231004092205.02c8eb0b@kernel.org>
 <20231004123524.27feeae7@gandalf.local.home>
 <20231004095431.1dd234e6@kernel.org>
 <20231004132955.0fb3893d@gandalf.local.home>
From:   Alan Maguire <alan.maguire@oracle.com>
In-Reply-To: <20231004132955.0fb3893d@gandalf.local.home>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eUFTWjRuRGpjMjdabHdRRU5RV2VFWnlMM0M5YzByMUNvYmFXczhyQ2RHZkZG?=
 =?utf-8?B?NFdLb3ZtcTZFdnZDY2JVSnkzSEhuZEFuamlWZ0tWcHJMUDZBSHJzTDFteTht?=
 =?utf-8?B?RGhPZUF1cXpnVUwyMEhXcy9DNUYxQWZmQXdWV0w4dldIeU1wb2hIOTFINVlM?=
 =?utf-8?B?UWpDRkxTTDJncEpCLzk2NG5ZNXk0NVhLc3NVbGtESnJhSFhWVWVrYUZCUlhl?=
 =?utf-8?B?U1ZVQnlkRCtVOHltdTJjSTI5bnlRVkJab003dG0zaG1qeGE4dXpHbWNuSmxF?=
 =?utf-8?B?MmpnZmt1aTd3UTZIa2wwbzdvQVpyaDhTTVc4ajFSRTdkcEg0cytBN20xSTFV?=
 =?utf-8?B?SFRGUXRwSWt6QlBrRDlyRUFFaUVkQWhNTGhPSG8ySmluUnVHeDRKTDhtMEVT?=
 =?utf-8?B?K2EwL0pYWGZ1THhkQ2g1Rm0xZDNBNDhUSENFOGt3dmxPYUVKNWdWd0xNQ3JU?=
 =?utf-8?B?R2RGVnJvMFFNdEt3Z3JsakVibFNObXZYV1RrM04raVpQT0wvd2pRTmxUWXVv?=
 =?utf-8?B?NmNpMEpjNXh5SlBtaWQ5Ykp5RVl5eVBqNkR5bU1yT3lCOTRkckVRZHFyTmNB?=
 =?utf-8?B?ZVlEcHVBQ1JXcXBSTmRCWGxFaGhsU1RNek5yUnBkZ3BsTEQ1aWZVajQ0V3Bl?=
 =?utf-8?B?MDFnbnFiZFJYTHVqeW1GbXhtS0lFaUV0NWc0bFdGRWZYTHd5OVdCR2hYK244?=
 =?utf-8?B?STREZ3BOWWFIbTBLbjdWNHBlVGtNNHZqbEpGVnJvV3ZqUlF0V3Q0M1RGU0xM?=
 =?utf-8?B?cUUxMTJld2pqeU5GZlZqSWZJSFR5bzF4ekF1SlF6SG5CSi9qMmZtdlBUTTRP?=
 =?utf-8?B?NkZhcnRLbCs0ZUVEdkM3ckd2MWtXT0JRZCsxSkcxVkg0eWR3WWpKam5iVWhE?=
 =?utf-8?B?RS9zeUhRTG5MLzlUUUdoOFlLMERwWmY5YW1NOFRIbUJWM2ZKZlN0NGgvYXVG?=
 =?utf-8?B?TkpZK25jKzRsS2xPTDlid0V5QTVveEVJUXpvS05aenA3a0l6Q3duNjg3dW5U?=
 =?utf-8?B?ZDRzUDEyY3V2akkrOE41VFJqTHl4YWE3OXVMelFzYWw0R2hrUnhuSWhmM3hW?=
 =?utf-8?B?K215WGZSMkVYVkVLQTMyNDE1bmpLMXZhNVlZcUE1emNWYjNiSnhJbVV3L2JC?=
 =?utf-8?B?WWJ5Rk9jL1AzNEVFLzJVWG9NeWVoakxXQjlMQlFJaDU2eVVRSDZDeE9DdXlR?=
 =?utf-8?B?QUlSdmpvdHUwNGVmRnpIK2MvR2tXY0pBZko3aWtTYU1RMUNGbmViSExpTnMr?=
 =?utf-8?B?SW5mVXZOaXp2TTFSTFJYNWlQNEhhTzV5ck9Zb2JYb3ZsZWNYTTVqTlBwdEV4?=
 =?utf-8?B?THZ2bDlTOSt5dDZLQnlDQjZoS3pZb1EwUFVIU2pld3BJaklzOGhHWXU0Y3Zv?=
 =?utf-8?B?QjEzQXo2Vm84MWtOZTZObWNYZzNtaGFpc0hFdk9wb3BDbEhXRFRIUUVWWjJj?=
 =?utf-8?B?ZU04K3EzSGFVUmIzdkl5NncvK1JjRUFCNWU2RFZwVDRvWGFhUEw2elZPaVgv?=
 =?utf-8?B?cFFsOTNoWkRQcEhSWmsyaE1vWSttSlF6YXVTMm1NRHM4TVJxRmxuZ2w1VjJQ?=
 =?utf-8?B?TFM0aWFaSVp5TWF4YzNhQmNEZ2c5eER5MkVqT3ZXUVNuR1JiT0xiUkNhQUYy?=
 =?utf-8?B?NWRjazhoN3pvVlRtdHBkWjRWM3lzaXdGbHpNVzNFOG5VaFZNcmNDL3Rhdjc2?=
 =?utf-8?B?OEhLeGlHUnRNanNZRUV3NEk5bnhRNFhJbklxNVFNQzY0M3RlNVdvMEs4ekVB?=
 =?utf-8?B?V082TnRNUjNVdkJFd3AvUkNjeVNRckRhRkdhMmFyditFNG1GbWRTVldJYjlF?=
 =?utf-8?B?MC9rbWg1dExSTndxNkQyQ2V1Z01MbEFjSlpkUXBrLyszaDgxL1JYbzRiTHhl?=
 =?utf-8?B?d3dISjhIQnpvM2Vhd0RTZUVsbkw1eXo3bVFtZlBjMndKYzl4U2dyTlk4bVp5?=
 =?utf-8?B?RnEzRjNpeVJPeFRQalJrd0JHbjllRzREbnZpK04vZm9lb2NIdDBKdExZdzRm?=
 =?utf-8?B?azh0NHJZV1MxLzVUTEszcXNPeG5oMUFkazc3N3pDYTZzbnl5UUFyUFE0RGMr?=
 =?utf-8?B?RzRPMHBMQUwwZWpiNy9PQk9ZUzBhMzFVMUFnbnNuZ29sNVo1dXZCRGExNnh1?=
 =?utf-8?B?RERhUXFKelI2d2p6RFNpbUZCZGd1ZURvMVgzSk5UZkZiR3JrRkRRVW1wRFVR?=
 =?utf-8?Q?WQEOGGkord2qJIlP5WGvQLI=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: hc7JkF9jeTZzlPo0/x/XIdfu/+gEfJQxnvxTyZd8Tp+4bN3AzEgVOIX7et23Cin7X34NP+PyOyyNiYb0hNr7j2jirWHx1QR31TD612okHtfRh+vLsYVBGA2z8M1PqIDJLMr3In7ZyGsd/OvRPqu/HkRMqmPZ+ZJSxZ0SQU+ouaSay+iMjKL9MUcK8EvxC2XzfMDGFpYEDPnztpU78JszR4pGzsHmqDcYgYLqOA0WmIaYa8asmg47wuh2QORbMicT7S/RFNWRmEapg2r+NaCNiX5O04+LOM74C2aSp9sbgq2isyQQFWiUUD3X+FKjGykOL9U7Ig/bsgUL9YpziqqwQgbySn2ksTe77xlKaF2vCfiFFduXynxvZFPav3fnGeSCuVey5a2qXiPxuFs6lhEjrVQ+fgysc3SgERcbdq2Jvjkp2cfve0Gosfhhzpja0wDGSW1ppI/NCxmA8XawXl9UeJgh3rQO5X35Dzek334GXDq1R+2NPkuz3XCkPj6aKT4JFT/IABeMls44hHytUil37VplTMcnji8zjeQZvhO5GcJzK5L5p9dFYW+pM3G6CaTfHZy/+0k8L8GBKRWx7k1ktw3/yaC5k63WQw/pV7toIXKASNEuipbwO9RBqdmIo4KpfWlyJxp0e4g50sAuME6m5tDwqJoSX+jkV1lQpaS7R8aM8jyGIgYtrqKM96jBRHwJpjmRpOkgJYR7aYPyOs1+zbrfRN+oSA4A81MyzoT9GkO/MUxGrWhaFPh0pAn9sjZth1ETaqSwDsWbMJjjt4ddMakDDMb6nqQDcsnM5xam9ba05TEnFE5mFtNwVlZSEN3eTDn/G+ea58pYRV7ebGxoVMaH6jYclHyj+8tIJrL4DHjiynrsn8Vr1huaoXXvL6av
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1c13e49d-ee23-455e-5123-08dbc521ca6d
X-MS-Exchange-CrossTenant-AuthSource: CH0PR10MB5276.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2023 21:35:12.6551
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: X9BVSaBkdSO1FZ/jkjg5ZfWkKkLZXIenH4InfgHjY6m0T+RH995sKO9y1WRLYs9I5sKFHBzm8NlemEHt5hFlBg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR10MB5570
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-10-04_12,2023-10-02_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxscore=0 bulkscore=0
 adultscore=0 mlxlogscore=999 phishscore=0 spamscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2309180000
 definitions=main-2310040159
X-Proofpoint-GUID: gStLrXP-tQUvgva5tA-0sRmGbkX-kRo7
X-Proofpoint-ORIG-GUID: gStLrXP-tQUvgva5tA-0sRmGbkX-kRo7
X-Spam-Status: No, score=1.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	NICE_REPLY_A,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Wed, 04 Oct 2023 14:35:58 -0700 (PDT)
X-Spam-Level: *

On 04/10/2023 18:29, Steven Rostedt wrote:
> On Wed, 4 Oct 2023 09:54:31 -0700
> Jakub Kicinski <kuba@kernel.org> wrote:
> 
>> On Wed, 4 Oct 2023 12:35:24 -0400 Steven Rostedt wrote:
>>>> Potentially naive question - the trace point holds enum skb_drop_reason.
>>>> The user space can get the names from BTF. Can we not teach user space
>>>> to generically look up names of enums in BTF?    
>>>
>>> That puts a hard requirement to include BTF in builds where it was not
>>> needed before. I really do not want to build with BTF just to get access to
>>> these symbols. And since this is used by the embedded world, and BTF is
>>> extremely bloated, the short answer is "No".  
>>
>> Dunno. BTF is there most of the time. It could make the life of
>> majority of the users far more pleasant.
> 
> BTF isn't there for a lot of developers working in embedded who use this
> code. Most my users that I deal with have minimal environments, so BTF is a
> showstopper.

One thing we've heard from some embedded folks [1] is that having
kernel BTF loadable as a separate module (rather than embedded in
vmlinux) would help, as there are size limits on vmlinux that they can
workaround by having modules on a different partition. We're hoping
to get that working soon. I was wondering if you see other issues around
BTF adoption for embedded systems that we could put on the to-do list?
Not necessarily for this particular use-case (since there are
complications with trace data as you describe), but just trying to make
sure we can remove barriers to BTF adoption where possible.

Thanks!

Alan

[1]
https://lore.kernel.org/bpf/CAHBbfcUkr6fTm2X9GNsFNqV75fTG=aBQXFx_8Ayk+4hk7heB-g@mail.gmail.com/

> 
>>
>> I hope we can at least agree that the current methods of generating 
>> the string arrays at C level are... aesthetically displeasing.
> 
> I don't know, I kinda like it ;-)
> 
> -- Steve
>