Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
Message-ID: <ce2c92ea-9160-f14c-f3e5-aa11edd2e05b@oracle.com>
Date:   Wed, 4 Oct 2023 23:07:34 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.0
Subject: Re: [PATCH 0/4] tracing: improve symbolic printing
Content-Language: en-GB
To:     Steven Rostedt <rostedt@goodmis.org>
Cc:     Jakub Kicinski <kuba@kernel.org>,
        Johannes Berg <johannes@sipsolutions.net>,
        linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
        netdev@vger.kernel.org, linux-wireless@vger.kernel.org
References: <20230921085129.261556-5-johannes@sipsolutions.net>
 <20231004092205.02c8eb0b@kernel.org>
 <20231004123524.27feeae7@gandalf.local.home>
 <20231004095431.1dd234e6@kernel.org>
 <20231004132955.0fb3893d@gandalf.local.home>
 <2f749ade-7821-00fa-ba34-e2d25cbad441@oracle.com>
 <20231004174321.5afa2fb6@gandalf.local.home>
From:   Alan Maguire <alan.maguire@oracle.com>
In-Reply-To: <20231004174321.5afa2fb6@gandalf.local.home>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RHYwMHZWaTV5bytQNVJTdWhkOXlMNmpYbmJ2VGlKM1FGeDV4M0p1NmxXNzJG?=
 =?utf-8?B?L1czMWhSQks4R3NOYkF3R3NJT2hBZm1acjA0dE5tZFRId3dEQVVneG96VEYy?=
 =?utf-8?B?TGpxU2Mzd0g3cXZFUlRwK0l5WHhpeUpDTllNVFNSOE1YZS9UZmRLTFVWdnN3?=
 =?utf-8?B?MVNZSk5WenBiRWpqM2pBQ2pVZDVEcHlNcHk1clhFZ3o1K1RwRkJmS3BzcG5O?=
 =?utf-8?B?YW1SMWZpMjNhZ2JUcUppYmhVWDRzQ2dzUUVyQ1gwSlhXS1FESXRaNTJBOEcy?=
 =?utf-8?B?dkw2LytSRWE0QWhlV3Bxa1lBVU9RSE5tWmE4VjNCWmhRbmNsanB1TjEvSG05?=
 =?utf-8?B?WUVoaCsvelRNK291WWpRaXp4bGRWbXc4WVBwMWdJN2JFRlRUbW1VMWc3Q1hB?=
 =?utf-8?B?S2Ribk4xMjdiRDZ5TUhRcFJOREtHaUhoeGF3NlJ0MVlHNDdRUHBudzlFcU9n?=
 =?utf-8?B?RzZjSWxaU0tyL0IwbXBrTzljaERYYzhDTk8rZ21lZ1ZSbXoyN2Izc0dsUmRX?=
 =?utf-8?B?ZnpnemFHWnE0WVBwTnY5cUozNmhJWis2ODQ2VnAvZVZyRjJIVGZ3bElpTnlI?=
 =?utf-8?B?TTFkZUplWDlrWlEzV1NFWTdyeWwyaElYOTVrQklVVXZFTWUzUjRjS2xjcHVI?=
 =?utf-8?B?eHZyc3dtL0JWQS9HcHQ5b1RRWE9qc0M1czNtdUJETitwcE44UjdoVmJoV0JB?=
 =?utf-8?B?S1JTQlVPNVNGMm84WVNPaEhuZC9WK2JFdzhVT1hKYmFRWHBQTUd3TEZwQnlT?=
 =?utf-8?B?TlVvcUMzNklodGpWZGpsS1gxZTA3bE56MVFtYlVKajNZeWhwU2JKaWI1VUVk?=
 =?utf-8?B?U3ZaN25VS3FWNXNjV3lGOTZ6MWdoZy9pRUlMSmZCVnNoNnR5ZkNmUkxCWEQ5?=
 =?utf-8?B?THlnVCtreTdYZ3Izc2orQzJCYTZDRDkxaTNFU3N5OE4yeDZWTFRyeW5DVVFx?=
 =?utf-8?B?SEhJUTl0aXZyL3ZjU1RTTU9qUEZHNzNzc21kYy92c0tWaTZ0R0dmblZtMGJE?=
 =?utf-8?B?aVNKVms2ZjBNb2FJL21VWE1sODdUUXk1Q2N2TGw0dTVKZ2hoeU9JeSsxZ2Zu?=
 =?utf-8?B?aTVCTmRwNXk4V0tZTks5SkhWZTVZb0EwTHlsb2lsNW5HQmNSNEVNbDBSMTkw?=
 =?utf-8?B?dTN1VStOMmh6QVBLdVM1WlVwdllnUkpRNXRCc0JsdDRkWEhBUWhKSFBoRU55?=
 =?utf-8?B?Vk1ETXorMjV0Sy9vSDE5VWFOczQrL1g3dkdyUnB0VDRicURBWUtJTHUrdDR5?=
 =?utf-8?B?SWk3YWpGL085Vnk0dTFseUNVcVk5Rm5UR2pLUTJXbytHcVMvRmdhQk1ZZnl5?=
 =?utf-8?B?WnVXdjFlbjFPWml5Q0xCcG1QYzliR1hjZ0gwQlBpUUNNWkU0a1pXWWlHSENW?=
 =?utf-8?B?K0N5bzg0d0ZFOE11YXJueS80MTBoOWMvT3NlMUI0bS9zSGlxYTR1RXVKT0tn?=
 =?utf-8?B?MWRGSFRaUTdqQzZqZTlwMWsrWVBjVlRoNjVMTk16M05KQmlkeGYyMFJhdHNp?=
 =?utf-8?B?dTdmd1RqTkVhSm11Yk1sVERKL2J3QnQ0MzNheVhqdlUvMXRSeE9xS0h1WW4v?=
 =?utf-8?B?dVZnWkZtVXB2U0hjN1N1RVc3VE9iYlprc3ZkeFlGeXpCK2hCOEJmdm5WTjlT?=
 =?utf-8?B?TjlTblppWmVVb0NmQVBIbVlqN1VGVjVsRStyenQwMFdocnhRMUE1NnFwUUZZ?=
 =?utf-8?B?UWh4NTh5Y20vLyt3SjA0ZDNOZ1cwRHNwMExPTzFsTloyYVM3ZWVZNUtBc29S?=
 =?utf-8?B?WTJqSm0vWUNDb01EQ2cvTStFVzFLdkFTU3JpbVowTTRSdTRnNlRwN3pZNk9n?=
 =?utf-8?B?cmZSSDh1QllBUHRXMmxwVlh5dFVsWndzZGVONEZhNUZWWkxHWUF3S0M0T0cr?=
 =?utf-8?B?bndxd0hMN0h1MFNhNlFyenBnVlBybTZUeXpMLzlmVmtjTWpMOWNTanNSWkdo?=
 =?utf-8?B?UnFXNFJHMC9qTFQwczQ2a3AwWityaTlKdnUrc3dLN241RkR0aWlBbnZEeXZN?=
 =?utf-8?B?T1NBQWpKUEt4NWJzeFZZWDZHSlhWaFZIUHFhaEVidTJxWG1MS1RrbGZXTGx2?=
 =?utf-8?B?SElsM2c2V2JFS2UrKzR5cFRqVXpNc0ZwOTU4eGRyc1lidGUzVUtPUWRuZytM?=
 =?utf-8?B?YTd4RFNYZ0hSdGd3QWYwR2FpNEZ1RzlkYVRpU1VrYVBSWnAzOHIranlTT1pI?=
 =?utf-8?Q?Kek4Ppnq6LpCim7qYrhwh3M=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: YPWwaAUIUnl1jUV5rJ1zutnMU6rjN/TKajp7EJzkYmx/mzlH8wj7FPyhAmsHDHia4syn57WzGdL2KTFvWTcso7AzhY+dPGplpdTt16pepF/WXEH/9tkxEYhHcq3QGhp5uejKcBFtd1pVnzSF2DvsDoGQ8bEKnIkjZtJmqMhIXmGE6SeIalgGx464+uTawOPOtdrVWxePIauujd3JBsJacXefSBmErzBLEfuB5pAB1s2T+Yl4hhjXSP+ujJWj4VTBFjmQigf6c8v2F+7n9Kcsp94uBVU7/01F255gkdJj2mX8aQ5ty3TZiKwlg+MSjq1Ku2ScOvtL5I7r1BaWv2kxAl2y4dLf2VwK26Dp6mBCHOQZ/xvH3/WqE6l1yn2Kkw9kkBT1tIprioHOVCBXgVIHYBCkCST8d/FdTPUi7tkoD+MGJJGZwo3V1/Lc9zJyfRaNS9mFLCMCbOTjr8DZpEWhvgqfozBCrQY9JPKAKCl56js6YH3ZNFAumsbJlGC6nfQEZ5h/agCj46DqjpRc2VLnfXQUAd54IcF/4H3506UhadiaXub4ft7IpHqPkU4NTCvzfwmBOikcNp318Mb8oFdmiiYHIJBFukyuy+FExQqcUNhXDwnvZ+2N8rvAhLkTEVHAmFtehc79bmL2UyZw3gXVypoVJTCa6G2ysGBFh8FLud/Ibd1EGASLiJgl3pdJA4raOHTboxmTrguZzdrgtln8BTBwPn/ImgLUpdhcwJhxG8qHuAEKAqXjCXzVt9N4ZiTJ5+l5+MzBL9pvyhbbKW7Se6fwSC1eSKMu31RI3OWnSVuZS5IdYh6cyRREbAkHRro1jwGKszU93k3GehCzoXV2oEPCwzcD2b26tYC/jnJe0wimTMTF4kVbZpt7MkTIqzQP
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6d6a28c1-6d1d-4d19-2a73-08dbc5265396
X-MS-Exchange-CrossTenant-AuthSource: CH0PR10MB5276.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2023 22:07:40.7374
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PMR8KVP3ksyPcDU7bu/Zd1cx91gh1UQdQGpclMjEeSGhXmDAv+qZKmHbDszXOrVaX7ydHy3TZ3obMDPASkFeCA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR10MB6786
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-10-04_13,2023-10-02_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxscore=0 bulkscore=0
 adultscore=0 mlxlogscore=928 phishscore=0 spamscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2309180000
 definitions=main-2310040163
X-Proofpoint-ORIG-GUID: UA3ipI0AhHMiyPwC8CCx8ODrh55nf0sk
X-Proofpoint-GUID: UA3ipI0AhHMiyPwC8CCx8ODrh55nf0sk
X-Spam-Status: No, score=1.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	NICE_REPLY_A,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Wed, 04 Oct 2023 15:08:11 -0700 (PDT)
X-Spam-Level: *

On 04/10/2023 22:43, Steven Rostedt wrote:
> On Wed, 4 Oct 2023 22:35:07 +0100
> Alan Maguire <alan.maguire@oracle.com> wrote:
> 
>> One thing we've heard from some embedded folks [1] is that having
>> kernel BTF loadable as a separate module (rather than embedded in
>> vmlinux) would help, as there are size limits on vmlinux that they can
>> workaround by having modules on a different partition. We're hoping
>> to get that working soon. I was wondering if you see other issues around
>> BTF adoption for embedded systems that we could put on the to-do list?
>> Not necessarily for this particular use-case (since there are
>> complications with trace data as you describe), but just trying to make
>> sure we can remove barriers to BTF adoption where possible.
> 
> I wonder how easy is it to create subsets of BTF. For one thing, in the
> future we want to be able to trace the arguments of all functions. That is,
> tracing all functions at the same time (function tracer) and getting the
> arguments within the trace.
> 
> This would only require information about functions and their arguments,
> which would be very useful. Is BTF easy to break apart? That is, just
> generate the information needed for function arguments?
>

There has been a fair bit of effort around this from the userspace side;
the BTF gen efforts were focused around applications carrying the
minimum BTF for their needs, so just the structures needed by the
particular BPF programs rather than the full set of vmlinux structures
for example [1].

Parsing BTF in-kernel to pull out the BTF functions (BTF_KIND_FUNC),
their prototypes (BTF_KIND_FUNC_PROTO) and all associated parameters
would be pretty straightforward I think, especially if you don't need
the structures that are passed via pointers. So if you're starting with
the full BTF, creating a subset for use in tracing would be reasonably
straightforward. My personal preference would always be to have the
full BTF where possible, but if that wasn't feasible on some systems
we'd need to add some options to pahole/libbpf to support such trimming
during the DWARF->BTF translation process.

Alan

[1] https://lore.kernel.org/bpf/20220209222646.348365-7-mauricio@kinvolk.io/

> Note, pretty much all functions do not pass structures by values, and this
> would not need to know the contents of a pointer to a structure. This would
> mean that structure layout information is not needed.
> 
> -- Steve
>