Received: by 2002:a05:7412:518d:b0:e2:908c:2ebd with SMTP id fn13csp366833rdb; Thu, 5 Oct 2023 08:11:22 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE1niV2P+FFNdfhWfmRoTC1dAVjHcnf2a8O1ih6t/OXr5p3PuibhQYAvZ8EgXeaK+edU5Fi X-Received: by 2002:a05:6e02:164b:b0:34a:a4a5:3f93 with SMTP id v11-20020a056e02164b00b0034aa4a53f93mr6718131ilu.5.1696518682427; Thu, 05 Oct 2023 08:11:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696518682; cv=none; d=google.com; s=arc-20160816; b=NhsWjzkAj0WQkmNC90J/GBfisBzibC8SHuULmmsatpm1yRThiD/5BclPpyROTnHia4 VemTuBRVBeo3ca+jX2zlKWFJlWoe0s5hE02nsytOPwU0hsFYpYeRBgB+f5vfZrSyHFnj paMy+NRRwBDJDpVPUcYVG/aXaqIeTVsQk0os7BRm24n72ykGG6yHXHl6v1bqSBtVHSxH /stOAUsOx2OTNVYk1lpGCAAM+ZKAcToJj/3VF98wd9NGsFu4/8knR/leqAWgtNgzulrs UVXXPd1bl2wYtKtMqQ55ZMw9t3v6mZmczd3zFyf2VsYw/zO+ez/rjcH0duY0ONK8X5va xXqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dkim-signature; bh=11/7nuCXMHMIXvKEo2nFS1Hq5wF08NMJolIT0g6K/lc=; fh=1tbBE3EpPPosfWPCisMnsNgV2YvO8ypePlnW2Mh9f2c=; b=pjDoqPPWeTSGym2aO1L2YZR980bjXjZTvEW8TrJWY0NSfySAsNzpO8e/eZ5v5TyBME Jndc/tGq4ph4mcIo76gZzclZCa6+Ys7MvVqjNyAVnoBLzlRxa50Q5QEBaq1lzalvqFUy 3DpxegO+ctgPH8OJS10SEd1tvYx0wdeneXVVhyeJxxCA+yuhP5l5bYH3Tp/IK/FJVXLN JW1uSncAiA7rWz3GU8JsUaO0JQhbuz7jA+619JfCdEmGC5zeNqlN5XrCcAJdAoBArBx1 aDKLQAvaj5T0aTET50/75Z8hskBGJAbXfPyjIBhMbQtiOPX9eEnYNVwzdAKU0kzLl/6X idEg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=sItvzO2q; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from pete.vger.email (pete.vger.email. [2620:137:e000::3:6]) by mx.google.com with ESMTPS id 24-20020a631158000000b0056c2892bfb9si1574037pgr.644.2023.10.05.08.11.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Oct 2023 08:11:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=sItvzO2q; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id A1B9980725BF; Thu, 5 Oct 2023 08:11:19 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230291AbjJEPLC (ORCPT + 52 others); Thu, 5 Oct 2023 11:11:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36002 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231890AbjJEPKI (ORCPT ); Thu, 5 Oct 2023 11:10:08 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AD95E9029 for ; Thu, 5 Oct 2023 07:42:31 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4BE5EC433AB; Thu, 5 Oct 2023 06:24:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1696487063; bh=yzON0/8AzdJNaPS9HT17ZwhuFj1fWIAt4MvZ47s8buw=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=sItvzO2qI36HAyZ/ml0DUgZDqxB5P3WoYpvmYVF+TQnoVwtaSniu/fBPEf9YcLgIj MlWtQN8y8m+uYlZHGrUS9W9CyqM9AeK7w08w0Gp00LFo1VlP+ySoBPQ0Kv4r29mcgH VkLZTHPOupRFiTRGT/dCBJSSSJ7uAoKbeJV6Q1kcEQjpQqzGcifyIBtUuw6r1MNAf6 C7BuxsZb/0QQ8ERyuAthmu/jNrGJm9TlyfVVI2AdIiUL0e2rXzi59y6B/dwja0TREY srC6MwJKnXLoEDu6nSQy8xD8f0Bj8mhVmI7RyS2007V1shs8BTs9ZBki8EfWr9motz 9kZGFmbTWN5ag== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] wifi: ath12k: fix debug messages From: Kalle Valo In-Reply-To: <20231003150132.187875-1-kvalo@kernel.org> References: <20231003150132.187875-1-kvalo@kernel.org> To: Kalle Valo Cc: ath12k@lists.infradead.org, linux-wireless@vger.kernel.org User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.11.2 Message-ID: <169648706024.444191.15030535746469071290.kvalo@kernel.org> Date: Thu, 5 Oct 2023 06:24:22 +0000 (UTC) X-Spam-Status: No, score=-0.1 required=5.0 tests=DATE_IN_PAST_06_12, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Thu, 05 Oct 2023 08:11:19 -0700 (PDT) Kalle Valo wrote: > In ath12k the debug messages were broken, no matter setting what value to the > debug_mask module parameter would not get the debug messages printed. The issue > is that __ath12k_dbg() uses dev_dbg() to print the debug messages which requires either enabling > CONFIG_DYNAMIC_DEBUG or DEBUG symbol in the driver. > > ath12k is supposed to use debug_mask module to control whether debug messages > are printed or not. Using both CONFIG_DYNAMIC_DEBUG and debug_mask parameter > does not make any sense so switch to using dev_printk(), just like ath11k does. > Now it's enough just to debug_mask module parameter to get the debug messages. > > Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1 > > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 453a62a3ee65 wifi: ath12k: fix debug messages -- https://patchwork.kernel.org/project/linux-wireless/patch/20231003150132.187875-1-kvalo@kernel.org/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches