Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Message-ID: <22bc05d3-86e9-4cf6-aec6-10d11df1acc3@infradead.org>
Date:   Sun, 8 Oct 2023 07:08:47 -0700
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [RFC PATCH] ssb: relax SSB_EMBEDDED dependencies
Content-Language: en-US
To:     =?UTF-8?Q?Michael_B=C3=BCsch?= <m@bues.ch>
Cc:     linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org
References: <20231007182443.32300-1-rdunlap@infradead.org>
 <20231008093520.42ead15f@barney>
From:   Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <20231008093520.42ead15f@barney>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 10/8/23 00:35, Michael Büsch wrote:
> Hi Randy,
> 
> thanks for the patch.
> 
> On Sat,  7 Oct 2023 11:24:43 -0700
> Randy Dunlap <rdunlap@infradead.org> wrote:
> 
>> This is a kconfig warning in a randconfig when CONFIG_PCI is not set:
>>
>> WARNING: unmet direct dependencies detected for SSB_EMBEDDED
>>   Depends on [n]: SSB [=y] && SSB_DRIVER_MIPS [=y] &&
>> SSB_PCICORE_HOSTMODE [=n] Selected by [y]:
>>   - BCM47XX_SSB [=y] && BCM47XX [=y]
>>
>> This is caused by arch/mips/bcm47xx/Kconfig's symbol BCM47XX_SSB
>> selecting SSB_EMBEDDED when CONFIG_PCI is not set.
>>
>> This warning can be prevented by having SSB_EMBEDDED not depend on
>> SSB_PCICORE_HOSTMODE, although some parts of SSB use PCI.
> 
>> diff -- a/drivers/ssb/Kconfig b/drivers/ssb/Kconfig
>> --- a/drivers/ssb/Kconfig
>> +++ b/drivers/ssb/Kconfig
>> @@ -134,7 +134,7 @@ config SSB_SFLASH
>>  # Assumption: We are on embedded, if we compile the MIPS core.
>>  config SSB_EMBEDDED
>>  	bool
>> -	depends on SSB_DRIVER_MIPS && SSB_PCICORE_HOSTMODE
>> +	depends on SSB_DRIVER_MIPS
>>  	default y
>>  
>>  config SSB_DRIVER_EXTIF
> 
> Could we instead make SSB_EMBEDDED depend on SSB_PCICORE_HOSTMODE if
> PCI!=n. Wouldn't that also solve the problem?
> 
> I don't fully remember how all this ssb config stuff works, but to
> me adding a PCICORE->PCI dependency sounds safer against build
> regressions in some other configurations.
> 
> What do you think?

I'll test it some and see how it works out.
Thanks.

-- 
~Randy