Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31;
Date:   Mon, 9 Oct 2023 16:07:18 +0700
From:   Bagas Sanjaya <bagasdotme@gmail.com>
To:     Kalle Valo <kvalo@kernel.org>,
        Linux Wireless <linux-wireless@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux Networking <netdev@vger.kernel.org>,
        Linux Broadcom Wireless Development 
        <brcm80211-dev-list.pdl@broadcom.com>,
        SHA-cyfmac-dev-list@infineon.com,
        Linux ath11k <ath11k@lists.infradead.org>
Cc:     Stanislav Yakovlev <stas.yakovlev@gmail.com>,
        Gregory Greenman <gregory.greenman@intel.com>,
        Arend van Spriel <aspriel@gmail.com>,
        Franky Lin <franky.lin@broadcom.com>,
        Hante Meuleman <hante.meuleman@broadcom.com>,
        Jeff Johnson <quic_jjohnson@quicinc.com>,
        Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= <toke@toke.dk>,
        Richard Cochran <richardcochran@gmail.com>,
        Johannes Berg <johannes.berg@intel.com>,
        Miri Korenblit <miriam.rachel.korenblit@intel.com>,
        Avraham Stern <avraham.stern@intel.com>,
        Benjamin Berg <benjamin.berg@intel.com>,
        Mordechay Goodstein <mordechay.goodstein@intel.com>,
        Minsuk Kang <linuxlovemin@yonsei.ac.kr>,
        Ruan Jinjie <ruanjinjie@huawei.com>
Subject: Re: [RFH] wireless-next: fix new W=1 warnings
Message-ID: <ZSPCxkBvFhP17Vhi@debian.me>
References: <87fs2k5l1a.fsf@kernel.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="1p7opZ+xi4xHbBQU"
Content-Disposition: inline
In-Reply-To: <87fs2k5l1a.fsf@kernel.org>
Precedence: bulk


--1p7opZ+xi4xHbBQU
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Oct 09, 2023 at 10:09:53AM +0300, Kalle Valo wrote:
> Hi,
>=20
> During the weekend we updated wireless-next tree from v6.5 to v6.6-rc4+.
> It looks like a new warning was enabled for v6.6 as I see with GCC 13.2
> and W=3D1 several warnings (list below). In v6.5 wireless code was still
> W=3D1 warning free with GCC.

Can you pin-point the exact commit that introduces the warnings?

>=20
> For wireless we get lots of questionable cleanup patches. But actually
> these kind of warnings are what we would prefer to be fixed instead of
> the random churn we always see. Hence I'm sending this Request For Help
> (RFH) in case the cleanup people would fix these. Is there a mailing
> list I should send this to?

[also Cc: maintainers and lists for files below]

>=20
> The sooner these are fixed the better, it makes it difficult for us to
> see any new warnings from this noise.
>=20
> Kalle
>=20
> drivers/net/wireless/intel/ipw2x00/ipw2100.c:5905:63: warning: '%s' direc=
tive output may be truncated writing up to 63 bytes into a region of size 3=
2 [-Wformat-truncation=3D]
> drivers/net/wireless/intel/ipw2x00/ipw2100.c:5905:9: note: 'snprintf' out=
put between 4 and 140 bytes into a destination of size 32
> drivers/net/wireless/intel/ipw2x00/ipw2200.c:10392:63: warning: '%s' dire=
ctive output may be truncated writing up to 63 bytes into a region of size =
32 [-Wformat-truncation=3D]
> drivers/net/wireless/intel/ipw2x00/ipw2200.c:10392:9: note: 'snprintf' ou=
tput between 4 and 98 bytes into a destination of size 32
> drivers/net/wireless/intel/iwlwifi/dvm/main.c:1467:19: warning: '%s' dire=
ctive output may be truncated writing up to 63 bytes into a region of size =
32 [-Wformat-truncation=3D]
> drivers/net/wireless/intel/iwlwifi/dvm/main.c:1465:9: note: 'snprintf' ou=
tput between 1 and 64 bytes into a destination of size 32
> drivers/net/wireless/intel/iwlwifi/mvm/ops.c:1307:19: warning: '%s' direc=
tive output may be truncated writing up to 63 bytes into a region of size 3=
2 [-Wformat-truncation=3D]
> drivers/net/wireless/intel/iwlwifi/mvm/ops.c:1305:9: note: 'snprintf' out=
put between 1 and 64 bytes into a destination of size 32
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c:262:52: warni=
ng: '%d' directive output may be truncated writing between 1 and 5 bytes in=
to a region of size 4 [-Wformat-truncation=3D]
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c:262:46: note:=
 directive argument in the range [0, 65535]
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c:262:46: note:=
 directive argument in the range [0, 65535]
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c:262:9: note: =
'snprintf' output between 9 and 17 bytes into a destination of size 9
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c:265:55: warni=
ng: '%d' directive output may be truncated writing between 1 and 5 bytes in=
to a region of size 4 [-Wformat-truncation=3D]
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c:265:48: note:=
 directive argument in the range [0, 65535]
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c:265:48: note:=
 directive argument in the range [0, 65535]
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c:265:9: note: =
'snprintf' output between 10 and 18 bytes into a destination of size 10
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c:342:50: warni=
ng: '/' directive output may be truncated writing 1 byte into a region of s=
ize between 0 and 4 [-Wformat-truncation=3D]
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c:342:42: note:=
 directive argument in the range [0, 65535]
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c:342:9: note: =
'snprintf' output between 10 and 18 bytes into a destination of size 10
> drivers/net/wireless/intel/iwlwifi/iwl-drv.c:549:33: warning: '%s' direct=
ive output may be truncated writing up to 63 bytes into a region of size be=
tween 48 and 56 [-Wformat-truncation=3D]
> drivers/net/wireless/intel/iwlwifi/iwl-drv.c:547:9: note: 'snprintf' outp=
ut 9 or more bytes (assuming 80) into a destination of size 64
> drivers/net/wireless/intel/iwlwifi/iwl-drv.c:729:33: warning: '%s' direct=
ive output may be truncated writing up to 63 bytes into a region of size be=
tween 48 and 56 [-Wformat-truncation=3D]
> drivers/net/wireless/intel/iwlwifi/iwl-drv.c:727:9: note: 'snprintf' outp=
ut 9 or more bytes (assuming 80) into a destination of size 64
> drivers/net/wireless/intel/iwlwifi/iwl-drv.c:989:51: warning: '%s' direct=
ive output may be truncated writing up to 63 bytes into a region of size be=
tween 46 and 58 [-Wformat-truncation=3D]
> drivers/net/wireless/intel/iwlwifi/iwl-drv.c:987:33: note: 'snprintf' out=
put between 7 and 82 bytes into a destination of size 64
> drivers/net/wireless/intel/iwlwifi/iwl-drv.c:984:53: warning: '%s' direct=
ive output may be truncated writing up to 63 bytes into a region of size be=
tween 40 and 50 [-Wformat-truncation=3D]
> drivers/net/wireless/intel/iwlwifi/iwl-drv.c:982:33: note: 'snprintf' out=
put between 15 and 88 bytes into a destination of size 64
> drivers/net/wireless/ath/ath11k/debugfs.c:1597:51: warning: '%d' directiv=
e output may be truncated writing between 1 and 3 bytes into a region of si=
ze 2 [-Wformat-truncation=3D]
> drivers/net/wireless/ath/ath11k/debugfs.c:1597:48: note: directive argume=
nt in the range [0, 255]
> drivers/net/wireless/ath/ath11k/debugfs.c:1597:9: note: 'snprintf' output=
 between 5 and 7 bytes into a destination of size 5
> drivers/net/wireless/ath/ath9k/hif_usb.c:1223:42: warning: '.0.fw' direct=
ive output may be truncated writing 5 bytes into a region of size between 4=
 and 11 [-Wformat-truncation=3D]
> drivers/net/wireless/ath/ath9k/hif_usb.c:1222:17: note: 'snprintf' output=
 between 27 and 34 bytes into a destination of size 32

There is only one commit touching above files in current cycle, that is b2f=
d72aafb1311 ("wifi: ath9k: Remove unnecessary ternary operators").

That's what I know.

--=20
An old man doll... just what I always wanted! - Clara

--1p7opZ+xi4xHbBQU
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQSSYQ6Cy7oyFNCHrUH2uYlJVVFOowUCZSPCwgAKCRD2uYlJVVFO
o8ymAP9LMTtr8chruIr3qE2uP9kaN+rd6CgxbH302q7bheYt4AEA9zEHmUbTdBFW
CobVmnhLh1HJoVKvdsCEaezhwRnETQM=
=IWi4
-----END PGP SIGNATURE-----

--1p7opZ+xi4xHbBQU--