Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
From:   Kalle Valo <kvalo@kernel.org>
To:     Johannes Berg <johannes@sipsolutions.net>
Cc:     linux-wireless@vger.kernel.org
Subject: Re: [PATCH] wifi: cfg80211: use system_unbound_wq for wiphy work
References: <20231009101800.bb75408bf635.I6528d97e24b3da36cdf633b4738327d77c7276f2@changeid>
Date:   Mon, 09 Oct 2023 12:18:57 +0300
In-Reply-To: <20231009101800.bb75408bf635.I6528d97e24b3da36cdf633b4738327d77c7276f2@changeid>
        (Johannes Berg's message of "Mon, 9 Oct 2023 10:18:01 +0200")
Message-ID: <87bkd85f26.fsf@kernel.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Johannes Berg <johannes@sipsolutions.net> writes:

> From: Johannes Berg <johannes.berg@intel.com>
>
> Since wiphy work items can run pretty much arbitrary
> code in the stack/driver, it can take longer to run
> all of this, so we shouldn't be using system_wq via
> schedule_work(). Also, we lock the wiphy (which is
> the reason this exists), so use system_unbound_wq.
>
> Reported-by: Kalle Valo <kvalo@kernel.org>
> Fixes: a3ee4dc84c4e ("wifi: cfg80211: add a work abstraction with special semantics")
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>

Thanks!

So the background of this is that I enabled
CONFIG_WQ_CPU_INTENSIVE_REPORT on my ath11k test box and saw:

[  290.475631] workqueue: cfg80211_wiphy_work [cfg80211] hogged CPU for >10000us 4 times, consider switching to WQ_UNBOUND

With Johannes' patch I don't see it anymore so:

Tested-by: Kalle Valo <kvalo@kernel.org>

I do see one other warning about gc_worker but that's from netfilter and
nothing to do with wireless:

[  440.486683] workqueue: gc_worker hogged CPU for >10000us 128 times, consider switching to WQ_UNBOUND

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches