Received: by 2002:a05:7412:da14:b0:e2:908c:2ebd with SMTP id fe20csp2317505rdb; Mon, 9 Oct 2023 23:17:45 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF1rr9DGumShkHwvJNKzRCNefk6cpsP4l/e+ed8WJbPkZYbte48I8FYkUF/ViSt+z9JoIdZ X-Received: by 2002:a05:6808:2003:b0:3ab:5e9e:5206 with SMTP id q3-20020a056808200300b003ab5e9e5206mr24189266oiw.5.1696918665700; Mon, 09 Oct 2023 23:17:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696918665; cv=none; d=google.com; s=arc-20160816; b=vFXGxTVlEfGnryDj5TWA4LEjGLLxUawHjWAghd61Ww89TiEa8sBj6wE4CNRzS/7NRf T4Mb251sYM0cL5a5ZMIBfdFiEEUkelsuDiShGQgMmfa9Uk+9uMGq9i4e68INrVSSdF5o fsSC/K9JAJU/WtHVYR63fuX0FTbeIfVDD9rYaJ9XOYRkf9Ia7gZyxNeIkEX/8qo/Yu8H n+/rhB5GmcdbAD0rX62hbONq30Vtd+a0wzuKtEn4Ejtg0hFyygNh6Oay0nDkrTDIVmsN 8vFEEaVpEjtj1ZF9Ay0B15DzOipQt4cSioug+Qu1Htfa7px9XiEK7TvUt+MIuW4ANZCK fRfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:message-id:in-reply-to :date:references:subject:cc:to:from:dkim-signature; bh=OxgaPjzzYNVVyQGkSJgTCtBZPuwGdhQGeAV5wCYi+9Q=; fh=5kGccZ4FWPgiNOnOYsnD0CEklqIDMZYQ6BBWaLh+W08=; b=zLxFl4cd7kpPHYK9+LRV6Rl4473XFFYJc7i7yQKXi8T4DkD/4ePf+9Up9PO2FoE05g Cvpmu9eA0qv5sr33dyDmiL8HEbwK9zad/4WoRN/dKNRukukwlzbvYJI0TjVXmy65D0wx DYiHzyRoySilBY/1iV1N+Fc9AfZcITtAbEoKIZbqJJyXYVX+P55YNzVcHHu7fTfu1w+T JxfNRYIuF+iwmvTw5qxiQbQCbmsU4kgKM/5HHrrm1GVjFQ4L9Yyt525/i+3s7kGkFHIZ 2/LpFH21e6awTgjd5blT6mfpI+wu4SG3iiSmyQMJ83LldXSyij61P83BLtXGhV5w48OJ Xwtg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=OaW38fiW; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id i189-20020a639dc6000000b0056c4189d6cbsi9397507pgd.171.2023.10.09.23.17.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Oct 2023 23:17:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=OaW38fiW; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 7298B8026AC2; Mon, 9 Oct 2023 23:17:41 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1442213AbjJJGRk (ORCPT + 52 others); Tue, 10 Oct 2023 02:17:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50186 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1442183AbjJJGRj (ORCPT ); Tue, 10 Oct 2023 02:17:39 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9568E9D; Mon, 9 Oct 2023 23:17:38 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D2197C433C8; Tue, 10 Oct 2023 06:17:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1696918658; bh=h9CQdICcdTHsa/KeLMNYowXLwDNi+8QMgSiaxa80wo4=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=OaW38fiWbCpjKJ29idyZEI7/RIt1LUKvUgreoSf6oZilIa4q8T8h72Y+V0h7I37zM LLsP9YrEXsxMay67paITpYl/Ub626lejzaDLtfiy0NrlIVMxzmrKpO7KQwg4kICxov UH2l6a2EOaVI7wR37HfAy68QjwIpFmIDhE27dec2C4510HQm/W/AO6r1Ba3W7qZ2a1 6RxxvBN+tn+EbaSorn/135go0Mtzq7ki+5YUal576uhp26B/MA9f1H5DkaZ7Tfrodn 5VVUYPtL+XnINVnHuVA2ZU40yqp/oArel3qTXsTUYjhmECkAywYLSrio0UuuVwSCt0 65KoGNTBklfGA== From: Kalle Valo To: Kees Cook Cc: "Gustavo A. R. Silva" , "Gustavo A. R. Silva" , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH][next] hostap: Add __counted_by for struct prism2_download_data and use struct_size() References: <202310091253.665A9C9@keescook> <169f782e-9cc4-49bc-9618-ca6acc526e37@embeddedor.com> <202310091341.74A2D82BB@keescook> Date: Tue, 10 Oct 2023 09:17:34 +0300 In-Reply-To: <202310091341.74A2D82BB@keescook> (Kees Cook's message of "Mon, 9 Oct 2023 13:42:12 -0700") Message-ID: <877cnv57cx.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=2.4 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Mon, 09 Oct 2023 23:17:41 -0700 (PDT) X-Spam-Level: ** Kees Cook writes: >> > Should this be considered a v2 of: >> > https://lore.kernel.org/linux-hardening/94848cc3-6f5c-46d7-8cc7-98a4f10865b3@embeddedor.com/ >> > >> > ? >> >> Oops... sorry, I forgot I had reviewed this patch of yours. >> >> > >> > Yours is more complete since it includes the struct_size() change... >> > >> >> Should I resend this explicitly marking it as a v2? > > I defer to Kalle -- your Subject is more accurate, so perhaps let's just > let this stand? No need to resend. I marked Kees' version as Superseded so that I don't accidentally take the wrong version. In the title "wifi:" is missing but I can add that during commit. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches