Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
From:   Ping-Ke Shih <pkshih@realtek.com>
To:     Kalle Valo <kvalo@kernel.org>
CC:     "johannes@sipsolutions.net" <johannes@sipsolutions.net>,
        "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: RE: [PATCH v2 5/6] wifi: radiotap: add bandwidth definition of EHT U-SIG
Thread-Topic: [PATCH v2 5/6] wifi: radiotap: add bandwidth definition of EHT
 U-SIG
Thread-Index: AQHZ+x8BqZDTAYUsIky6kUQhKtEGKrBCjWh0gAE2/MA=
Date:   Wed, 11 Oct 2023 00:54:37 +0000
Message-ID: <6aa9a4e673004fe3b56755b93422dd29@realtek.com>
References: <20231010021006.6061-1-pkshih@realtek.com>
        <20231010021006.6061-6-pkshih@realtek.com> <8734yj578s.fsf@kernel.org>
In-Reply-To: <8734yj578s.fsf@kernel.org>
Accept-Language: en-US, zh-TW
Content-Language: zh-TW
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Precedence: bulk


> -----Original Message-----
> From: Kalle Valo <kvalo@kernel.org>
> Sent: Tuesday, October 10, 2023 2:20 PM
> To: Ping-Ke Shih <pkshih@realtek.com>
> Cc: johannes@sipsolutions.net; linux-wireless@vger.kernel.org
> Subject: Re: [PATCH v2 5/6] wifi: radiotap: add bandwidth definition of EHT U-SIG
> 
> Ping-Ke Shih <pkshih@realtek.com> writes:
> 
> > Define EHT U-SIG bandwidth used by radiotap according to Table 36-28
> > "U-SIG field of an EHT MU PPDU" in 802.11be (D3.0).
> >
> > Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
> > ---
> > v2:
> >   - correct commit message about the source of bandwidth definition
> >     of EHT U-SIG suggested by Johannes
> > ---
> >  include/net/ieee80211_radiotap.h | 6 ++++++
> >  1 file changed, 6 insertions(+)
> 
> This is nitpicking but in general it's good to have the patches touching
> files outside of drivers/net/wireless in the beginning of the patchset
> to make them more visible. No need to resend because of this, just a
> small tip.
> 

Got it. I will pay attention to it next time. 

Ping-Ke