Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp508701rdg; Tue, 10 Oct 2023 18:05:23 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGI0HE8GgM9+8YwvYhKg3BR2kBTIOn66TaZnzsSjb8cZ/vKl1kLgB9AgWLVjN6KFntOdIJB X-Received: by 2002:a05:6870:5387:b0:1bb:8333:ab8a with SMTP id h7-20020a056870538700b001bb8333ab8amr23993028oan.4.1696986323563; Tue, 10 Oct 2023 18:05:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696986323; cv=none; d=google.com; s=arc-20160816; b=B1HLLYqQWnJdMUwlSQrDWeSfxVOd9R3aJv5MNDgUQnGeaI+8CYCH9gAIuiIYxhTcgp yh6y4ktPIJ08n+sjkyQ4q+FuBsIpVVs/ndtr6/OnqC91HOfWFhcD4B+JsUGS/cjD31Vt aKFjPDoZxyBJeFCKM7c2MiB6sfvrwmbDk1xEWWuL8NNi5NRkdPzSl/rkAmr4cOOPJTRx /fMMgXr82nzlSZCpi6bq1imHBpO/M/nXCTq1bvnr2l0qqZxwtAdwOaSggbembfysydIP 2C4cHhbghZSRU5M4EkOtqbTbvX6PV90Mz2t6/KHeb6wkgP/ggSHJIb+jOFXkFjZ2hNH6 PtEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :content-language:accept-language:in-reply-to:references:message-id :date:thread-index:thread-topic:subject:to:from; bh=w4NagCyxeFmq2cntRL29vnHn8ZsY0rRnJE7niwEDXhc=; fh=mphlHao5rwqTy8bE+BgRiwwROLs9i6zUgEsqZSAiOqw=; b=lUth871m6TGvzE8VR9hIsEWMOU+mFcUNlVJupxMxbr29gp7aGV5u0VZ/irUfp0wgMb hFwrriBf784YpYoTpDMIRBHzmxNUWx7SuoSgQQlM6khiMN6jVG2RvfOZ3nxqPjlYOYBP 6M07r6Q3fQTmnde/4sAYBy6wHjaB5g3ILY0E2gr1DA6u8E94OymyuwnDMCLHCUjIDDGj Xmx0Qi2C2rmK/5018nFdvc0Aa+S8rfzFG8KXw/J5AUJHqnFGl6oVZZFET8btmGD9XyRR 01cmS+Rt9MKXvzv20uTts1MdftsgNg7eG1GvOTxkRW3DcgrLZwFNDuZ21c5EOs5VDfVS g3Zw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from fry.vger.email (fry.vger.email. [23.128.96.38]) by mx.google.com with ESMTPS id v189-20020a6389c6000000b00577d99bd045si13034887pgd.843.2023.10.10.18.05.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Oct 2023 18:05:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id CF6C982DEE44; Tue, 10 Oct 2023 18:05:19 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344469AbjJKBFT convert rfc822-to-8bit (ORCPT + 52 others); Tue, 10 Oct 2023 21:05:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50912 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343612AbjJKBFS (ORCPT ); Tue, 10 Oct 2023 21:05:18 -0400 Received: from rtits2.realtek.com.tw (rtits2.realtek.com [211.75.126.72]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E1A7E92 for ; Tue, 10 Oct 2023 18:05:16 -0700 (PDT) X-SpamFilter-By: ArmorX SpamTrap 5.78 with qID 39B13rWF23233580, This message is accepted by code: ctloc85258 Received: from mail.realtek.com (rtexh36505.realtek.com.tw[172.21.6.25]) by rtits2.realtek.com.tw (8.15.2/2.92/5.92) with ESMTPS id 39B13rWF23233580 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 11 Oct 2023 09:03:53 +0800 Received: from RTEXMBS02.realtek.com.tw (172.21.6.95) by RTEXH36505.realtek.com.tw (172.21.6.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.32; Wed, 11 Oct 2023 09:03:54 +0800 Received: from RTEXMBS04.realtek.com.tw (172.21.6.97) by RTEXMBS02.realtek.com.tw (172.21.6.95) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.7; Wed, 11 Oct 2023 09:03:53 +0800 Received: from RTEXMBS04.realtek.com.tw ([fe80::40c2:6c24:2df4:e6c7]) by RTEXMBS04.realtek.com.tw ([fe80::40c2:6c24:2df4:e6c7%5]) with mapi id 15.01.2375.007; Wed, 11 Oct 2023 09:03:53 +0800 From: Ping-Ke Shih To: Jinjie Ruan , "linux-wireless@vger.kernel.org" , Kalle Valo , neo_jou , Sascha Hauer , Hans Ulli Kroll Subject: RE: [PATCH] wifi: rtw88: Remove duplicate NULL check before calling usb_kill/free_urb() Thread-Topic: [PATCH] wifi: rtw88: Remove duplicate NULL check before calling usb_kill/free_urb() Thread-Index: AQHZ+ZN3js7IFeq3f0St41aqKB+9S7BDyljA Date: Wed, 11 Oct 2023 01:03:53 +0000 Message-ID: <0c513b55a4db45a29d0ae4e7f80b0b66@realtek.com> References: <20231008025852.1239450-1-ruanjinjie@huawei.com> In-Reply-To: <20231008025852.1239450-1-ruanjinjie@huawei.com> Accept-Language: en-US, zh-TW Content-Language: zh-TW x-originating-ip: [172.21.69.25] x-kse-serverinfo: RTEXMBS02.realtek.com.tw, 9 x-kse-antispam-interceptor-info: fallback x-kse-antivirus-interceptor-info: fallback Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-KSE-AntiSpam-Interceptor-Info: fallback X-KSE-ServerInfo: RTEXH36505.realtek.com.tw, 9 X-KSE-AntiSpam-Interceptor-Info: fallback X-KSE-Antivirus-Interceptor-Info: fallback X-KSE-AntiSpam-Interceptor-Info: fallback X-Spam-Status: No, score=2.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Tue, 10 Oct 2023 18:05:20 -0700 (PDT) X-Spam-Level: ** > -----Original Message----- > From: Jinjie Ruan > Sent: Sunday, October 8, 2023 10:59 AM > To: linux-wireless@vger.kernel.org; Ping-Ke Shih ; Kalle Valo ; > neo_jou ; Sascha Hauer ; Hans Ulli Kroll > > Cc: ruanjinjie@huawei.com > Subject: [PATCH] wifi: rtw88: Remove duplicate NULL check before calling usb_kill/free_urb() > > Both usb_kill_urb() and usb_free_urb() do the NULL check itself, so there > is no need to duplicate it prior to calling. > > Fixes: a82dfd33d123 ("wifi: rtw88: Add common USB chip support") > Signed-off-by: Jinjie Ruan Acked-by: Ping-Ke Shih