Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp667110rdg; Wed, 11 Oct 2023 01:55:52 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGnp1716Csv5oiyl/DJuPcFG0Dv6u1c/f7eWh5e38tQz3X56G1Zadc6wdxK27LRVo21VN/2 X-Received: by 2002:a9d:7751:0:b0:6b9:ba85:a5fa with SMTP id t17-20020a9d7751000000b006b9ba85a5famr23846597otl.5.1697014552211; Wed, 11 Oct 2023 01:55:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697014552; cv=none; d=google.com; s=arc-20160816; b=rS3eRPBfAq7waNHKW9S7DJU59H2r2QcqKb7uNRaK4NYFSoqsOaa04uMsmXcEZp2NXt XTrkkvseytn2951m2dHKqispS5lRB0TebuS0MfNySVpk37KLmqdX6Na8RHzaonVB9ah6 MA4JL340tOCZGTMCEaebLl4sgo5wnJwa0cXahRJGlirE3Vc8n1t/C2f7VixKH+OC7bwr ay6BS4oI5uE81HI0f97KPN8AWxP9P3cZPsi6Nt7WUvkeAW2KV7a3AVT6BKsDwEECSkpE rY/lhcvMHqaHgs6WdDAeFCe7ifr55Yj7Hh0/j0kbGIRkMCQZyAtBs5kw5qo7nORch0XF wSRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:message-id:in-reply-to :date:references:subject:cc:to:from:dkim-signature; bh=OWyG5Dan50ZsK4Gc5FycCWV0sPbbpPuZC9axXFmsMZo=; fh=GZrydPkV7PRMCNJic3f0snDIlVuhrqSIddMnD52kddo=; b=F57PXLMvJSpSfXtdmnuUyYntAFenmunG5ajq+zYywPR5FsQ3Hg9z2NZRuDW3XF9p23 MMqQmToKpqpTYrX3COLliLz6uGDja63dP6em3udvF3mkZnpcD+uvQ0IBM/xLFJDLBPqE QQ1ue3Ea0YRBumPA4KAi3kqFODAiwTkfMbHAKlf/Sy4Eud3a/hFxiqHjpTfxsTGwVrnd 8M9Uy5u7D0EOH+zvQKo3HG/eFjrS9Vzfo53kanDOgbrlfaDNmqTvk/ZT8mBcACO83ivD V7V/4yJmlFbhAyrz60M/aynh+8+hWftXEVbZhqQ2/1qebNGKURyPOe+pC+g7ed6gOhod CcQw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=S36I6tTL; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from morse.vger.email (morse.vger.email. [2620:137:e000::3:1]) by mx.google.com with ESMTPS id l128-20020a633e86000000b00578b487825asi14399296pga.208.2023.10.11.01.55.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Oct 2023 01:55:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=S36I6tTL; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 2CE23833AB19; Wed, 11 Oct 2023 01:55:48 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345054AbjJKIzq (ORCPT + 52 others); Wed, 11 Oct 2023 04:55:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39856 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230256AbjJKIzq (ORCPT ); Wed, 11 Oct 2023 04:55:46 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2617294; Wed, 11 Oct 2023 01:55:45 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9DF52C433C7; Wed, 11 Oct 2023 08:55:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697014544; bh=ypmKXRXN1bDbe6BFnY52JOMJEHn4p1Ml9jjg3Cls6yQ=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=S36I6tTLRNWWOyYJERZnEvDfdRdM5VZ2cY4TzOEtzhPF1BK1XQnusUKKdgYtXNYtF EYOKfZV6P6Y87HZ0Ol7jRG/4flF4wl9ah7+cZQjoctR+qT9L3LLTN+WN8RICEhgCGH G4r8vbPwdi8tm6fEv35Q7FtIy/m68ZfEocHGrQsyxUj5+ZrvFkQN6yOR69hd+ETv+w vik3NwzMmxk7CPqFjrZgYZKQwUh6TwnuCR19sBsk5veZMEf8IZ/NJdwOX8Qukhn5b3 MttLjUgBZVrE1ihjmfpoDcvNSGaYtG8+FwQeP8vfVPnG8AiECFVzXiW/IcwHuZr3B5 b8JQoJZmsIDKw== From: Kalle Valo To: Ma Ke Cc: quic_jjohnson@quicinc.com, ath12k@lists.infradead.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] wifi: ath12k: call ath12k_mac_fils_discovery() without condition References: <20231011072950.4097927-1-make_ruc2021@163.com> Date: Wed, 11 Oct 2023 11:55:41 +0300 In-Reply-To: <20231011072950.4097927-1-make_ruc2021@163.com> (Ma Ke's message of "Wed, 11 Oct 2023 15:29:50 +0800") Message-ID: <87mswp4jxu.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=2.4 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Wed, 11 Oct 2023 01:55:48 -0700 (PDT) X-Spam-Level: ** Ma Ke writes: > Mac80211 does not set flags BSS_CHANGED_FILS_DISCOVERY and > BSS_CHANGED_UNSOL_BCAST_PROBE_RESP if there are no updates to > FILS discovery and unsolicited broadcast probe response transmission > configurations respectively. This results in the transmissions getting > stopped during BSS change operations which do not include these > attributes. Remove the checks for the flags and always send the existing > configuration to firmware. > > Signed-off-by: Ma Ke This looks almost identical to Aloka's patch: wifi: ath12k: call ath12k_mac_fils_discovery() without condition https://git.kernel.org/netdev/net-next/c/43a10990404f What's happening here? -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches