Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp677202rdg; Wed, 11 Oct 2023 02:18:13 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFq04tZDH5brXgNCweUOT+wzZKFHM9kCOtykE3vfH1lj6YjJoxIyucc8ah5qcfZ7+F3lq16 X-Received: by 2002:a05:6358:921:b0:130:e0a9:a7b4 with SMTP id r33-20020a056358092100b00130e0a9a7b4mr25293415rwi.13.1697015893635; Wed, 11 Oct 2023 02:18:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697015893; cv=none; d=google.com; s=arc-20160816; b=SpWPJX1EtPCk17kWEL8H0sk6gXNn1c1gl/24dHRGhdblVuTWhhcqMwFcTtMb8iZAzZ CUslJ0yap6hpVN+CNbQ87jiEIbW3NECd0kHduY402JZ0FQA5yzyHCshB9s8vAgAZoOAC /Hiv+Y2oND/0/UD9E4lvtfz1XMN+QUH9hRYNFmWwGYEKGm/6C8bhaN9Z8wzbWaIt0nyK Fn9Q9aoE3a4pPAnF2eaL+X6CL1wub2j1PyGQjxnJ8UaljC5xE8ggL6RwZdscZUIz1aik GCplzLeLt8rXpzuySqoheLQv2ZZLgC18ZnjNbPyfhsWAeJUr9/k+qAZD4ta4+/8Zsoft XWMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dkim-signature; bh=hz0q088z76QrXx93t1dZDjsbnvANs5yq53QfNLrH/s4=; fh=3ZNqbQUhBzq49XfBZ7IdnPswz0zef7ymDG87FcCSbEU=; b=Ciet17YTIiffgTw7mkH+9XGtWbciK7wFOTmlQdwywohvrlNLiELeszt49HA6nOPVTu 5MqD75dKYbkq8bPJ011wlTETFeSnX1Uwudr6fKPCEiulk53X0xhrt0J5yx3FLQswh/lK G5ut3dES2jnoJGpeAY4oDsbr1aBKouKyOZkyWx5nnue/sj9vsULcfdJ9q210Q8JMfHK+ algPdxmaPuSjbx4MykVkbfqNKddahhuUti4YlIpiu/PyhntxB05bOiEHu22O8nbEl/xD 0y8A323or9+FQHcYdxxXGqrRK1TDz0/Z299IcDfDhd/gGeKXVjck4H/sGKcmYNi1sS4y xYLA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Q2qozJlg; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from howler.vger.email (howler.vger.email. [23.128.96.34]) by mx.google.com with ESMTPS id ea12-20020a056a004c0c00b0069025078128si11679657pfb.240.2023.10.11.02.18.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Oct 2023 02:18:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Q2qozJlg; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 08AD08022AA9; Wed, 11 Oct 2023 02:18:09 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344899AbjJKJSH (ORCPT + 52 others); Wed, 11 Oct 2023 05:18:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44526 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230392AbjJKJSH (ORCPT ); Wed, 11 Oct 2023 05:18:07 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6378191 for ; Wed, 11 Oct 2023 02:18:05 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8761CC433CB; Wed, 11 Oct 2023 09:18:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697015885; bh=Z/W/TCU7A9cONG6bvKZER6FKS9MWUsG7YsU+cspr+lo=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=Q2qozJlgovs6tEG94YsKvDcNPtpJhKGlIHR6AUTRz71+64DsVNNTjUeX4QHunofiH lVvCiI3IhnIxTdtjsyLS9CiCwIFnMcgoAqtHKMDrIEkHCRrB1dxNGdKMAWK+znuckI yvPc/ieGzFETQs+6wIJmlvMsu87BftTxqtt+9sLF7+X6bzActm/wOZbnQKcx97eZps D0sEsP74WK9EdvOo/Pucnwskzbk3oxr9v4kVHr3saJaFaYwPS2W5BVfZCyqsX0B+oI K7MqFIM47m6WXQqiLWL+sMGq3mys9jXwDvpooaEGhXtdRcTo9OFQ/nPUy0LvbZjF/C DVYeX+vrzNZkQ== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] wifi: rtw88: Remove duplicate NULL check before calling usb_kill/free_urb() From: Kalle Valo In-Reply-To: <20231008025852.1239450-1-ruanjinjie@huawei.com> References: <20231008025852.1239450-1-ruanjinjie@huawei.com> To: Jinjie Ruan Cc: , Ping-Ke Shih , neo_jou , Sascha Hauer , Hans Ulli Kroll , User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.11.2 Message-ID: <169701588177.2760941.7597653842457844227.kvalo@kernel.org> Date: Wed, 11 Oct 2023 09:18:03 +0000 (UTC) X-Spam-Status: No, score=2.4 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Wed, 11 Oct 2023 02:18:09 -0700 (PDT) X-Spam-Level: ** Jinjie Ruan wrote: > Both usb_kill_urb() and usb_free_urb() do the NULL check itself, so there > is no need to duplicate it prior to calling. > > Fixes: a82dfd33d123 ("wifi: rtw88: Add common USB chip support") > Signed-off-by: Jinjie Ruan > Acked-by: Sascha Hauer > Acked-by: Ping-Ke Shih Patch applied to wireless-next.git, thanks. de8dd0969498 wifi: rtw88: Remove duplicate NULL check before calling usb_kill/free_urb() -- https://patchwork.kernel.org/project/linux-wireless/patch/20231008025852.1239450-1-ruanjinjie@huawei.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches