Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1;
Date:   Wed, 11 Oct 2023 08:54:00 -0700
From:   Kees Cook <keescook@chromium.org>
To:     Ping-Ke Shih <pkshih@realtek.com>
Cc:     kvalo@kernel.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 2/2] wifi: rtw89: coex: add annotation __counted_by() to
 struct rtw89_btc_btf_set_mon_reg
Message-ID: <202310110853.681C3AB65C@keescook>
References: <20231011063725.25276-1-pkshih@realtek.com>
 <20231011063725.25276-2-pkshih@realtek.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231011063725.25276-2-pkshih@realtek.com>
Precedence: bulk

On Wed, Oct 11, 2023 at 02:37:25PM +0800, Ping-Ke Shih wrote:
> Prepare for the coming implementation by GCC and Clang of the __counted_by
> attribute. Flexible array members annotated with __counted_by can have
> their accesses bounds-checked at run-time via CONFIG_UBSAN_BOUNDS (for
> array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
> functions).
> 
> Use struct_size() and flex_array_size() helpers to calculate proper sizes
> for allocation and memcpy().
> 
> Don't change logic at all, and result is identical as before.
> 
> Cc: Kees Cook <keescook@chromium.org>
> Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>

Looks good too. Thanks!

Reviewed-by: Kees Cook <keescook@chromium.org>

-- 
Kees Cook