Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
Message-ID: <13eeb01a-2f4f-4c8e-b097-6e80d822862b@infradead.org>
Date:   Wed, 11 Oct 2023 20:44:49 -0700
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [RFC PATCH] ssb: relax SSB_EMBEDDED dependencies
Content-Language: en-US
To:     =?UTF-8?Q?Michael_B=C3=BCsch?= <m@bues.ch>
Cc:     linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org
References: <20231007182443.32300-1-rdunlap@infradead.org>
 <20231008093520.42ead15f@barney>
 <22bc05d3-86e9-4cf6-aec6-10d11df1acc3@infradead.org>
 <e551fb4c-1e3d-4e1a-a465-5b88842789c6@infradead.org>
 <20231010204346.78961fc4@barney>
From:   Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <20231010204346.78961fc4@barney>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi Michael,

On 10/10/23 11:43, Michael Büsch wrote:
> On Sun, 8 Oct 2023 23:12:49 -0700
> Randy Dunlap <rdunlap@infradead.org> wrote:
> 
>> -	depends on SSB_DRIVER_MIPS && SSB_PCICORE_HOSTMODE
>> +	depends on PCI=n || SSB_PCICORE_HOSTMODE
> 
> I thought about something like this:
> 
> depends on (SSB_DRIVER_MIPS && PCI=n) || (SSB_DRIVER_MIPS && SSB_PCICORE_HOSTMODE)
> 
> Would that solve the warning?

Yes, that works as well, although I prefer to express it like this:

 config SSB_EMBEDDED
 	bool
-	depends on SSB_DRIVER_MIPS && SSB_PCICORE_HOSTMODE
+	depends on SSB_DRIVER_MIPS
+	depends on PCI=n || SSB_PCICORE_HOSTMODE
 	default y

although if you prefer the way that you have it above,
I'm OK with that also.

Thanks for your help.

-- 
~Randy