Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp405602rdg; Thu, 12 Oct 2023 08:57:28 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHxCrMeGCEazJ0Y8WatL4jf5uQ+YAaHDXhWir58b9y4qCLDSxBUo3kaI/lNJ6cT8qGFakTW X-Received: by 2002:a05:6a20:914a:b0:149:700e:f50a with SMTP id x10-20020a056a20914a00b00149700ef50amr29482217pzc.29.1697126248408; Thu, 12 Oct 2023 08:57:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697126248; cv=none; d=google.com; s=arc-20160816; b=YmED0uw/catOWWOILEnXV3Db/JkfcS+ij0k8XyqXNu/rXpW0Hpq+7YIhQxfEEtVBbf 1NSCuWw0jBjlehBN9kWT54SHAzfUEyURlPOXSdiMQ5WAmsSSJJ44fhXBjcy3OxYpgIzO 9y1IR5x8FjXc3xEWJxwfD5rAvhX0di6EqpydabzntMRmqP37G0qDuf9CpHtBk17Yg+li eVGF9GCKFKCCC4kznSPGbidHahLW09j2LDrcybEOT07GWMnF8MqM+WnHQEkokqnRHBVY RXrQa0CSvFMlSCkwuBwc6p58jKHf0qt1Kv0r8bIGYJNNoD/ETXi5+vjESv/Ou7Zrv9Sp w0mg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:message-id:in-reply-to :date:references:subject:cc:to:from:dkim-signature; bh=Hra1OdTTCWXqdbwmIqGty/DLhZADf6eulOryiU0Tod8=; fh=Ys5YkGUFnQ0Urqx/WNOBN2yJk8p+ECXsLb9VLqe9ApM=; b=0Dyl6sK845HEBh9xWqam8zvfWZakBc+9G+MV2/13i0jHf4p77ZlbKkkfvuidPWHrJC SIsMatYFS33Ow9akYRm95f3eEXEy37+qV0TSF8xt+2EJHfPU8dJoz9A4eBvEaoWBRNY4 KTxhx8fdnWwbAZjbJmDeEBGZg3sZXrZxfGh8dMZKn4Uz6JgpY2sax7U9iaoN58wc9Xvh JY0Lf9y+A3LDYiJHrruMvMrdGuwC1JJXOUfBUTjxoGv2Z6V5cnveqypGEEGXw90RRUy2 8ueMldiNrgIFAsltySywp149b+Mq8qbuhXxqDnPmhz2GCy2DmirWXqJb62P48Ski+/E7 fd/A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=aQQZsDPQ; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id bt12-20020a056a00438c00b00690d00d52efsi14793887pfb.264.2023.10.12.08.57.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Oct 2023 08:57:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=aQQZsDPQ; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 9CC148061B74; Thu, 12 Oct 2023 08:56:49 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344081AbjJLP4c (ORCPT + 52 others); Thu, 12 Oct 2023 11:56:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60092 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343986AbjJLP4a (ORCPT ); Thu, 12 Oct 2023 11:56:30 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 80A89C6 for ; Thu, 12 Oct 2023 08:56:28 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 45980C433C7; Thu, 12 Oct 2023 15:56:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697126188; bh=Zrg9V546WCSensWGA9/PHBSdUYk0odDitoKotkVzj2Q=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=aQQZsDPQsQRQG0n9w+OOUrEYnaot5STc+71j9yVBlzEfxSOUfXnSsEU7Z94NY7pqA JOqBT6BIymWBAxhykksTuAESml/7YVh2ebYpmN+2cHMloTMnBa3JvOnmUm7HOQaLzf /cUprJl8BBYI1wNW1zwLfkWQoze/6xdtOs+O8kvXDuwxMHl/+6f1Hsx9t0Ew0sL9PU Cd3z+WezPlUj+7t6UI5g5amqHS3lZFAqkF+5u0s3oCx1JHuTToeXpmgFsqaeTxQjpx ckn4uVkbsbz7359GRKsR73C0s3KFWUzmWRlAaz3DN9PAH36LjahVHUORHIrh6h4BAO NBQ8pYFtZs/xQ== From: Kalle Valo To: gregory.greenman@intel.com Cc: johannes@sipsolutions.net, linux-wireless@vger.kernel.org Subject: Re: [PATCH v2 01/16] wifi: iwlwifi: fw: increase fw_version string size References: <20231012153950.f4465b4b4e2b.Idced2e8d63c492872edcde1a3ce2cdd6cc0f8eb7@changeid> Date: Thu, 12 Oct 2023 18:59:00 +0300 In-Reply-To: <20231012153950.f4465b4b4e2b.Idced2e8d63c492872edcde1a3ce2cdd6cc0f8eb7@changeid> (gregory greenman's message of "Thu, 12 Oct 2023 15:41:48 +0300") Message-ID: <877cnrg7cr.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 12 Oct 2023 08:56:49 -0700 (PDT) gregory.greenman@intel.com writes: > From: Gregory Greenman > > In reality 64 bytes are enough to hold fw version string, > but some compilers can complain (with W=1) that output may be > truncated when building this string with snprintf. > Increase the size to avoid this sort of warnings and state > explicitely that we want the size to be trancated to 32 bytes. > > Signed-off-by: Gregory Greenman Thanks, I don't see warnings from iwlwifi anymore. Tested-by: Kalle Valo -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches