Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp414587rdg; Thu, 12 Oct 2023 09:08:55 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFTPHjAmKF0VGfDL21bBfVk/ScYUVcqd4xkiw9tz5KXVqZFGWionOflzwaJDq3mW/OpWp6I X-Received: by 2002:a05:6a20:3d03:b0:15e:bb88:b76e with SMTP id y3-20020a056a203d0300b0015ebb88b76emr29516704pzi.14.1697126935617; Thu, 12 Oct 2023 09:08:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697126935; cv=none; d=google.com; s=arc-20160816; b=URuihwmUKAetKwOPeexWrXbWj7yKyBf9bPfmSFgrgFtelgqCxoTgxbPg0wj+ygGHhc KPu9B5njnOpi6p6tulJDEIR0Ftu6mnQ/+RLEFC3vVEpGTTiRtlcc71u4zDOC/6KULBj6 1NCSi7kr5+zVb3X8sB1877d6M2fkM2zOVj7cwvtfYD8td+t1mSSiyDmC7eBBW2IwSqCE /4quJpWqLxhJGUPhLqkDx7gIOqDWkf0rLe9aE6BGfGhRbM/zXEm38FJr0sBybICuLfLS ggAGsFvCf0wQm6xXsBC8nZdCMOe0h/Uqn14k+4oiesIPSTLT1ag9bKOZfpyn/8mPr4Bz vosA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dkim-signature; bh=luf+xbSPB+vSXMCO57p3oNjR/jkRL0OwD40zKsnejMo=; fh=nPaLycMTOBWR/XLg+Ui9zHOcWLthyerHPcwB4pTw8mE=; b=J/LaIxmfXxQrdWwiUyZwWw1Lod3LhzwB7SBalcvKjRJNuo00NNdY7VUd6rWBwCF1VT ol/GKhL1Eew8RVGdKdYbqrBKURPFIkumR5i8fJHLYseMtYWNg5vq67bdMZuny+K7N79U +nMvr4GiubxpXCeR8D5M7OZQiZMqCtDw1zZi05k2PNULG9myxA9V8J9PkAIBBLhXi8PY yEXiqeSYm9TGXjEyBuZUFjp73/nn70stdG/bJ7WhYwxdi/8dKvWp6M9L4rP6YJA1THpA RGWR2d13mP2sUo9xsAyj6XOF/25OBoHDp698nlLQBErRndLnuCJG4T25q5huNvXG5Bbk 408A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=vJIpcU+8; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from morse.vger.email (morse.vger.email. [2620:137:e000::3:1]) by mx.google.com with ESMTPS id s24-20020a17090ad49800b002776d9770d6si1175264pju.69.2023.10.12.09.08.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Oct 2023 09:08:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=vJIpcU+8; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id C18A083BDCFA; Thu, 12 Oct 2023 09:08:46 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235747AbjJLQIq (ORCPT + 52 others); Thu, 12 Oct 2023 12:08:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41502 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235744AbjJLQIp (ORCPT ); Thu, 12 Oct 2023 12:08:45 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E897D94; Thu, 12 Oct 2023 09:08:43 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 44987C433C8; Thu, 12 Oct 2023 16:08:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697126923; bh=WyU9XAjD3B9ziyuyYmadcf6A83tJF/r6+JldUx4J6k4=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=vJIpcU+8lFVMrB0+9NB9EOFaYhBF5ZoeaoBXMvDGYQeGcP5TY0HW5M8bZ7yvNQaQy PBVoCzDMuR1LKz9Yem8VzxIIqVztMe8j8WDJ10nf5/Y7KiRt8irnmU62D51XtVXUxv qvDY1izlR7shUVG9/4mps0ZL4zocF8xXrO1MjgSk3netYAsx7DoaWaiicEmQOz/nvm WC4J+Y/TpsukuzpKFqUZKCb9vAm0Wb+Uop3e6FQnnvKlDKAypfdtbP+FKGmhdi3Bre 0uvFOiQOFxemVdHMae7Xg+K1QiQiSxBxly3lqE/MQ/fnFxlzUk9RIO0imCndGhjsQ6 D0E7PJ+n6ZQJw== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] wifi: ath11k: Introduce and use ath11k_sta_to_arsta() From: Kalle Valo In-Reply-To: <20231009-ath11k_sta_to_arsta-v1-1-1563e3a307e8@quicinc.com> References: <20231009-ath11k_sta_to_arsta-v1-1-1563e3a307e8@quicinc.com> To: Jeff Johnson Cc: , , , Jeff Johnson User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.11.2 Message-ID: <169712692043.3501995.15122826028111120811.kvalo@kernel.org> Date: Thu, 12 Oct 2023 16:08:42 +0000 (UTC) X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Thu, 12 Oct 2023 09:08:46 -0700 (PDT) Jeff Johnson wrote: > Currently, the logic to return an ath11k_sta pointer, given a > ieee80211_sta pointer, uses typecasting throughout the driver. In > general, conversion functions are preferable to typecasting since > using a conversion function allows the compiler to validate the types > of both the input and output parameters. > > ath11k already defines a conversion function ath11k_vif_to_arvif() for > a similar conversion. So introduce ath11k_sta_to_arsta() for this use > case, and convert all of the existing typecasting to use this > function. > > No functional changes, compile tested only. > > Signed-off-by: Jeff Johnson > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 10c65f97b424 wifi: ath11k: Introduce and use ath11k_sta_to_arsta() -- https://patchwork.kernel.org/project/linux-wireless/patch/20231009-ath11k_sta_to_arsta-v1-1-1563e3a307e8@quicinc.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches