Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp828542rdg; Fri, 13 Oct 2023 02:17:35 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEindEwQM4X9exRPe1iBd7HTQLkTPU1W2fptDHqK5xQKPbWuUeavrLX90N5FYRrbQGGiQiM X-Received: by 2002:a05:6a00:e1b:b0:69b:5395:59a8 with SMTP id bq27-20020a056a000e1b00b0069b539559a8mr16592215pfb.34.1697188655299; Fri, 13 Oct 2023 02:17:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697188655; cv=none; d=google.com; s=arc-20160816; b=N3+7DgebMqEnkzBlPpqugFJQ/e//iBw3u83clbgB+dgYMvQEu+h8/nowMpi2SjHw5f +vKUwFj2dpEamOdjbCkdDf61y3oGPNHZeLL/R9cpvNJ221ney7mIg4SnXhjpaJCXfkP7 e4rcHMj+CXZPE3qDrASHXprOkuIpoIHU9snZZYaVRXcCFuULmrwW/zXIHBsdbiWeEHNe 04wgPySTCJy8jz6ZHy4TTfRxXLRGZS9xb107eOG0ruG5TtKzVPGe3F8uqse0TBkw+ajW qUr+AkbeaG/AfqTFG7Z7jpol/nQ/94J8NQUtmMmU+RZ1XaZUdaNo8UB8eyR4iajO9X9m ck7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :content-language:accept-language:in-reply-to:references:message-id :date:thread-index:thread-topic:subject:cc:to:from; bh=6bZ7Zz6IGa/+5yb8PSF8E+f6QfxVPk1CqW9BrbsxvXI=; fh=pZpLv3JBu7ewThcXtBU3x3uGUeTqUHmHtpmV6AvLzGM=; b=STU6SBTB+S4ckc8ZVyCP0xCRdVMCYMBPXyFMlPdvpF4/zTra4/WXvV0lQd4UcA52To CwchSJneG+2eKTbJ7pWzCV4SY5mzoa9e49p6KbNEiMcw1EsMqLLk1IPQyiQ17EgAdyj4 jeYH4SOIHfezgQ6NqUfNBijZBjjPvVLWDOFyRi6IXa4Jgl0dHg/fADdxkjL38CqAyX5t mFEI0IFVIQZ0F6soO/A5CqGjdix0vOH0YLf1xGTVZT8nYHFOEwJLb2qQQF/UvqsHR7l2 J+5xfWQPPQpxP2GCg34TBdyntjN/j8MccXzreOVDPX3up8HN+SFH/PmUhOUNDyBal96T eCqw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from fry.vger.email (fry.vger.email. [2620:137:e000::3:8]) by mx.google.com with ESMTPS id d13-20020a056a00198d00b006933e8fec67si16884355pfl.227.2023.10.13.02.17.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Oct 2023 02:17:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id C27058279A66; Fri, 13 Oct 2023 02:17:30 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230360AbjJMJR3 convert rfc822-to-8bit (ORCPT + 52 others); Fri, 13 Oct 2023 05:17:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57786 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230255AbjJMJR2 (ORCPT ); Fri, 13 Oct 2023 05:17:28 -0400 Received: from rtits2.realtek.com.tw (rtits2.realtek.com [211.75.126.72]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 34F1395 for ; Fri, 13 Oct 2023 02:17:24 -0700 (PDT) X-SpamFilter-By: ArmorX SpamTrap 5.78 with qID 39D9H9qN42596124, This message is accepted by code: ctloc85258 Received: from mail.realtek.com (rtexh36505.realtek.com.tw[172.21.6.25]) by rtits2.realtek.com.tw (8.15.2/2.92/5.92) with ESMTPS id 39D9H9qN42596124 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 13 Oct 2023 17:17:09 +0800 Received: from RTEXDAG02.realtek.com.tw (172.21.6.101) by RTEXH36505.realtek.com.tw (172.21.6.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.32; Fri, 13 Oct 2023 17:17:09 +0800 Received: from RTEXMBS04.realtek.com.tw (172.21.6.97) by RTEXDAG02.realtek.com.tw (172.21.6.101) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.7; Fri, 13 Oct 2023 17:17:09 +0800 Received: from RTEXMBS04.realtek.com.tw ([fe80::40c2:6c24:2df4:e6c7]) by RTEXMBS04.realtek.com.tw ([fe80::40c2:6c24:2df4:e6c7%5]) with mapi id 15.01.2375.007; Fri, 13 Oct 2023 17:17:08 +0800 From: Ping-Ke Shih To: Dmitry Antipov CC: Kalle Valo , "linux-wireless@vger.kernel.org" Subject: RE: [PATCH 2/2] wifi: rtlwifi: simplify TX command fill callbacks Thread-Topic: [PATCH 2/2] wifi: rtlwifi: simplify TX command fill callbacks Thread-Index: AQHZ/FovLLMxfG//dEOkiDvZE8PfAbBHcqeg Date: Fri, 13 Oct 2023 09:17:08 +0000 Message-ID: References: <20231011154442.52457-1-dmantipov@yandex.ru> <20231011154442.52457-2-dmantipov@yandex.ru> In-Reply-To: <20231011154442.52457-2-dmantipov@yandex.ru> Accept-Language: en-US, zh-TW Content-Language: zh-TW x-originating-ip: [172.21.69.25] x-kse-serverinfo: RTEXDAG02.realtek.com.tw, 9 x-kse-antispam-interceptor-info: fallback x-kse-antivirus-interceptor-info: fallback Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-KSE-AntiSpam-Interceptor-Info: fallback X-KSE-ServerInfo: RTEXH36505.realtek.com.tw, 9 X-KSE-AntiSpam-Interceptor-Info: fallback X-KSE-Antivirus-Interceptor-Info: fallback X-KSE-AntiSpam-Interceptor-Info: fallback X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Fri, 13 Oct 2023 02:17:31 -0700 (PDT) > -----Original Message----- > From: Dmitry Antipov > Sent: Wednesday, October 11, 2023 11:45 PM > To: Ping-Ke Shih > Cc: Kalle Valo ; linux-wireless@vger.kernel.org; Dmitry Antipov > Subject: [PATCH 2/2] wifi: rtlwifi: simplify TX command fill callbacks > > Since 'rtlpriv->cfg->ops->fill_tx_cmddesc()' is always called > with 'firstseg' and 'lastseg' set to 1 (and the latter is The 'firstseg' is used to optimize the code if more than one segments. However, I think rtlwifi will not support multiple segments in the future, so changes in this patch would be fine. > never actually used), all of the relevant chip-specific > routines may be simplified. Compile tested only. > > Signed-off-by: Dmitry Antipov Acked-by: Ping-Ke Shih