Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp1283279rdg; Fri, 13 Oct 2023 17:07:46 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFY+X+GhMBX7w6Ox8mIuVp1GXsUfoIh1KWAcD0ZgFrXCSpZCNha7g3NH/A+GiimQlDlU0mS X-Received: by 2002:a05:6870:898f:b0:1d7:fe1:e294 with SMTP id f15-20020a056870898f00b001d70fe1e294mr33646183oaq.34.1697242066181; Fri, 13 Oct 2023 17:07:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697242066; cv=none; d=google.com; s=arc-20160816; b=C3Xgi8NrpS5rDonXzOQI9mhmaEzre3mE0wQw1u6KZDrXOm4MKf+aVweWrjPMcdmMT5 B8QXDkpYCrX6L0m53iA7hvoanfjXA920WpcJp/c3EdrDMMnh8myqJzYf9PWWs7/dlY2c iDNw6KhQU98bOHQuIvS30QyKNmQJ1QUOb7KPzt5yDm2XuDxZ7Lxqd7h75sl9Mdh0PgLU RKtrGy+mDj5TR6Tr94OsLx3LKslRqDNNeRuvs+6tFHeR5Sn8BZ/tkNvW5ymqvZyc8wwi 000LFMUP+0QUqbqGmT7nDgvB2tcg7uhToiHGAcHeC0WuajRyjPM0Ysktt5IIUWmaW18e l0Xg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=YvRZpviyFS4ljx+mcaaHG8eNLwosN/MMg9juUIhGhZI=; fh=tVi5dJNV9QrEINZPzKNVey7zuqLoe8Uw/u5Qe+l4lvE=; b=0hg5HbzhVC4Lp3//UHIS9F4QhOY4VAzzhbb72Cb8CnQcljDBUW5ochQ02qREriafQi /trxC27M3ivirpBtYrEpCDcLPQOROHvmOTWiUSBuMVmzu5yWa2KOkVhpUQcLKawqrGt0 pLQzqPFJ9V1fOXg2GwOOdEXbUVep75/cEpXPvcus49hWmj16djobkuJz/I0ijy7a4CtV fYH/kWlNr50L5hcy77Ba1eIjvE3XAf2YN1O1h4hy7UVMiWn/qdGMov2VIgRFiL0h+G36 yWxJgF4ItqRy2UbZZp5BCKqTxp9OkJF02ZLhBudm46mRPMS2fdYX8bEgcmRFtsh+igsK eUAw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=UdBr2wcD; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id 38-20020a631966000000b0058a09ed5ca2si5501395pgz.313.2023.10.13.17.07.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Oct 2023 17:07:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=UdBr2wcD; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 088188024C6E; Fri, 13 Oct 2023 17:07:41 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232579AbjJNAHh (ORCPT + 51 others); Fri, 13 Oct 2023 20:07:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56024 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232559AbjJNAHf (ORCPT ); Fri, 13 Oct 2023 20:07:35 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 888DEAD; Fri, 13 Oct 2023 17:07:34 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 744BCC433C7; Sat, 14 Oct 2023 00:07:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697242054; bh=6kpMwlfSNasU9AQMtLitDygCjCpDKwjI+adsPbqa9OA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=UdBr2wcD9YbkjCo7SyrOU7C2P7cOL79UAKLiM1BqeppHoumCz76G9EbxX7WR2a7v0 Y60I+lH6kFJnJziGqDlxqaLZNQaM/awAaSidgcGYR+9q83BJ2QxSZEZjTjIuk348Pi ffyBwFqzUhY++R8GyWNdABQ2xssKv/CC5BMpYdyuVHIv/3fh2UddcuGDzzePUzM0Zj ZFZNP9zKbvbYP8evuVMaLBq3Uhtdj7X0PFkWqqfqRdG+UIQQ5Ycc52CB8UiFnpBAQL Xh9FykSlCiuWrvhF9vOqoSKQIaFP4aVwTfh1v/CEpEBtX9JaFGG1pCzHzRUPMxahBz kL3fZdQ9ejoyw== Date: Fri, 13 Oct 2023 17:07:32 -0700 From: Jakub Kicinski To: "Johannes Berg" , Kalle Valo Cc: "Arnd Bergmann" , "Jiri Pirko" , "Arnd Bergmann" , Netdev , "Greg Kroah-Hartman" , linux-wireless@vger.kernel.org, linux-wpan@vger.kernel.org, "Michael Hennerich" , "Paolo Abeni" , "Eric Dumazet" , "David S . Miller" , "Rodolfo Zitellini" , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 01/10] appletalk: make localtalk and ppp support conditional Message-ID: <20231013170732.587afd86@kernel.org> In-Reply-To: <82527b7f-4509-4a59-a9cf-2df47e6e1a7c@app.fastmail.com> References: <20231011140225.253106-1-arnd@kernel.org> <82527b7f-4509-4a59-a9cf-2df47e6e1a7c@app.fastmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Fri, 13 Oct 2023 17:07:41 -0700 (PDT) On Wed, 11 Oct 2023 17:57:38 +0200 Arnd Bergmann wrote: > The .ndo_do_ioctl() netdev operation used to be how one communicates > with a network driver from userspace, but since my previous cleanup [1], > it is purely internal to the kernel. > > Removing the cops appletalk/localtalk driver made me revisit the > missing pieces from that older series, removing all the unused > implementations in wireless drivers as well as the two kernel-internal > callers in the ieee802154 and appletalk stacks. > > One ethernet driver was already merged in the meantime that should > have used .ndo_eth_ioctl instead of .ndo_do_ioctl, so fix that as well. > With the complete removal, any future drivers making this mistake > cause build failures that are easier to spot. > > [1] https://lore.kernel.org/netdev/20201106221743.3271965-1-arnd@kernel.org/ Kalle, Johannes, do these apply for you? I'm getting a small conflict on patch 8 and bigger one on patch 9. If this applies for you maybe you can take it and flush out wireless-next soon after?