Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp1363993rdg; Fri, 13 Oct 2023 21:58:37 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFHKLLpxYcx7iUyMHJ0oIyNkWKxD0fTyuOT7VjgCZGlbtpld+FbosgWg+JOKZ+UQ8khCBGx X-Received: by 2002:a05:6a20:ce89:b0:15d:5f9a:3921 with SMTP id if9-20020a056a20ce8900b0015d5f9a3921mr26492443pzb.27.1697259517688; Fri, 13 Oct 2023 21:58:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697259517; cv=none; d=google.com; s=arc-20160816; b=ELG9GekxvgowLQotLvBIpI2ykCJEUR4d6SVdgQ9WuuMMnCpWktLkxfaGAqyFLa/JCv wEd3mWTy/WbHnikXNtNccHyQLny0rOx97teeT7BzXCoIY79CaN45b6GHtDYwezMkQst+ Dkjbh/ESQtgYtFCwR6QkCaQ8liVnBLtqn6zLWhd0rACJYDs12yaZ9NEkqMn6i8t7B/j3 SMpmNOVJ907EVod76FmI5FbGgG6PKMWcAU14YPR/Md18/tPxdsm+uGkS7CQSdrPW75vL worN2/OxfD0OyLHwpVIYHclCzCLrAqutwDHG/JMJCnYB+YZl87jevvVHUtfCoLW0BC2s mFPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:message-id:in-reply-to :date:references:subject:cc:to:from:dkim-signature; bh=n6cyVRus0Ajv/rZLFng2PlXEulZ5UjO/X2cGgZH7Sh0=; fh=+cBsJfmQrn+irNIxxW63Z7YAxpfzRwekbjO0jEFCeQk=; b=UzIMT9rG5Y7cly09dzMT+7PKMtMTZDmOfVqjLFpQ2aPglm7Zt0+gMbrSZOTWKptKSp tLP3qZW9B3HWrUB83fVOXwxPHnDzNdd3EbzP99KqHPmanchXpm0MJi9GLC7fFURVnv9T Vj7kVr2WZdDYHdh5vVIWC9GC1ySnCXmJJXMJzwrm9SlQGBtKcfLCyJj+OcQWJO9ffilS yb9ZPzme1hf9Z2rV7f8/pAFLGw5I0qZiiSDeKPVV2WSzzqX67CtM3Snbqi5gdWrycz2r vw66k1jYrhrxs3TQrO0B5Yrux/HenQGiccHNaPd6uH+1dmAJEMrEO31jj5jJj9ppb6fC YwoQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="kk/iTTZ2"; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id 202-20020a6302d3000000b005859da6172bsi5883343pgc.727.2023.10.13.21.58.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Oct 2023 21:58:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="kk/iTTZ2"; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 4042982D981F; Fri, 13 Oct 2023 21:58:35 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232383AbjJNE6W (ORCPT + 51 others); Sat, 14 Oct 2023 00:58:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38044 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229518AbjJNE6V (ORCPT ); Sat, 14 Oct 2023 00:58:21 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 792E9C2; Fri, 13 Oct 2023 21:58:19 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2005EC433C8; Sat, 14 Oct 2023 04:58:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697259499; bh=bC06wekgYjGHqy1sHjwyZxjBb7s+oWdSTrNPtgW20Bc=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=kk/iTTZ2RR/TmlnrepoYqGc6mUAC4pf8x/P/BY+8rUpNlxVvCuu6smc83Lto6uwRc qJg0HkBoYb7Vo7xljX+KgiU8MwaLVN30bzsXpdzDim+XALyZq1R2GRZPFfhCVtUc09 kjWolSBkeelgYaKZcN9ygMY4I3s2MjL3o/SyzxgiUVyGejHmVeNDB4QLAs4XONISam J8oRmI1AP7X8j+y3LLGS1waujLbNPQWYnPMO+2SzHcc16vdSxb3EFwORkFNaWl/bib xOI4jT8ioNqim2bTPZZORvxGaRHz1KA8u9gfKoJPCb4dxB3u2sKFlEfBPdupKUivF4 zI5gGCQgVqziA== From: Kalle Valo To: Jakub Kicinski Cc: "Johannes Berg" , "Arnd Bergmann" , "Jiri Pirko" , "Arnd Bergmann" , Netdev , "Greg Kroah-Hartman" , linux-wireless@vger.kernel.org, linux-wpan@vger.kernel.org, "Michael Hennerich" , "Paolo Abeni" , "Eric Dumazet" , "David S . Miller" , "Rodolfo Zitellini" , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 01/10] appletalk: make localtalk and ppp support conditional References: <20231011140225.253106-1-arnd@kernel.org> <82527b7f-4509-4a59-a9cf-2df47e6e1a7c@app.fastmail.com> <20231013170732.587afd86@kernel.org> Date: Sat, 14 Oct 2023 08:00:51 +0300 In-Reply-To: <20231013170732.587afd86@kernel.org> (Jakub Kicinski's message of "Fri, 13 Oct 2023 17:07:32 -0700") Message-ID: <87r0lxer24.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Fri, 13 Oct 2023 21:58:35 -0700 (PDT) Jakub Kicinski writes: > On Wed, 11 Oct 2023 17:57:38 +0200 Arnd Bergmann wrote: >> The .ndo_do_ioctl() netdev operation used to be how one communicates >> with a network driver from userspace, but since my previous cleanup [1], >> it is purely internal to the kernel. >> >> Removing the cops appletalk/localtalk driver made me revisit the >> missing pieces from that older series, removing all the unused >> implementations in wireless drivers as well as the two kernel-internal >> callers in the ieee802154 and appletalk stacks. >> >> One ethernet driver was already merged in the meantime that should >> have used .ndo_eth_ioctl instead of .ndo_do_ioctl, so fix that as well. >> With the complete removal, any future drivers making this mistake >> cause build failures that are easier to spot. >> >> [1] https://lore.kernel.org/netdev/20201106221743.3271965-1-arnd@kernel.org/ > > Kalle, Johannes, do these apply for you? > I'm getting a small conflict on patch 8 and bigger one on patch 9. Yes, 'git am -3' was able to solve the conflicts automatically and these do apply to wireless-next. > If this applies for you maybe you can take it and flush out > wireless-next soon after? Ok, we'll do that. Does next Wednesday sound soon enough? :) -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches