Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp1370978rdg; Fri, 13 Oct 2023 22:22:15 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEOhOHPzvvACuQ20GbEo4db9XC2MSC1oieAxKiiS9a74IbzRDMHxgg/+bunLrqsAFuDa2Rt X-Received: by 2002:a17:903:30d5:b0:1c9:dfb8:a58f with SMTP id s21-20020a17090330d500b001c9dfb8a58fmr5488681plc.20.1697260935055; Fri, 13 Oct 2023 22:22:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697260935; cv=none; d=google.com; s=arc-20160816; b=GzpBrdHezA5mw77cKSAVjd9W5miY4Lc12Fw9mZ2plym6MSxGjgiegnDhFCtnRVfsY6 K8OXLgqkUForCes0bVwYQ4VGc504jKaS4dHomBZJLSQ9EDtKngb2LT1qsqsy7HROh+CF 3mH+iT+wzWvja/XMqme4J6/n1u3sZ9huhxTt+HPagGat4luU31nsxlMXemVPwXvazZ8G 7euhLRyVpOyPuX3fWaaZhXJhmKthBjEO5Zp8ZoeT4GIsaNgTBxsD8N5Xpps6KZr2jFtW /w0DVFtvyYYEJFGKjeN9xpPLfpuKTn5CLk2OmMZMTHH+378Qi3moKxVYoi/Diu4joAFf iV9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:message-id:in-reply-to :date:references:subject:cc:to:from:dkim-signature; bh=D725SKBbYDO7G5JoBaRXevNGwnd9+hn10/L8/d/9nDY=; fh=TyOqAd4n0UmuG/CiWvpPrVJuc/FX3uglzGvtOw2DiEI=; b=Q5Iaf9C01xP29r1OI+eSPrh0DAf2xl2y5nZXjV1M0nzDh5RXUJnt994YG88BQEDNBc 0iSCF8s7Pfelp1Cy7us7vpZK80xWdesXOvWWxvZsSFlufrNE4MuyTfsCi3lnxN8o/LfV Cd2ZlV8VSMmr0UZ1qcfsNJ3UYAWQRzv15aIP/cAGTvIE7gnbj5jKJe0dCFWm9Gk1I4cj tjYsS2Gc1jGUCg8F+Pa5wZsQCnKHHkeGH5tkKoOWoUO4NbTWBk7TrBWIZXejJqLTtKbB R3ClyVQu3zcohrAt69JNy5ddMdGbpCZkqLV2Xif9IBKmiSDlfT6mWZrWwG9Qacc/c5Uq xcbg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ICYTGHBr; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from howler.vger.email (howler.vger.email. [23.128.96.34]) by mx.google.com with ESMTPS id z7-20020a170903018700b001bb8df95094si6443056plg.509.2023.10.13.22.22.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Oct 2023 22:22:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ICYTGHBr; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 8F4F5833F8F9; Fri, 13 Oct 2023 22:22:12 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232793AbjJNFUM (ORCPT + 51 others); Sat, 14 Oct 2023 01:20:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39928 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229518AbjJNFUL (ORCPT ); Sat, 14 Oct 2023 01:20:11 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8409BBF; Fri, 13 Oct 2023 22:20:09 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 838B0C433C7; Sat, 14 Oct 2023 05:20:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697260809; bh=Ytj2/J6JoBkWt+fErmzSJIMEUCzhsog0az/dPrYSoqI=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=ICYTGHBrHoTDiCb37W1wDlaDlK2hb/Usrv/wIXwmxTCIWFzfO9QvRdHfeAbkk45gm OtFGC3aMI5oB9BrXLw5R675UrRIvEZleHHRci0z0YyJaAxxHmHI/eNdGcYSQMbxXvk YLu9JKXVZl/AZ3mfmFT0q0FyYyBjudqMVgdOhDYF07XRNDENqcCOqdNfkvAJBUXs1x aSOqcfKQK4oY4fcBsv9vsR4oUCAKoNw1LmLpFV8o5NXLHe+4VDpZPNJo5CWLgpDi8k NDFu6b2/fgdUCusNpdKVD8TemfPcRWlfp+cNascn79BgHfWV5a9cACas3mSKLjrj6h C5hreUQFnu+qg== From: Kalle Valo To: Abhishek Kumar , Jeff Johnson Cc: johannes.berg@intel.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, ath10k@lists.infradead.org, linux-wireless@vger.kernel.org Subject: Re: [PATCH 2/2] ath10k: mac: enable WIPHY_FLAG_CHANNEL_CHANGE_ON_BEACON on ath10k References: <20230629035254.2.I23c5e51afcc6173299bb2806c8c38364ad15dd63@changeid> <169634426707.121370.9448850980134728319.kvalo@kernel.org> Date: Sat, 14 Oct 2023 08:20:05 +0300 In-Reply-To: <169634426707.121370.9448850980134728319.kvalo@kernel.org> (Kalle Valo's message of "Tue, 3 Oct 2023 14:44:28 +0000 (UTC)") Message-ID: <87il793hmi.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Fri, 13 Oct 2023 22:22:12 -0700 (PDT) Kalle Valo writes: > Abhishek Kumar wrote: > >> Enabling this flag, ensures that reg_call_notifier is called >> on beacon hints from handle_reg_beacon in cfg80211. This call >> propagates the channel property changes to ath10k driver, thus >> changing the channel property from passive scan to active scan >> based on beacon hints. >> Once the channels are rightly changed from passive to active,the >> connection to hidden SSID does not fail. >> >> Signed-off-by: Abhishek Kumar > > There's no Tested-on tag, on which hardware/firmware did you test this? > > This flag is now enabled on ALL ath10k supported hardware: SNOC, PCI, SDIO and > maybe soon USB. I'm just wondering can we trust that this doesn't break > anything. Jeff, what are your thoughts on this? I'm worried how different ath10k firmwares can be and if this breaks something. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches