Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp1393037rdg; Fri, 13 Oct 2023 23:42:56 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEDj84QRCFCx4eju6mEnBbUTmt/iRNrAxeIA8heV31jd7r8Fp1iBTTUmbVEXxk0+XnhsIGa X-Received: by 2002:a05:6e02:12c2:b0:34f:3262:a8bf with SMTP id i2-20020a056e0212c200b0034f3262a8bfmr39637100ilm.17.1697265776565; Fri, 13 Oct 2023 23:42:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697265776; cv=none; d=google.com; s=arc-20160816; b=iI+4+UbHzgZEVKqnzQ4Ho0fv5zmL/s4nc9FH8O/DbvHcHU3LZjUIN07muiornnIqjm Q3AGV5ZuWuSuW4v4QABEIkPOaf/YkB3m214uZwQnZ8ldE9t5jwKXK7a+UyKmMOOmDWo/ +Y2nSVzB+nOtumfs8KjDP3INPQj7tSI91/lp5QL7YCzEoBkcLukDSdAjpLJhPsff7k6F Qw3JutS1LscnIG0h0AChRRqaO2wH4Y6exTFiuvCGjRjG3JJEKclEEQRBFp0tL0dYzOWY TbShnwx4NdWXb/tZXqnyL4bptjoiDM3tbXUNuvbR/cBEmO/aZ4x9+FJQBHbPUUsH+QLF 8Bpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dkim-signature; bh=RszLljsASeQCxawAtkZGdpr17Ejx0558mFsrJxlr1GA=; fh=W+d0VTlB06MRf7YcZ9fsTH6rmN1qgblnN3a4fITKvd0=; b=wAC/ZZkOOK9Nm1LmYXp3ErGzXYHkAy77LcVLvNkhOFARiRxuy0rirK9wU0/C5h3llI tVfuBmKqqpDm+0+H/AxgKNLlNwcpAHKhAGhqytq6w6hQ4jiJSnx65b6GOL3WygcFcpXK S7Kz6mLlyTt2xicdETkgjQ6JPToF3t5Ny47LLl7qTaQAjcVTKTBaHDF5aZ6FHc9m2yUT m4SH6n7I47B4DB7mB3foKrJCl2JgQxfv7nyKvzZOcrPLvGbX3HTWsFxN8aAWAZTd2CeH pBKpFRccUJNJiohFpHwde/4AFvzaFSQd0lfheV9EmITXweLwNxb7LHi2K1jjFLuyh+of Yf1A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=smKl4tw0; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from pete.vger.email (pete.vger.email. [23.128.96.36]) by mx.google.com with ESMTPS id hb18-20020a17090b209200b0026cab818aa2si1615338pjb.100.2023.10.13.23.42.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Oct 2023 23:42:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=smKl4tw0; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 91A3D81A8A91; Fri, 13 Oct 2023 23:42:53 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232800AbjJNGmv (ORCPT + 51 others); Sat, 14 Oct 2023 02:42:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54310 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232842AbjJNGmv (ORCPT ); Sat, 14 Oct 2023 02:42:51 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 39B96CC for ; Fri, 13 Oct 2023 23:42:49 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E8489C433C9; Sat, 14 Oct 2023 06:42:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697265768; bh=MMfMP+AV0fs7x6j1MdNRQHMkQFw8hnCDkZXwx7QIKtg=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=smKl4tw0LFpPtFh7cImZU92E7rqev0KAxAd9bDFXeq9eyf3X6r/cQNeBXXeXq4kRf GUPoEiWLkNKLtRi6Tfgel/OJJAGiERdkxMB1YfovmF+GoUFclJTAVHXYpCZq2yNc+8 mSAlwPFJp4O9DQbtX6w+4EtZWvqgKJ2GgcWD4I+vpXjDnqe+AbZIVYau1ZIEWuxian f2MQpSGW7UrqJTgCG4Jf13bs68IaYpv7deu769EZzSviW7Mul7I0Syg/1HoA+qs2tZ DuJ9MIQCXgC/cRe/83AvKHdiKRI75MLoj+F8MfHGUDtLkcPAYKQ7h7BePbcuNNR59g lIGCrMhhnyDeg== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH 2/2] wifi: rtlwifi: simplify TX command fill callbacks From: Kalle Valo In-Reply-To: <20231011154442.52457-2-dmantipov@yandex.ru> References: <20231011154442.52457-2-dmantipov@yandex.ru> To: Dmitry Antipov Cc: Ping-Ke Shih , linux-wireless@vger.kernel.org, Dmitry Antipov User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.11.2 Message-ID: <169726576572.3637479.6255382503730514780.kvalo@kernel.org> Date: Sat, 14 Oct 2023 06:42:47 +0000 (UTC) X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Fri, 13 Oct 2023 23:42:53 -0700 (PDT) Dmitry Antipov wrote: > Since 'rtlpriv->cfg->ops->fill_tx_cmddesc()' is always called > with 'firstseg' and 'lastseg' set to 1 (and the latter is > never actually used), all of the relevant chip-specific > routines may be simplified. Compile tested only. > > Signed-off-by: Dmitry Antipov > Acked-by: Ping-Ke Shih Patch applied to wireless-next.git, thanks. 461908825205 wifi: rtlwifi: simplify TX command fill callbacks -- https://patchwork.kernel.org/project/linux-wireless/patch/20231011154442.52457-2-dmantipov@yandex.ru/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches