Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Date:   Sat, 14 Oct 2023 19:54:28 +0200
From:   Stanislaw Gruszka <stf_xl@wp.pl>
To:     Shiji Yang <yangshiji66@outlook.com>
Cc:     linux-wireless@vger.kernel.org,
        Helmut Schaa <helmut.schaa@googlemail.com>,
        Kalle Valo <kvalo@kernel.org>, Felix Fietkau <nbd@nbd.name>,
        Lorenzo Bianconi <lorenzo@kernel.org>,
        Ryder Lee <ryder.lee@mediatek.com>
Subject: Re: [PATCH 0/3] wifi: rt2x00: various improvements for MT7620
 initialization
Message-ID: <20231014175428.GA477888@wp.pl>
References: <TYAP286MB03159DF41F754CB4F3AA4566BCD2A@TYAP286MB0315.JPNP286.PROD.OUTLOOK.COM>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <TYAP286MB03159DF41F754CB4F3AA4566BCD2A@TYAP286MB0315.JPNP286.PROD.OUTLOOK.COM>
Precedence: bulk

On Sat, Oct 14, 2023 at 07:21:27AM +0800, Shiji Yang wrote:
> This series patches aim to improve the initialization of MT7620. All
> changes and register values were ported from the Mediatek vendor
> driver, and I have been testing them on OpenWrt for several weeks.

Hi Shiji!

Thank you for improving MT7620 support in rt2x00!
Your patches generally look ok to me.

I would suggest however consider to move support of MT7620 to
mt76 driver. It's much nicer and better written driver with
better mac80211/linux integration and support of various
features that rt2x00 lacks. Adding mt7620 sub-driver there
should not be that hard, and would be much "cooler" project
for you in my opinion.

This of course depend of how much time do you have to work
on this. Tweaking/improving rt2x00 can be easier and faster
way to achieve your goals and I don't want discourage 
you from doing this, if that's something you prefer.
Keep good work!

Regards
Stanislaw