Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
Date:   Sat, 14 Oct 2023 19:55:48 +0200
From:   Stanislaw Gruszka <stf_xl@wp.pl>
To:     Shiji Yang <yangshiji66@outlook.com>
Cc:     linux-wireless@vger.kernel.org,
        Helmut Schaa <helmut.schaa@googlemail.com>,
        Kalle Valo <kvalo@kernel.org>
Subject: Re: [PATCH 3/3] wifi: rt2x00: rework MT7620 PA/LNA RF calibration
Message-ID: <20231014175548.GB477888@wp.pl>
References: <20231013232130.416-1-yangshiji66@outlook.com>
 <TYAP286MB031551F2B4A929484A35EF28BCD2A@TYAP286MB0315.JPNP286.PROD.OUTLOOK.COM>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <TYAP286MB031551F2B4A929484A35EF28BCD2A@TYAP286MB0315.JPNP286.PROD.OUTLOOK.COM>
Precedence: bulk

On Sat, Oct 14, 2023 at 07:21:30AM +0800, Shiji Yang wrote:
> 1. Move MT7620 PA/LNA calibration code to dedicated functions.
> 2. For external PA/LNA devices, restore RF and BBP registers before
>    R-Calibration.
> 3. Do Rx DCOC calibration again before RXIQ calibration.
> 4. Add some missing LNA related registers' initialization.
> 
> Signed-off-by: Shiji Yang <yangshiji66@outlook.com>
<snip>
>  int rt2800_enable_radio(struct rt2x00_dev *rt2x00dev)
>  {
>  	u32 reg;
> @@ -10762,6 +10831,10 @@ int rt2800_enable_radio(struct rt2x00_dev *rt2x00dev)
>  	rt2800_init_bbp(rt2x00dev);
>  	rt2800_init_rfcsr(rt2x00dev);
>  
> +	/* Do calibration and init PA/LNA for RT6352 */
> +	if (rt2x00_rt(rt2x00dev, RT6352))
> +		rt2800_calibration_rt6352(rt2x00dev);
rt2800_init_rcsr() -> rt2800_init_rfcsr_6352() is called right
before this. Could we have rt2800_calibration_rt6352() there ? 

Regards
Stanislaw