Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [PATCH] wifi: rt2x00: fix rt2800 watchdog function
From:   Kalle Valo <kvalo@kernel.org>
In-Reply-To: <TYAP286MB0315BC1D83D31154924F0D39BCD1A@TYAP286MB0315.JPNP286.PROD.OUTLOOK.COM>
References: <TYAP286MB0315BC1D83D31154924F0D39BCD1A@TYAP286MB0315.JPNP286.PROD.OUTLOOK.COM>
To:     Shiji Yang <yangshiji66@outlook.com>
Cc:     linux-wireless@vger.kernel.org, Stanislaw Gruszka <stf_xl@wp.pl>,
        Helmut Schaa <helmut.schaa@googlemail.com>,
        Shiji Yang <yangshiji66@outlook.com>
User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.11.2
Message-ID: <169769882877.117236.15856778587852752332.kvalo@kernel.org>
Date:   Thu, 19 Oct 2023 07:00:30 +0000 (UTC)
Precedence: bulk

Shiji Yang <yangshiji66@outlook.com> wrote:

> The watchdog function is broken on rt2800 series SoCs. This patch
> fixes the incorrect watchdog logic to make it work again.
> 
> 1. Update current wdt queue index if it's not equal to the previous
>    index. Watchdog compares the current and previous queue index to
>    judge if the queue hung.
> 2. Make sure hung_{rx,tx} 'true' status won't be override by the
>    normal queue. Any queue hangs should trigger a reset action.
> 3. Clear the watchdog counter of all queues before resetting the
>    hardware. This change may help to avoid the reset loop.
> 4. Change hang check function return type to bool as we only need
>    to return two status, yes or no.
> 
> Signed-off-by: Shiji Yang <yangshiji66@outlook.com>

Is this patch ok to take?

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/TYAP286MB0315BC1D83D31154924F0D39BCD1A@TYAP286MB0315.JPNP286.PROD.OUTLOOK.COM/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches