Received: by 2002:a05:7412:f690:b0:e2:908c:2ebd with SMTP id ej16csp175763rdb; Thu, 19 Oct 2023 00:28:31 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGEhKAg3+fNOUGGjT1QAaprYFQlCeaJK/Thav9dErc34MlqiEX3phxzL4bIKjX5XONEqmhe X-Received: by 2002:a05:6a20:7d81:b0:15d:b407:b0a0 with SMTP id v1-20020a056a207d8100b0015db407b0a0mr1740912pzj.26.1697700511076; Thu, 19 Oct 2023 00:28:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697700511; cv=none; d=google.com; s=arc-20160816; b=RvIwbjSxn0f9FDMrxozFaM5o/dpTlI1pRL3yV0QlVR39/cnHk4iEh+IQu+bTe2my2Y d77C6f7ixVpqsAn5gOXaVVVAT3hZvtrVlTsMSP3CVNdeumVWK2nPtG4vxpofFtHpyXlb m9BCf3PjrpGJCLM65P/ALS3H2SqicofPdHXycbjk37QCgsYHhx/L8Qt+8f1jkEs9trM9 7+gk1FVLYKDUDMHmQ4WcZl3gezkfsGL9m4noeE+xq80Sg79hCH9dkKJMnxez7qL+J8JL o8gDFyR7F92dDSoEtsQ43BVf1ge+BW++7ZZh+oJjIhsnHmdvdYNBIKv7X2MkD8cClqeC 4JPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dkim-signature; bh=NJRxk/OGUcZQ9/D6C6AsX8wYzFcXwwqjhgFMaUu7SYE=; fh=eN/Ohfbj3ES/L6ebL8IRBy9+ZFnomSNKSys9KIqV8nA=; b=K43XniZWWHiyn0qVX9Wyx5r9RlzbBK9GArdBB8lQPmY2JMrcV3zm/Aqow6lBrQuvQ8 +wY0/yLfTnvOIUn8ycxD2Sd07WT/iQc2ieoAvaLEbKh0ORXinsuPo/3nxnzbxW739vnL CRicCNmT5EsPpwti3wXPcdxPjy9lpPWOBDzni3ynvVw2lTQ8IMvJqeqBpmHkL1MqFEVd 6mSTYOcR2NWzdSI+LdD4wjGjpnJ/z8kLbiOS6ShDLlvsVkCR5qnMrjgLdXsZpTI5a+rK onqshrv64g4zFPQHG4q1l+AXiCVgjWd3xduc3u3g3X9pG9GaQT+SWpI/z2W+k3X1lBZ7 K5SQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=K7+zqygt; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from pete.vger.email (pete.vger.email. [2620:137:e000::3:6]) by mx.google.com with ESMTPS id b15-20020a63d30f000000b005b81f21a25csi3988797pgg.830.2023.10.19.00.28.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Oct 2023 00:28:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=K7+zqygt; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 4F5FE8185979; Thu, 19 Oct 2023 00:28:27 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232891AbjJSH21 (ORCPT + 52 others); Thu, 19 Oct 2023 03:28:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53228 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232326AbjJSH20 (ORCPT ); Thu, 19 Oct 2023 03:28:26 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ACC6C9F for ; Thu, 19 Oct 2023 00:28:24 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 906CCC433C7; Thu, 19 Oct 2023 07:28:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697700504; bh=wLug83WzbZFUzJwrfWYApiabQSQSYJjvixDTtNb76Kk=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=K7+zqygtwVXdr5mju/uqJRzS6CHMq0Fh/9y9IoQT9mqfDcZZMflDu9fGSznpbZ+YC 2FaQzBdadzuCLiBaQznya4VYCWuS+ZZcPug4C0GTxFiTGWZFFMsl2pbvsgBgRVnv6Y bpBQvaNdp82s7wQwqfkQcY+nJ4cYj9A8BkOVHFOXvQNNyffL8zNHQTSqXaaEahYgWf QUbt/4uGgIgVLZ7l2wtXSjDy3swFBZDU+Yk9lUGbeq0U5h4B9d4lG8IAXgaR76GVw1 a1/PoXPojnf6UWkaHOCl3G9R1bEMuh7ihEgN7unE20hf0tOQiPCoX4MIWjSV0jVo6t BiYfm+W9SoDYQ== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH 1/2] wifi: rtw88: debug: add to check if debug mask is enabled From: Kalle Valo In-Reply-To: <20231016053554.744180-2-pkshih@realtek.com> References: <20231016053554.744180-2-pkshih@realtek.com> To: Ping-Ke Shih Cc: , User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.11.2 Message-ID: <169770050162.117236.15126110048637490351.kvalo@kernel.org> Date: Thu, 19 Oct 2023 07:28:23 +0000 (UTC) X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Thu, 19 Oct 2023 00:28:27 -0700 (PDT) Ping-Ke Shih wrote: > From: Chin-Yen Lee > > The coming dump function for FW malfunction will add a function to > dump registers to reflect status. However, if we are not debugging > the mechanism, we don't print anything, so avoid reading registers by > checking debug mask to reduce IO. > > Signed-off-by: Chin-Yen Lee > Signed-off-by: Ping-Ke Shih 2 patches applied to wireless-next.git, thanks. 1926a27299db wifi: rtw88: debug: add to check if debug mask is enabled 20907fc06997 wifi: rtw88: dump firmware debug information in abnormal state -- https://patchwork.kernel.org/project/linux-wireless/patch/20231016053554.744180-2-pkshih@realtek.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches