Received: by 2002:a05:7412:f690:b0:e2:908c:2ebd with SMTP id ej16csp176462rdb; Thu, 19 Oct 2023 00:30:18 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFUBD/qUuOVA8BTQpdLbY6Ri95RZOWeN7CZ7NVLCtNKZxj9pynGIDvJ6AenkujcajcRBIHg X-Received: by 2002:a05:6870:a2d4:b0:1d5:40df:8fb1 with SMTP id w20-20020a056870a2d400b001d540df8fb1mr1694716oak.19.1697700618611; Thu, 19 Oct 2023 00:30:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697700618; cv=none; d=google.com; s=arc-20160816; b=Ck0IxbOxJN8q1vSVTRrQlQHKIp03gpzOgAq8sJFLeZ3owP5hSvibnVxJ0BmUuw6UX+ lBGnCneJwQeoAPLGQsWTR6f3qSX2zvQQay56cQYFYqkybv4YpXZNSZjCWp0Zzs9sXd8T 5Pmhbac2SaGGFNuWS5RttlN0QE3kRYel9yYPc/C/vgqbkAdEhJDW9DpkggZk9j+oroN+ uj0cDoKDz5jtK95PgHnXHWirARJrPPb9RoQmNAQcp30LcYlKiFp84OO6XB9VeWmbwRod pslY/6l3zoVOAktlPWB24tj1DpWWiWfDgbOFyyb0zIGQxnXLAvhGG6qWdxUCvK3LGntg 17RQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dkim-signature; bh=S4O9y2P7jH5JKEH6tzA6PkKrykoo4+miWRTCWnJrYqw=; fh=W+d0VTlB06MRf7YcZ9fsTH6rmN1qgblnN3a4fITKvd0=; b=CURiQeDsi1rI6eJIh8wpti9YQjsZScX67Gb/FBXY1T+0dZtECgYOF8KgAGpFlR3UzW aKBGbqFjWVj30h5xLVfi0z1K98u2GEFkb01n9twgT8HPqeuM7x3RGYzvZ1/VfDBtfXjS PJK1EMbiVX4jXZ/IoKVIe6zCQ+h8FWQfpRA8XxZZISCbNMsGvQSQ4OX6TemA7VoMnY1v WrKzW43Co6SJrVoMAoYiXbHrMVGbWSorIUFUB3zaO915RolTZTzmFBjnMNrQCCOMKT7r L8xvzHkE3qxpNzMahYH4/1V75ZSAaE0DyJOo3xS+Dh2OhPWBp+GkE84neW/tOoHYzudL wNuA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=OTUII57P; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id s29-20020a63925d000000b0056336fb99aasi3788926pgn.850.2023.10.19.00.30.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Oct 2023 00:30:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=OTUII57P; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 1E55B825CEF9; Thu, 19 Oct 2023 00:30:14 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344829AbjJSHaO (ORCPT + 52 others); Thu, 19 Oct 2023 03:30:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50692 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232326AbjJSHaN (ORCPT ); Thu, 19 Oct 2023 03:30:13 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7C1D89F for ; Thu, 19 Oct 2023 00:30:11 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 35FF7C433C8; Thu, 19 Oct 2023 07:30:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697700611; bh=Q6ljW3apHy3A+ic7lg/JrRHklhVp0Gl6lRNCyWGIAF8=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=OTUII57P8xo4sNMZA9SOyd75drmKpftt5eAoHmJ0vq57eh4LSpUGm5H0pEbOHVkdZ UJ+6kJFv4nmWMZp+pQxw7AOdEoPU9R9n3RaWjXa11U6IYCLjU6/LPJCDO40got0ucH ncFK61DjqM8wA2CG94qc9DrvJCF5rQPM+WUzLgw+awsSHTxe71q4rKwKOeMqkX2MRk 91s1Hh5A8JnczR4KS0LHiFeN2FiqBRngEJ8XfVN716XlQfjQmtdFxVDHupUfxQIUNH GKFCMjAxMq3vYtNOV+rCrB+HI7MNthn6Cq/aiTeRhL85ue3pMvesWlBUGZcelHrF6H qtnZg9LrIppNw== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH 1/3] wifi: rtlwifi: drop pre_fill_tx_bd_desc() from HAL interface From: Kalle Valo In-Reply-To: <20231016135925.129223-1-dmantipov@yandex.ru> References: <20231016135925.129223-1-dmantipov@yandex.ru> To: Dmitry Antipov Cc: Ping-Ke Shih , linux-wireless@vger.kernel.org, Dmitry Antipov User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.11.2 Message-ID: <169770060845.117236.6582869818092142659.kvalo@kernel.org> Date: Thu, 19 Oct 2023 07:30:10 +0000 (UTC) X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Thu, 19 Oct 2023 00:30:14 -0700 (PDT) Dmitry Antipov wrote: > Since 'pre_fill_tx_bd_desc()' is actually used for rtl8192ee only, > there is no need to maintain function pointer in 'struct rtl_hal_ops', > and 'rtl92ee_pre_fill_tx_bd_desc()' may be converted to static. > Compile tested only. > > Signed-off-by: Dmitry Antipov > Acked-by: Ping-Ke Shih 3 patches applied to wireless-next.git, thanks. fc83ee9d587f wifi: rtlwifi: drop pre_fill_tx_bd_desc() from HAL interface 9e58030622d0 wifi: rtlwifi: drop fill_fake_txdesc() from HAL interface 2f4ae0feab8b wifi: rtlwifi: drop chk_switch_dmdp() from HAL interface -- https://patchwork.kernel.org/project/linux-wireless/patch/20231016135925.129223-1-dmantipov@yandex.ru/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches