Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
From:   Kalle Valo <kvalo@kernel.org>
To:     Shiji Yang <yangshiji66@outlook.com>
Cc:     helmut.schaa@googlemail.com, linux-wireless@vger.kernel.org,
        stf_xl@wp.pl
Subject: Re: [PATCH] wifi: rt2x00: fix rt2800 watchdog function
References: <169769882877.117236.15856778587852752332.kvalo@kernel.org>
        <TYAP286MB0315BFF338DEE34898A20584BCD4A@TYAP286MB0315.JPNP286.PROD.OUTLOOK.COM>
Date:   Thu, 19 Oct 2023 16:33:02 +0300
In-Reply-To: <TYAP286MB0315BFF338DEE34898A20584BCD4A@TYAP286MB0315.JPNP286.PROD.OUTLOOK.COM>
        (Shiji Yang's message of "Thu, 19 Oct 2023 20:05:13 +0800")
Message-ID: <87h6mm20vl.fsf@kernel.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Shiji Yang <yangshiji66@outlook.com> writes:

> On Thu, 19 Oct 2023 07:00:30 +0000, Kalle Valo wrote:
>
>>Shiji Yang <yangshiji66@outlook.com> wrote:
>>
>>> The watchdog function is broken on rt2800 series SoCs. This patch
>>> fixes the incorrect watchdog logic to make it work again.
>>> 
>>> 1. Update current wdt queue index if it's not equal to the previous
>>>    index. Watchdog compares the current and previous queue index to
>>>    judge if the queue hung.
>>> 2. Make sure hung_{rx,tx} 'true' status won't be override by the
>>>    normal queue. Any queue hangs should trigger a reset action.
>>> 3. Clear the watchdog counter of all queues before resetting the
>>>    hardware. This change may help to avoid the reset loop.
>>> 4. Change hang check function return type to bool as we only need
>>>    to return two status, yes or no.
>>> 
>>> Signed-off-by: Shiji Yang <yangshiji66@outlook.com>
>>
>>Is this patch ok to take?
>
>
> Hi! I think it's ready. I've been testing it for a few weeks.

That question was more towards maintainers Stanislaw, Helmut and other
reviewers :)

That reminds me, is Helmut still maintaining this driver? I haven't seen
an ack from him since 2016. As we nowadays try to keep the MAINTAINERS
up-to-date so should we remove him?

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches