Received: by 2002:a05:7412:f690:b0:e2:908c:2ebd with SMTP id ej16csp512570rdb; Thu, 19 Oct 2023 10:31:16 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFkSuIRO8Ir8A3eua/le1niEcrPnmYE4ZJFt6yRWBibMbYVDKTp53PRv19CJlGpxbSci2uN X-Received: by 2002:a05:6a00:158d:b0:693:3783:4a29 with SMTP id u13-20020a056a00158d00b0069337834a29mr2999487pfk.20.1697736676465; Thu, 19 Oct 2023 10:31:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697736676; cv=none; d=google.com; s=arc-20160816; b=JwYZBOxh1ZqpXVk2vK1ij3KisDLcWTyn6XWaLp2Q1U7nGKe81nKo8ml95o/cTqni56 XHX5iDX7sj9Jw8Kaqrea1VI9rwRSCJjo4q2+P9K/VWSAFFgL2l8S2ONFpxEWYoZzlcoH oA3PhIrturi60LI+3KtU5kHxuddD4rHPelGyVtEsdFaM6KMR5sAwyq89/3BYKmXcmUj6 lTOUDYfA1xY8unIs7e+uvjsqcPFVIQtfHNsluORVmWmXykMHjLFICpp57ZkahIAaXSbG fMlCdQNL41LabBy4spp8S+T58XpIUS6GDXjHk32vtKA/whK5nPG2cZtAgmnSM5RmHubI cqqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=Nf/29FghDRhiaGg0xKf0f475ZS/kQXtuV2LNjym+dh8=; fh=JUpNa3XESH0nD9ShfiLavq1qMwyLD4w+KDqh0GJpXK8=; b=muMfXkNLTPFZyDgJeOfiy3zkv60uT6ZDNmoULa2r4s14kICcCW/2jui27RqsP0I/9i e6HNoYE4BsKg2ciMGoX5oGhc4sWPAyKKG2E8zIzYAbfBk33WZe6w8ydiAtrIierfAIa8 SMgsXgfL/4EhYsQtUI905kh9EI3EthF/s3oUFTTfrPxujPNBnP55QgtOQc2HAv1wEGE4 aPxfOpiQ4Gwyjrl/4Ul+W4KNiUhDVQFw4q70RTUeWtQB7vax19G1rvwy9wpvJRsyAgRa ltqpsQrkaB+8VAmFejEKOugjzDLnDD1r6+Qj260eRw1hP4NCaorjLsfMw79qRiBJG7Y5 qieQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=PFWGdF82; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from pete.vger.email (pete.vger.email. [2620:137:e000::3:6]) by mx.google.com with ESMTPS id bf20-20020a656d14000000b00582dcfe3b41si42478pgb.374.2023.10.19.10.31.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Oct 2023 10:31:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=PFWGdF82; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id DDA9681CE853; Thu, 19 Oct 2023 10:31:13 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346242AbjJSRbF (ORCPT + 52 others); Thu, 19 Oct 2023 13:31:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56506 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345309AbjJSRbE (ORCPT ); Thu, 19 Oct 2023 13:31:04 -0400 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E80A5CF; Thu, 19 Oct 2023 10:31:01 -0700 (PDT) Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 39JGRhcS030815; Thu, 19 Oct 2023 17:30:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=Nf/29FghDRhiaGg0xKf0f475ZS/kQXtuV2LNjym+dh8=; b=PFWGdF82f5gPEQkZ23uZCe67GzGwLlAkualgUXG2trnRxsJ5Ae1pkZnEg6140KNJhY0t bNm8btvhouoIXPI6nEOy5HYH20rwjE7bj6Wz3ZeUfVAzNf+kXHhTA5zjnbGClxE0ik32 DTmb2WSdzB5/wgCFAotiqjUZMB3wVWPiLnig7VmVesrCEt6910m/+yxp9ocNtJGJP55X OQmbJeD0vraOd4LIIXcyiW7c2OGRL7Tlh7DT1styz5tylm1dTP8nJVPXe6mFxowJS+VK MVXM4QbS/rASclgMDSeBSBN2Q3Gsxor1wiPUxths4sz6+5+76rYzQzwIiFMAZs7udLVR Dg== Received: from nalasppmta04.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3tu49b0qn3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 19 Oct 2023 17:30:58 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA04.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 39JHUvkp020339 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 19 Oct 2023 17:30:57 GMT Received: from [10.48.241.70] (10.49.16.6) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.39; Thu, 19 Oct 2023 10:30:57 -0700 Message-ID: <3cb5372a-aa11-4184-8f3d-969ee25e0642@quicinc.com> Date: Thu, 19 Oct 2023 10:30:56 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] wifi: ath12k: fix dfs-radar and temperature event locking Content-Language: en-US To: Johan Hovold , Kalle Valo CC: , , , References: <20231019113650.9060-1-johan+linaro@kernel.org> <20231019113650.9060-2-johan+linaro@kernel.org> From: Jeff Johnson In-Reply-To: <20231019113650.9060-2-johan+linaro@kernel.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.49.16.6] X-ClientProxiedBy: nalasex01a.na.qualcomm.com (10.47.209.196) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: L8mRo8YIcAOr2oMg7jgwUEJnQcbnmfcN X-Proofpoint-GUID: L8mRo8YIcAOr2oMg7jgwUEJnQcbnmfcN X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-10-19_16,2023-10-19_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=642 impostorscore=0 phishscore=0 bulkscore=0 adultscore=0 priorityscore=1501 mlxscore=0 lowpriorityscore=0 suspectscore=0 malwarescore=0 spamscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2309180000 definitions=main-2310190148 X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Thu, 19 Oct 2023 10:31:14 -0700 (PDT) On 10/19/2023 4:36 AM, Johan Hovold wrote: > The ath12k active pdevs are protected by RCU but the DFS-radar and > temperature event handling code calling ath12k_mac_get_ar_by_pdev_id() > was not marked as a read-side critical section. > > Mark the code in question as RCU read-side critical sections to avoid > any potential use-after-free issues. > > Note that the temperature event handler looks like a place holder > currently but would still trigger an RCU lockdep splat. > > Fixes: d889913205cf ("wifi: ath12k: driver for Qualcomm Wi-Fi 7 devices") > Cc: stable@vger.kernel.org # v6.2 > Signed-off-by: Johan Hovold Acked-by: Jeff Johnson