Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Subject: Re: [PATCH] wifi: ath9k: fix -Wformat-truncation warning
From:   Kalle Valo <kvalo@kernel.org>
In-Reply-To: <20231017155201.111950-1-dmantipov@yandex.ru>
References: <20231017155201.111950-1-dmantipov@yandex.ru>
To:     Dmitry Antipov <dmantipov@yandex.ru>
Cc:     =?utf-8?q?Toke_H=C3=B8iland-J=C3=B8rgensen?= <toke@toke.dk>,
        linux-wireless@vger.kernel.org,
        Dmitry Antipov <dmantipov@yandex.ru>
User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.11.2
Message-ID: <169781313737.352343.12523599682050042172.kvalo@kernel.org>
Date:   Fri, 20 Oct 2023 14:45:39 +0000 (UTC)
Precedence: bulk

Dmitry Antipov <dmantipov@yandex.ru> wrote:

> Fix the following warning observed with GCC 13.2 and -Wformat-truncation:
> 
> drivers/net/wireless/ath/ath9k/hif_usb.c: In function ‘ath9k_hif_request_firmware’:
> drivers/net/wireless/ath/ath9k/hif_usb.c:1223:42: warning: ‘.0.fw’ directive output
> may be truncated writing 5 bytes into a region of size between 4 and 11 [-Wformat-truncation=]
>  1223 |                          "%s/htc_%s-%d.%s.0.fw", HTC_FW_PATH,
>       |                                          ^~~~~
> drivers/net/wireless/ath/ath9k/hif_usb.c:1222:17: note: ‘snprintf’ output between
> 27 and 34 bytes into a destination of size 32
>  1222 |                 snprintf(hif_dev->fw_name, sizeof(hif_dev->fw_name),
>       |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>  1223 |                          "%s/htc_%s-%d.%s.0.fw", HTC_FW_PATH,
>       |                          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>  1224 |                          chip, MAJOR_VERSION_REQ, index);
> 
> According to the comment in 'ath9k_hif_request_firmware()', 36 bytes should be enough.
> 
> Suggested-by: Kalle Valo <kvalo@kernel.org>
> Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>

As I didn't get any replies to my RFH I unfortunately already fixed this myself:

https://patchwork.kernel.org/project/linux-wireless/patch/20231012135854.3473332-3-kvalo@kernel.org/

I just used a bigger buffer than you.

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20231017155201.111950-1-dmantipov@yandex.ru/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches