Received: by 2002:a05:7412:251c:b0:e2:908c:2ebd with SMTP id w28csp317009rda; Sat, 21 Oct 2023 08:52:30 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFB5IzyE13cd5OyLVpKj85On1dPsdw26wwyE5My/QhsLIRS2Uh3dPrnJwhb6dm1MtJgkGwp X-Received: by 2002:a17:902:f9c3:b0:1c9:d948:33ea with SMTP id kz3-20020a170902f9c300b001c9d94833eamr3539179plb.21.1697903550337; Sat, 21 Oct 2023 08:52:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697903550; cv=none; d=google.com; s=arc-20160816; b=E/5r6rHI4NcZtfZqusJ+OzoBLHB+jdm7uqNuxpXVS7Ah+EYlf+EwhjnneR/bcRavNK lcdVeR9M9ZL3nECP/VqW5WcVvKw6QtsXO4lIuyasKGeplFZWToOuCj/vPMFFW8eDbfdU x3v99xYbACyLz7RPA6F8FCp9yCHhksEC92Jvr2XIqm0ww55C51nKpHJYJVrSYgjw+qMz KVyUm/ot+Sf9R11x52qoVTADEKohAv5U9hc1PfZ/ZVZBGMkLk2Os7Gwun/uIM01xblmD tlVQpM/UTf96JRzfmTmIu9uUX4cuhYQbUNwXcfUBk8BlacgZeFpo3fnvJjLR8Njcr26s M4Qw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature:dkim-filter; bh=zBgzh+Kkig2C99n70dGOmG1y1msO7H0fO7Lc6BJHKeE=; fh=JBH4xoAqU+QnblKa21BUCNwDoqYIhtDQiRUeFKc8nFo=; b=ctp8I5t1C9OAS9wndjCtWRr/g+TJ9RCHC3H8qlA8QiYfCuGz/Nme3s+nn6emMMbrp/ LvmQHMmDqe6WD+d3YJvBjCMBpxbwMu45M2tIphltVvUITNLPSPOvLsL2bJlZk7U+nTwW CB0pg/cEhxaAH/jidluuKsJ0LOuqQG/MnD6DephlEDrSJ6QQ41F4pFp0CsjtgGOV0FuA MrJQX4R6PFZeFyDO3PitaKzOLl8sN0qXjxDTlTaepg7HLtA6oOvK0DV3BtN8W2tVM5Tt MSQOevfA7X6v5YLK5HgaJmn7KJmfWNB8pyJGJXt+urhYplbgeUG361h5vHh0R/tFbXgc 2wSg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@candelatech.com header.s=default header.b=mDXQk+zj; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=candelatech.com Return-Path: Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id q15-20020a17090311cf00b001b7ea20dbf2si3665460plh.224.2023.10.21.08.52.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Oct 2023 08:52:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; dkim=pass header.i=@candelatech.com header.s=default header.b=mDXQk+zj; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=candelatech.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id A9D9180BB6EC; Sat, 21 Oct 2023 08:52:25 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231403AbjJUPsk (ORCPT + 52 others); Sat, 21 Oct 2023 11:48:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47484 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229583AbjJUPsj (ORCPT ); Sat, 21 Oct 2023 11:48:39 -0400 Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.49]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 30A8D135 for ; Sat, 21 Oct 2023 08:48:35 -0700 (PDT) X-Virus-Scanned: Proofpoint Essentials engine Received: from mail3.candelatech.com (mail2.candelatech.com [208.74.158.173]) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id A5E4BC4005D for ; Sat, 21 Oct 2023 15:48:33 +0000 (UTC) Received: from ben-dt5.candelatech.com (50-251-239-81-static.hfc.comcastbusiness.net [50.251.239.81]) by mail3.candelatech.com (Postfix) with ESMTP id 135B013C2B0; Sat, 21 Oct 2023 08:48:33 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 mail3.candelatech.com 135B013C2B0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=candelatech.com; s=default; t=1697903313; bh=bQSguloIhJ24I1AK7EnMYfTF5biL+kIyn8Rmpab0mkc=; h=From:To:Cc:Subject:Date:From; b=mDXQk+zjiXiWDe1PTe9BXWNmVTQ1zpXXCLWS8jIyqEeiUsdd+R6KRVYe4pwJzZCe8 s2AtmCnC61mWF5b60RckehD3mlhPyK/Ma8BEhOfGTs/uXgz7jgD+81ngGqZpKDfpxZ kI4QYv57Xd/2nyD7GhbKJXRG7p++LAR40PHupriM= From: greearb@candelatech.com To: linux-wireless@vger.kernel.org Cc: Ben Greear Subject: [PATCH] wifi: wireless: Fix bad memory passed in inform_single_bss_data. Date: Sat, 21 Oct 2023 08:48:27 -0700 Message-Id: <20231021154827.1142734-1-greearb@candelatech.com> X-Mailer: git-send-email 2.40.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-MDID: 1697903314-YN1PqJ5r4uRI X-MDID-O: us5;ut7;1697903314;YN1PqJ5r4uRI;;f7146c1849a4b08a52804beb1c1cdf45 X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Sat, 21 Oct 2023 08:52:25 -0700 (PDT) From: Ben Greear The sins of similar variable names and passing void pointers are seen again in wireless-next tree. Wrong data was passed into the rdev_inform_bss method causing crashes. Signed-off-by: Ben Greear --- net/wireless/scan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/wireless/scan.c b/net/wireless/scan.c index 7f8e831ef1dc..52b048675cc7 100644 --- a/net/wireless/scan.c +++ b/net/wireless/scan.c @@ -2155,7 +2155,7 @@ cfg80211_inform_single_bss_data(struct wiphy *wiphy, if (!res) goto drop; - rdev_inform_bss(rdev, &res->pub, ies, data->drv_data); + rdev_inform_bss(rdev, &res->pub, ies, drv_data->drv_data); if (data->bss_source == BSS_SOURCE_MBSSID) { /* this is a nontransmitting bss, we need to add it to -- 2.40.0